Skip to content

[BUGFIX] Fix UIDs for files depending on class implementing FileInterface #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dvdmlln
Copy link
Contributor

@dvdmlln dvdmlln commented Aug 15, 2024

When using a file collection the fileReferenceUid field contains the actual file UID, while the uidLocal field is null. In this case, there is no FileReference, so fileReferenceUid field should be null.
uidLocal should always contain the file UID.

Maybe rename $fileReference variable to $file to avoid confusion?

@coveralls
Copy link

coveralls commented Aug 15, 2024

Pull Request Test Coverage Report for Build 13521158399

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.13%

Totals Coverage Status
Change from base Build 13456888799: 0.0%
Covered Lines: 1105
Relevant Lines: 1511

💛 - Coveralls

@lukaszuznanski
Copy link
Collaborator

to test by @twoldanski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants