[BUGFIX] Ignore f:then/f:else outside condition context#1052
Draft
[BUGFIX] Ignore f:then/f:else outside condition context#1052
Conversation
s2b
force-pushed
the
bugfix/thenElseOutsideIf
branch
from
edabe97 to
0a39cd6
Compare
Before this change, both `f:then` and `f:else` could be used outside of a condition tag and would then always output the content, regardless of any condition. Now, nothing is outputted. In the future, we might consider throwing an exception here to alert the user about invalid Fluid syntax. However, this would be a breaking change. Resolves: #1020
s2b
force-pushed
the
bugfix/thenElseOutsideIf
branch
from
0a39cd6 to
2adbed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, both
f:thenandf:elsecould be used outside ofa condition tag and would then always output the content, regardless
of any condition. Now, nothing is outputted.
In the future, we might consider throwing an exception here to alert the
user about invalid Fluid syntax. However, this would be a breaking change.
Resolves: #1020