[FEATURE] Striptags hrefs in brackets #1060
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…02651 Allow `<a>` tag href links to be appended in square brackets next to link text when `hrefsInBrackets` is enabled. Updated tests and documentation to reflect the new functionality.
Replace anonymous function with static function for better performance. Simplify array handling and validation logic for readability and maintainability. Ensure consistent behavior when processing invalid or empty links.
Modified the callback to sanitize link text using allowed tags and ensure URL validation is combined with non-empty text checks. Improves clarity and safety in the handling of <a> tags.
tgrigoryan234
changed the title
|
This looks confusing but slightly like a conversion from HTML to markdown. IMO something for a separate 3rd party package. |
|
I would say that this conversion should happen before stripTags(), not during. So this should be a separate ViewHelper. I'm not sure if it's generic enough to be part of Fluid Standalone though. In my opinion, it's too opinionated in contrast to other ViewHelpers. But I'm open to other opinions about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forge.typo3.org/issues/102651