fix(ui): restore Windows accent color on PySide 6.8.0.1 (Fix #668) #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes which
ColorRoleis used on Windows to select the system accent color. This seems to be a change made in PySide 6.8.0, however I can't find the change documented anywhere. TheQPalette.ColorRole.AlternateBaseColorRolealso doesn't seem to be quite the same as the oldQPalette.ColorRole.Accentcolor, so I've had to boost the lightness value a bit here. Other platforms (only tested on macOS) still use theQPalette.ColorRole.Accentvalue since it works, while theQPalette.ColorRole.AlternateBasedoes not.Fixes #668.