Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TCOMP-2260): validation tests #698

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

yyin-talend
Copy link
Collaborator

@yyin-talend yyin-talend commented Mar 15, 2023

https://jira.talendforge.org/browse/TCOMP-2260

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

What does this PR adds (design/code thoughts)?

@yyin-talend yyin-talend requested a review from undx March 15, 2023 06:55
undx

This comment was marked as resolved.

@undx undx changed the title Undx/testing validation fix(TCOMP-2260): validation tests Mar 28, 2023
undx
undx previously approved these changes Apr 11, 2023
Copy link
Member

@undx undx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments but lgtm

undx
undx previously approved these changes Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants