Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ARCH-662): upgrade storybook to 7 #4538

Merged
merged 150 commits into from
Sep 29, 2023
Merged

chore(ARCH-662): upgrade storybook to 7 #4538

merged 150 commits into from
Sep 29, 2023

Conversation

jmfrancois
Copy link
Collaborator

@jmfrancois jmfrancois commented Jan 11, 2023 •
edited
Loading

What is the problem this PR is trying to solve?

We have a bunch of force resolution because of storybook dep on webpack 4
Fall under unset-value security issue.

What is the chosen solution to this problem?

DEMO: http://4538.talend.surge.sh/

details:

  • upgrade to latest
  • remove manager-webpack5 as now the manager is build using vite
  • add framework in config (react-webpack5)
  • create storybook-one package to have one storybook for chromatic
  • keep storybook package to design-system doc (change the name ?)
  • override storybook webpack config to support mono repository
  • fix form stories

Will be done in a next PR

  • sb doc (design.talend.com)
  • deploy sb doc on github page and ask to move design.talend.com to it

Here is the common storybook hierarchy

image

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 11, 2023 08:31 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 11, 2023 08:31 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 12, 2023 09:25 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 12, 2023 09:25 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 12, 2023 12:27 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 12, 2023 12:27 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 26, 2023 09:17 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 26, 2023 09:17 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 26, 2023 09:22 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 26, 2023 09:22 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 08:45 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 08:46 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 08:46 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 08:46 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 12:18 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 12:18 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 12:18 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 12:18 — with GitHub Actions Inactive
smouillour
smouillour reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@smouillour smouillour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add those deps in storybook-docs
figma-js
react
classnames

packages/design-docs/src/StatusTable.tsx Show resolved Hide resolved
packages/design-system/src/stories/icons/Icon.stories.tsx Outdated
Comment on lines 1 to 3
import { useState, useEffect } from 'react';
import type { ChangeEvent, FormEvent } from 'react';
import { IconGallery, IconItem } from '@storybook/blocks';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import are not used

packages/design-system/src/stories/Status.block.tsx
@@ -0,0 +1,9 @@
import statuses from './status.json';
import { Statuses, ComponentStatuses } from '@talend/storybook-docs';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@talend/storybook-docs should be added as dependency

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will use a joker here to fix that in a later PR.
We must remove the DS from all our docs blocks and just use plain react or svg things.

smouillour
smouillour reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@smouillour smouillour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add those deps in storybook-docs
figma-js
react
classnames

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 13:49 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 13:49 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 13:50 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 13:50 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 13:50 — with GitHub Actions Inactive
@jmfrancois jmfrancois enabled auto-merge (squash) September 29, 2023 13:54
@jmfrancois jmfrancois merged commit 3b058ef into master Sep 29, 2023
8 checks passed
@jmfrancois jmfrancois deleted the jmfrancois/chore/storybook-beta branch September 29, 2023 14:10
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 29, 2023 14:10 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhuchet mhuchet mhuchet left review comments

@inna-i inna-i inna-i left review comments

@smouillour smouillour smouillour approved these changes

@Nigui Nigui Nigui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmfrancois @Nigui @inna-i @smouillour @mhuchet @cbaune-talend