Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): remove cdn from webpack configs #4873

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmfrancois
Copy link
Collaborator

What is the problem this PR is trying to solve?

We have now a code base which is aligned with mainstream patterns but still a way to compute external from the code which is too complex.

What is the chosen solution to this problem?

Let's remove it from the webpack config and see the impact.
Teams can already test by using the following configuration in talend-scripts.json

 { "dynamic-cdn-webpack-plugin": false }

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 5, 2023 07:40 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe September 5, 2023 07:40 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants