fix: update postcss [security] #5314

jmfrancois · 2024-05-21T11:12:03Z

What is the problem this PR is trying to solve?

postcss security issue force us to update css-loader.
Note there is a big change in css-loader 7

What is the chosen solution to this problem?
Adapt breaking changes for css-loader 6&7.
For version 6: file-loader and url-loader are deprecated, migrate on asset modules. More details
For version 7: The modules.namedExport option is true by default if you enable the esModule option. More details. This change impacts how CSS files are imported when using CSS Modules. Need update the modules config to keep the old behaviors. If not using CSS modules no changes required.

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2024-05-21T11:25:13Z

5314

Demo is available here

github-actions · 2024-05-21T11:27:15Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.18% (1237/1387)	80.88% (605/748)	89.28% (350/392)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.8% (5528/6088)	81.84% (3206/3917)	88.14% (1390/1577)
containers	83.59% (1391/1664)	74.3% (694/934)	75% (327/436)
dataviz	85.44% (323/378)	66.66% (160/240)	75.79% (119/157)
design-system	66.75% (996/1492)	50.85% (536/1054)	54.54% (216/396)
faceted-search	85.69% (677/790)	79.37% (304/383)	82.63% (238/288)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.8% (1638/1909)	75.73% (927/1224)	84.24% (460/546)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (73/73)	90.9% (10/11)	100% (24/24)

github-actions · 2024-05-21T11:30:46Z

Size Change: +157 B (0%)

Total Size: 16.9 MB

Filename	Size	Change
`./packages/components/dist/TalendReactComponents.css`	397 kB	-188 B (-0.05%)
`./packages/components/dist/TalendReactComponents.min.css`	211 kB	-188 B (-0.09%)
`./packages/design-system/dist/TalendDesignSystem.css`	332 kB	+446 B (+0.13%)
`./packages/design-system/dist/TalendDesignSystem.js`	1.37 MB	-184 B (-0.01%)
`./packages/design-system/dist/TalendDesignSystem.min.css`	215 kB	+446 B (+0.21%)
`./packages/design-system/dist/TalendDesignSystem.min.js`	245 kB	-184 B (-0.07%)

ℹ️ View Unchanged

Filename	Size	Change
`./packages/assets-api/dist/TalendAssetsApi.js`	7.09 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.32 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	205 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	670 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	11.3 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	693 B	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	164 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	12.7 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js`	505 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.3 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	65.1 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB	0 B
`./packages/components/dist/TalendReactComponents.js`	4.73 MB	+28 B (0%)
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js`	1.26 MB	+31 B (0%)
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB	0 B
`./packages/containers/dist/TalendReactContainers.css`	2.99 kB	0 B
`./packages/containers/dist/TalendReactContainers.js`	635 kB	0 B
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.4 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.css`	1.78 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js`	93 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.45 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.css`	28.1 kB	-6 B (-0.02%)
`./packages/dataviz/dist/TalendReactDataviz.js`	371 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12.2 kB	-6 B (-0.05%)
`./packages/dataviz/dist/TalendReactDataviz.min.js`	59.5 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.18 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.52 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.56 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.css`	79.1 kB	-4 B (-0.01%)
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.7 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	75 kB	-4 B (-0.01%)
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.4 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	19.1 kB	-4 B (-0.02%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	542 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.54 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	6.27 kB	-4 B (-0.06%)
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	100 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.59 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	50.8 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB	0 B
`./packages/forms/dist/TalendReactForms.css`	20.8 kB	-6 B (-0.03%)
`./packages/forms/dist/TalendReactForms.js`	1.46 MB	0 B
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.35 kB	0 B
`./packages/forms/dist/TalendReactForms.min.css`	6.2 kB	-6 B (-0.1%)
`./packages/forms/dist/TalendReactForms.min.js`	267 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB	0 B
`./packages/http/dist/TalendHttp.js`	24.6 kB	0 B
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B	0 B
`./packages/http/dist/TalendHttp.min.js`	5.3 kB	0 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B	0 B
`./packages/icons/dist/bundle.js`	1.26 kB	0 B
`./packages/icons/dist/info.js`	26.8 kB	0 B
`./packages/icons/dist/react.esm.js`	614 kB	0 B
`./packages/icons/dist/react.js`	654 kB	0 B
`./packages/icons/dist/talend-icons-webfont.css`	18.3 kB	0 B
`./packages/icons/dist/talendicons.css`	334 B	0 B
`./packages/icons/dist/TalendIcons.js`	787 kB	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B	0 B
`./packages/icons/dist/TalendIcons.min.js`	636 kB	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B	0 B
`./packages/icons/dist/typeUtils.js`	14.5 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	135 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js`	10.8 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	349 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	361 B	0 B
`./packages/stepper/dist/TalendReactStepper.css`	2.41 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js`	97.9 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.css`	1.2 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	9.37 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.3 kB	0 B
`./packages/storybook-docs/dist/globalStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	384 B	0 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.5 kB	0 B
`./packages/theme/dist/bootstrap.css`	171 kB	-10 B (-0.01%)
`./packages/theme/dist/bootstrap.js`	2.38 kB	0 B
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B	0 B

_{compressed-size-action}

yyanwang · 2024-09-09T12:15:59Z

packages/theme/webpack.config.js

-							},
-						},
-					],
+					type: 'asset/resource',


adapt to breaking changes of css-loader 6:
https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md#notes

fix: update postcss [security]

004989b

jmfrancois temporarily deployed to pull_request_unsafe May 21, 2024 11:12 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe May 21, 2024 11:12 — with GitHub Actions Error

fix: axios

cc6955e

jmfrancois temporarily deployed to pull_request_unsafe May 21, 2024 11:15 — with GitHub Actions Inactive

Merge branch 'master' into jmfrancois/chore/update-postcss

a73aea0

jmfrancois temporarily deployed to pull_request_unsafe May 21, 2024 11:15 — with GitHub Actions Inactive

jmfrancois added the work in progress label May 21, 2024

Merge branch 'master' into jmfrancois/chore/update-postcss

ce526ce

jmfrancois temporarily deployed to pull_request_unsafe May 24, 2024 09:11 — with GitHub Actions Inactive

Merge branch 'master' into jmfrancois/chore/update-postcss

54cd1de

jmfrancois had a problem deploying to pull_request_unsafe August 27, 2024 15:07 — with GitHub Actions Error

jmfrancois temporarily deployed to pull_request_unsafe August 27, 2024 15:07 — with GitHub Actions Inactive

jmfrancois had a problem deploying to pull_request_unsafe August 27, 2024 15:07 — with GitHub Actions Error

fix: try to add the config to go back on 6.x behavior

c096b88

jmfrancois temporarily deployed to pull_request_unsafe August 27, 2024 15:14 — with GitHub Actions Inactive

jmfrancois temporarily deployed to pull_request_unsafe August 27, 2024 15:46 — with GitHub Actions Inactive

fix: add as-is to the webpack config

ee5a127

jmfrancois temporarily deployed to pull_request_unsafe August 28, 2024 10:03 — with GitHub Actions Inactive

yyanwang added 5 commits September 9, 2024 10:52

fix css-loader configuration for bootstrap.scss

df7ea67

remove file-loader, it's deprecated

5a6e6e2

rm url-loader

69fe56e

rm url-loader

2e7f839

fix css modules config

628d035

yyanwang temporarily deployed to pull_request_unsafe September 9, 2024 12:14 — with GitHub Actions Inactive

yyanwang reviewed Sep 9, 2024

View reviewed changes

Merge branch 'master' into jmfrancois/chore/update-postcss

7f85b0a

yyanwang temporarily deployed to pull_request_unsafe September 9, 2024 14:02 — with GitHub Actions Inactive

yyanwang marked this pull request as ready for review September 10, 2024 06:32

smouillour approved these changes Sep 10, 2024

View reviewed changes

Gbacc approved these changes Sep 10, 2024

View reviewed changes

jmfrancois merged commit 71a6433 into master Sep 10, 2024
11 checks passed

jmfrancois deleted the jmfrancois/chore/update-postcss branch September 10, 2024 08:39

jmfrancois had a problem deploying to pull_request_unsafe September 10, 2024 08:39 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update postcss [security] #5314

fix: update postcss [security] #5314

jmfrancois commented May 21, 2024 •

edited by yyanwang

Loading

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

yyanwang Sep 9, 2024

fix: update postcss [security] #5314

fix: update postcss [security] #5314

Conversation

jmfrancois commented May 21, 2024 • edited by yyanwang Loading

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024 • edited Loading

yyanwang Sep 9, 2024

Choose a reason for hiding this comment

jmfrancois commented May 21, 2024 •

edited by yyanwang

Loading

github-actions bot commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024 •

edited

Loading