Skip to content

test(query-core): use fake timers for queryObserver.test.tsx #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TkDodo merged 11 commits into from
Apr 23, 2025
Merged

test(query-core): use fake timers for queryObserver.test.tsx #9004

TkDodo merged 11 commits into from
Apr 23, 2025

Conversation

@manudeli
Copy link
Collaborator

@manudeli manudeli commented Apr 12, 2025

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Apr 12, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 616792a.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 4m 49s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-23 07:50:57 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 12, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9004

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9004

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9004

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9004

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9004

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9004

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9004

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9004

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9004

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9004

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9004

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9004

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9004

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9004

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9004

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9004

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9004

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9004

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9004

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9004

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9004

commit: 616792a

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 12, 2025

sorry I think I added a test in queryObserver.test.tsx that would also need migration:

'should use cached selectResult when switching between queries and placeholderData returns previousData'

thanks 🙏

@manudeli
Copy link
Collaborator Author

manudeli commented Apr 23, 2025

sorry I think I added a test in queryObserver.test.tsx that would also need migration:

'should use cached selectResult when switching between queries and placeholderData returns previousData'

thanks 🙏

@TkDodo I reflected it

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 23, 2025

knip is failing:

Unused devDependencies (1)
@testing-library/dom  packages/query-core/package.json:61:6
 ELIFECYCLE  Command failed with exit code 1.

@manudeli
Removes unused testing library dependency
bf34873 
Deletes `@testing-library/dom` from devDependencies in package.json and pnpm-lock.yaml to clean up unused dependencies and streamline the project's dependency tree.
@manudeli
Copy link
Collaborator Author

manudeli commented Apr 23, 2025

knip is failing:

Unused devDependencies (1)
@testing-library/dom  packages/query-core/package.json:61:6
 ELIFECYCLE  Command failed with exit code 1.

I removed unnecessary @testing-library/dom

@TkDodo TkDodo merged commit 1b169ae into TanStack:main Apr 23, 2025
4 of 5 checks passed
@yashuatla yashuatla mentioned this pull request Jun 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: query-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manudeli @TkDodo