chore(deps): update all non-major dependencies #9731
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=80&v=4){kind=small}
|
github-actions
bot
added
package: react-query-devtools
package: react-query
package: react-query-persist-client
package: vue-query
package: query-core
package: solid-query
package: query-persist-client-core
package: eslint-plugin-query
package: svelte-query
package: svelte-query-devtools
package: query-devtools
package: angular-query-experimental
package: query-async-storage-persister
package: query-sync-storage-persister
package: solid-query-persist-client
package: svelte-query-persist-client
package: solid-query-devtools
package: query-broadcast-client-experimental
package: react-query-next-experimental
package: angular-query-persist-client
package: query-test-utils
labels
WalkthroughBatched dependency and devDependency version bumps across many example, integration, and package Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 3m 58s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
✅ Succeeded | 1m 25s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-10-18 09:23:32 UTC
|
Sizes for commit 9a02864:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (76)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.jsonpackages/react-query/package.jsonpackages/query-persist-client-core/package.jsonpackages/query-broadcast-client-experimental/package.jsonpackages/query-sync-storage-persister/package.jsonpackages/query-async-storage-persister/package.jsonpackages/svelte-query-devtools/package.jsonintegrations/solid-vite/package.jsonpackages/solid-query-persist-client/package.jsonpackages/svelte-query-persist-client/package.jsonpackages/react-query-next-experimental/package.jsonpackages/solid-query-devtools/package.jsonpackages/react-query-persist-client/package.jsonpackages/react-query-devtools/package.jsonpackages/svelte-query/package.jsonintegrations/react-vite/package.jsonintegrations/react-next-15/package.jsonpackages/angular-query-experimental/package.jsonpackages/angular-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (17)
packages/solid-query-devtools/package.json (1)
68-72: Solid devtool deps align with latest patches.The patched versions of
solid-js,vite-plugin-solid, andnpm-run-all2stay within existing peer ranges and match the rest of the Solid workspace upgrades. Looks good.packages/query-devtools/package.json (1)
67-81: Solid devtools stack remains coherent.The Solid-related tooling and styling packages now target the same 1.9.9/0.3.x patch line as the other packages in this PR, so the matrix stays consistent. No blockers spotted.
integrations/angular-cli-20/package.json (1)
11-26: Angular example tracks 20.3.x baseline cleanly.The dependency set (framework, CLI/build, zone.js) now lines up with Angular 20.3.x, matching the other Angular examples. Nothing further needed.
package.json (1)
8-81: Root tooling refresh looks safe.The pnpm bump plus lint/test/tooling updates remain within compatible ranges used across the repo. No regressions anticipated.
packages/query-broadcast-client-experimental/package.json (1)
62-68: Broadcast client deps updated without surprises.
broadcast-channel7.1.0 and the associated React tooling bumps are patch-level and align with the rest of the workspace.packages/angular-query-experimental/package.json (1)
92-103: Angular devDeps synchronized with 20.3.x.Bringing the package’s dev tooling up to the 20.3.x line keeps it consistent with the integration and example apps. Everything remains within the existing peer requirements.
examples/react/eslint-legacy/package.json (1)
23-23: React example tooling in sync.The plugin bump mirrors the other React examples, keeping the toolchain consistent. All good.
examples/react/playground/package.json (1)
17-17: Playground matches the updated React toolchain.
@vitejs/plugin-reactis now aligned with the rest of the React examples. Looks solid.examples/react/shadow-dom/package.json (1)
19-19: Upgrade aligns with current Vite tooling.Bumping
@vitejs/plugin-reactto^4.7.0keeps this example in sync with the rest of the React demos and matches the Vite 6.3.x toolchain already declared. Looks good.examples/react/suspense/package.json (1)
19-19: Consistent plugin bump.Updating
@vitejs/plugin-reacthere to^4.7.0stays aligned with the tooling stack used across the React examples, so this looks good.examples/react/simple/package.json (1)
17-17: LGTM for the plugin update.The move to
@vitejs/plugin-react@^4.7.0keeps this example consistent with the rest of the React suite and the current Vite major.examples/vue/basic/package.json (1)
16-16: Vue plugin bump looks good.
@vitejs/plugin-vue→^5.2.4keeps this example aligned with the newer Vite 6.3.x stack; no concerns.examples/vue/simple/package.json (1)
16-16: Consistent Vue tooling upgrade.Updating
@vitejs/plugin-vueto^5.2.4keeps this sample aligned with the other Vue examples and current Vite.examples/react/default-query-function/package.json (1)
17-17: React plugin update verified.The
@vitejs/plugin-reactupgrade to^4.7.0matches the rest of the project’s tooling updates—looks good here.examples/react/devtools-panel/package.json (1)
17-17: Tooling bump confirmed.Moving
@vitejs/plugin-reactto^4.7.0aligns this package with the updated toolchain across the React examples.examples/react/basic-graphql-request/package.json (2)
13-14: GraphQL stack bump LGTM.
graphql@^16.11.0andgraphql-request@^7.2.0remain within the 16.x/7.x lines, so no breaking API changes are expected. Combined with the Vite React plugin bump, this keeps the example current.
19-19: React plugin upgrade approved.The
@vitejs/plugin-reactupdate to^4.7.0matches the rest of the repo’s tooling—looks good.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
2 times, most recently
from
2c5f855 to
c1de76b
Compare
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
2 times, most recently
from
79af6b4 to
9ef56c0
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (8)
examples/react/react-router/package.json (1)
26-29:@vitejs/plugin-reactstill mismatched with Vite 6 — see earlier review note.This is the same peer-dependency break already flagged: Vite is
^6.4.0, plugin^4.7.0only peers up to Vite 5. Please bump the plugin to a Vite 6-aware version (e.g.^5.0.0).examples/angular/query-options-from-a-service/package.json (1)
23-26: TypeScript pin violates Angular 20.3 peer rangeAngular 20.3.x (@angular/cli/build 20.3.6) requires
typescript >=5.9.0 <6.0.0. Keeping5.8.3will fail peer install/build (pnpm/npm). Please bump to a compatible 5.9.x release and refresh the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/optimistic-updates/package.json (1)
23-26: Upgrade TypeScript to match Angular 20.3 requirementsWith @angular/cli/build 20.3.6, TypeScript must be ≥5.9.0 and <6.0.0. The 5.8.3 pin causes peer dependency failures. Please move to a supported 5.9.x version and update the lockfile accordingly.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/rxjs/package.json (1)
23-26: Update TypeScript to a supported 5.9.x buildAngular 20.3.6 tooling drops support for TS 5.8.x. Keeping
5.8.3violates the>=5.9.0 <6.0.0peer range and breaks installs. Please bump to a 5.9.x release and regenerate the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/basic-persister/package.json (1)
24-27: Bump TypeScript into Angular 20.3’s supported window@angular/cli/build 20.3.6 expects
typescript >=5.9.0 <6.0.0. The current 5.8.3 pin is unsupported and causes peer dependency failures. Please upgrade to a compatible 5.9.x version and update the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/router/package.json (1)
12-26: Upgrade TypeScript to satisfy Angular 20.3.x peers.@angular/cli and @angular/build 20.3.6 require TypeScript >=5.9.0 <6.0.0, but this example still pins 5.8.3, so installs/builds will fail with an unsatisfied peer dependency. Please bump the TypeScript devDependency (e.g.,
"typescript": "^5.9.0") and update the lockfile.examples/angular/auto-refetching/package.json (1)
12-26: Bring TypeScript into Angular 20.3.x’s supported range.With @angular/cli/@angular/build 20.3.6 now required, keeping TypeScript at 5.8.3 violates their peer range (needs >=5.9.0 <6.0.0) and will break installs. Please bump the TypeScript devDependency accordingly and refresh the lockfile.
examples/angular/infinite-query-with-max-pages/package.json (1)
12-26: Update TypeScript to match Angular tooling requirements.This package upgrades to @angular/cli/@angular/build 20.3.6, whose peer dependency demands TypeScript >=5.9.0 and <6.0.0. The current
"typescript": "5.8.3"will cause installation/build failures; please raise it (e.g.,"^5.9.0") and re-lock dependencies.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- integrations/vue-vite/package.json
- examples/react/devtools-panel/package.json
🚧 Files skipped from review as they are similar to previous changes (48)
- packages/vue-query-devtools/package.json
- packages/query-persist-client-core/package.json
- examples/solid/basic/package.json
- packages/solid-query-devtools/package.json
- examples/vue/basic/package.json
- examples/svelte/simple/package.json
- examples/react/simple/package.json
- packages/react-query-persist-client/package.json
- examples/solid/solid-start-streaming/package.json
- examples/solid/default-query-function/package.json
- packages/angular-query-persist-client/package.json
- examples/vue/simple/package.json
- packages/solid-query-persist-client/package.json
- integrations/react-webpack-5/package.json
- examples/react/eslint-legacy/package.json
- examples/react/playground/package.json
- examples/vue/persister/package.json
- examples/angular/simple/package.json
- examples/angular/devtools-panel/package.json
- examples/vue/dependent-queries/package.json
- examples/angular/pagination/package.json
- examples/svelte/ssr/package.json
- packages/svelte-query-persist-client/package.json
- examples/svelte/star-wars/package.json
- examples/react/suspense/package.json
- examples/vue/2.6-basic/package.json
- packages/svelte-query-devtools/package.json
- packages/svelte-query/package.json
- packages/angular-query-experimental/package.json
- examples/solid/basic-graphql-request/package.json
- examples/svelte/basic/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/optimistic-updates/package.json
- examples/svelte/playground/package.json
- packages/query-async-storage-persister/package.json
- examples/react/react-native/package.json
- integrations/react-vite/package.json
- examples/solid/astro/package.json
- examples/angular/basic/package.json
- packages/react-query/package.json
- integrations/angular-cli-20/package.json
- packages/query-devtools/package.json
- packages/react-query-devtools/package.json
- packages/solid-query/package.json
- examples/react/algolia/package.json
- examples/react/shadow-dom/package.json
- packages/eslint-plugin-query/package.json
- examples/react/rick-morty/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-sync-storage-persister/package.jsonpackages/react-query-next-experimental/package.jsonintegrations/solid-vite/package.jsonpackages/query-core/package.jsonintegrations/react-next-15/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
| "@tailwindcss/vite": "^4.1.14", | ||
| "@vitejs/plugin-react": "^4.7.0", | ||
| "tailwindcss": "^4.1.14", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
Raise @vitejs/plugin-react to the Vite 6-compatible major.
This example now uses vite@^6.4.0, but @vitejs/plugin-react@^4.7.0 declares peers only up to Vite 5. pnpm will refuse installs because of the peer-range violation. Please bump the plugin to a release that supports Vite 6 (e.g. ^5.0.0).
🤖 Prompt for AI Agents
In examples/react/chat/package.json around lines 17 to 21 the current dependency
"@vitejs/plugin-react": "^4.7.0" is incompatible with vite@^6.4.0 (peer range
only up to Vite 5), so update the plugin to a Vite‑6‑compatible major (for
example change the version spec to "^5.0.0"); after updating package.json run
your package manager (pnpm install) to update the lockfile and verify installs
succeed without peer-range errors.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "next": "^15.3.1", | ||
| "npm-run-all2": "^5.0.0", | ||
| "npm-run-all2": "^5.0.2", | ||
| "react": "^19.0.0" |
There was a problem hiding this comment.
Bump @vitejs/plugin-react to the Vite 6-compatible release.
Our workspace is moving to Vite 6, but @vitejs/plugin-react@^4.7.0 still peers only ^4.2.0 || ^5.0.0. pnpm will flag this mismatch once it hoists Vite 6 into the workspace. Please upgrade the plugin to the first version that advertises Vite 6 support (e.g. ^5.0.0).
🤖 Prompt for AI Agents
In packages/react-query-next-experimental/package.json around lines 61 to 64,
update the @vitejs/plugin-react dependency from "^4.7.0" to a Vite 6–compatible
release (e.g. "^5.0.0") to satisfy the peer dependency for Vite 6; after editing
package.json run your package manager install (pnpm install) to update the
lockfile and verify there are no peer dependency warnings or breakages in the
workspace.
9ef56c0 to
f0fcfac
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/react/eslint-legacy/package.json (1)
16-16: Bump @types/react and @types/react-dom to ^19.x
React is at ^19.0.0 while types are still ^18.x—update @types/react and @types/react-dom to ^19.x in examples/react/{algolia,basic,eslint-legacy,react-router}/package.json to prevent TS mismatches.
♻️ Duplicate comments (6)
examples/vue/persister/package.json (1)
19-22: Align @vitejs/plugin-vue to Vite 6 (upgrade to 6.x) or keep Vite 5.@vitejs/plugin-vue 5.x targets Vite 5; this project uses Vite 6.4.0. Upgrade plugin to 6.x (preferred) or downgrade Vite to 5.x.
Proposed fix:
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0", "typescript": "5.8.3", - "vite": "^6.4.0" + "vite": "^6.4.0"Repo-wide check for mismatches (Vite 6 + plugin-vue 5):
#!/bin/bash set -euo pipefail fd -t f package.json | while read -r f; do vite=$(jq -r '.devDependencies.vite // empty' "$f") pv=$(jq -r '.devDependencies["\@vitejs/plugin-vue"] // empty' "$f") if [[ -n "$vite" && "$vite" =~ ^[\^\~]?6 ]] && [[ -n "$pv" && "$pv" =~ ^[\^\~]?5 ]]; then echo "$f -> vite=$vite @vitejs/plugin-vue=$pv" fi doneexamples/angular/optimistic-updates/package.json (1)
23-26: Upgrade TypeScript to the Angular 20.3.x supported rangeAngular CLI/build 20.3.6 peers on TypeScript >=5.9.0 <6.0.0. Leaving the pin at 5.8.3 will cause peer-resolution/install failures. Please bump the manifest (and regenerate the lockfile) to a compatible range such as
^5.9.0.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/pagination/package.json (1)
22-26: Update TypeScript to satisfy Angular 20.3.xAngular 20.3.6 tooling mandates TypeScript >=5.9.0 <6.0.0. Keeping 5.8.3 violates the peer range and will break installs/builds. Please bump the pin and refresh the lockfile.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/router/package.json (1)
23-26: Bring TypeScript in line with Angular 20.3.x requirements@angular/cli/build 20.3.6 peers on TypeScript >=5.9.0 <6.0.0. The current 5.8.3 pin is outside that range, leading to install/build failures. Please bump to a compatible version and regenerate the lockfile.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/devtools-panel/package.json (1)
23-26: Align TypeScript with Angular 20.3.x peer windowAngular 20.3.6 tooling requires TypeScript >=5.9.0 <6.0.0. Retaining 5.8.3 violates the peer constraint and will break installs/builds. Please bump the pin (e.g.,
^5.9.0) and update the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/svelte/star-wars/package.json (1)
15-23: Tailwind 4 upgrade is incomplete
Jumping to@tailwindcss/vite/tailwindcss^4.1.14 without the new Tailwind 4 entry points and config removal will break this Svelte example (Tailwind 4 dropstailwind.config.*, changes CLI flags, etc.). Please keep Tailwind 3.x or include the required migration (new CSS entry,@tailwinddirectives, updated Vite plugin wiring).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- integrations/react-next-15/package.json
🚧 Files skipped from review as they are similar to previous changes (57)
- examples/vue/basic/package.json
- packages/vue-query-devtools/package.json
- packages/query-test-utils/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- integrations/react-webpack-5/package.json
- examples/solid/default-query-function/package.json
- examples/react/default-query-function/package.json
- packages/solid-query/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/devtools-panel/package.json
- examples/solid/basic/package.json
- examples/vue/2.6-basic/package.json
- packages/solid-query-devtools/package.json
- examples/react/rick-morty/package.json
- packages/query-persist-client-core/package.json
- examples/react/shadow-dom/package.json
- integrations/react-vite/package.json
- packages/svelte-query/package.json
- examples/react/algolia/package.json
- examples/angular/simple/package.json
- examples/vue/dependent-queries/package.json
- packages/query-core/package.json
- examples/svelte/optimistic-updates/package.json
- examples/svelte/basic/package.json
- packages/angular-query-persist-client/package.json
- examples/vue/2.7-basic/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/auto-refetching/package.json
- examples/vue/simple/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-devtools/package.json
- examples/angular/rxjs/package.json
- packages/svelte-query-devtools/package.json
- packages/angular-query-experimental/package.json
- packages/query-sync-storage-persister/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/angular/auto-refetching/package.json
- packages/react-query-next-experimental/package.json
- examples/svelte/playground/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- integrations/angular-cli-20/package.json
- packages/vue-query/package.json
- examples/react/playground/package.json
- examples/react/simple/package.json
- examples/react/offline/package.json
- examples/react/chat/package.json
- integrations/react-webpack-4/package.json
- examples/angular/basic/package.json
- examples/solid/astro/package.json
- packages/react-query/package.json
- examples/angular/basic-persister/package.json
- examples/solid/simple/package.json
- examples/react/react-router/package.json
- examples/react/star-wars/package.json
- integrations/vue-vite/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
integrations/solid-vite/package.jsonpackages/react-query-persist-client/package.jsonpackages/react-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (6)
examples/svelte/simple/package.json (1)
16-21: LGTM — Svelte/Vite tooling updates look compatible.examples/vue/nuxt3/package.json (1)
10-10: LGTM — Dependency bumps are safe here.Also applies to: 13-14
examples/react/suspense/package.json (1)
19-21: LGTM — React/Vite tooling aligned.integrations/solid-vite/package.json (1)
11-13: LGTM — Solid Vite integration deps updated appropriately.examples/solid/solid-start-streaming/package.json (1)
14-19: LGTM — SolidStart/vinxi versions updated coherently.packages/react-query-persist-client/package.json (1)
67-71: LGTM — Dev dependency updates only; no API impact.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
f0fcfac to
53ca8f4
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (11)
examples/vue/simple/package.json (1)
16-19: Align@vitejs/plugin-vuewith Vite 6.
@vitejs/plugin-vue@^5.2.4peers againstvite@^5. Keeping Vite on ^6.4.0 will fail peer resolution under pnpm and can break dev/build. Please upgrade the plugin to the 6.x line (or revert Vite to 5.x) before merging.Apply this diff:
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0", @@ - "vite": "^6.4.0" + "vite": "^6.4.0"integrations/vue-vite/package.json (1)
13-15: Upgrade the Vue plugin to the Vite 6-compatible major.
@vitejs/plugin-vue@^5.2.4still targets Vite 5, so pairing it with Vite ^6.4.0 triggers peer-dep errors and blocks installs. Bump the plugin to the corresponding 6.x release (or keep Vite on 5.x) before shipping.Suggested fix:
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0", @@ - "vite": "^6.4.0", + "vite": "^6.4.0",examples/angular/infinite-query-with-max-pages/package.json (1)
22-26: Update TypeScript to meet Angular 20.3.x requirements.Angular 20.3.x (CLI/build/compiler) mandates TypeScript ≥ 5.9.0 < 6.0.0. Keeping the pin at 5.8.3 will break
ng build/ng serve. Please bump the devDependency accordingly.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/devtools-panel/package.json (1)
23-26: TypeScript 5.8.3 breaks Angular 20.3.x installs@angular/cli/build 20.3.x requires TypeScript ≥5.9.0 <6.0.0. The existing 5.8.3 pin will throw peer-install errors and block builds. Please raise it (e.g.
^5.9.0) and refresh the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/optimistic-updates/package.json (1)
23-26: Bump TypeScript into Angular’s supported rangeAngular 20.3.x peers against TypeScript ≥5.9.0 <6.0.0. Keeping 5.8.3 will fail installs. Please upgrade (e.g.
^5.9.0) and re-lock dependencies.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/pagination/package.json (1)
22-25: Update TypeScript to satisfy Angular 20.3.xCLI/build 20.3.x rejects TypeScript 5.8.3. Upgrade to a supported 5.9.x range and refresh the lockfile to avoid peer dependency failures.
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/basic-persister/package.json (1)
24-27: Angular 20.3.x needs TypeScript ≥5.9With @angular/* at 20.3.x, TypeScript 5.8.3 is unsupported and will fail installation. Please bump to at least 5.9.0 (e.g.
^5.9.0) and update the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/svelte/star-wars/package.json (1)
18-21: Tailwind 4 upgrade without migration will break the buildJumping from Tailwind 3.x to 4.x changes the config format, CLI entrypoint, and stylesheet bootstrap. This example still has the v3 setup, so
vite build/devwill fail once 4.1.14 is installed. Either revert to Tailwind 3.x (and matching @tailwindcss/vite) or include the full Tailwind 4 migration (new config files, CSS entry, etc.) in this PR.examples/angular/auto-refetching/package.json (1)
22-26: TypeScript 5.8.3 violates Angular 20.3.x peer range
@angular/cli/@angular/compiler-cli20.3.x declaretypescript: ">=5.9.0 <6.0.0". Keeping 5.8.3 causes peer-resolution failures with pnpm and falls outside the officially supported toolchain. Please bump the project’s TypeScript to a compliant version (e.g.,^5.9.0) and refresh the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"integrations/angular-cli-20/package.json (1)
23-27: Update TypeScript to satisfy Angular 20.3.x peersAngular 20.3.x packages require
typescript >=5.9.0 <6.0.0. The current~5.8.2pin is out of range and will trigger peer-dependency errors. Please bump TypeScript (and regenerate the lockfile) to a supported release such as^5.9.0.- "typescript": "~5.8.2" + "typescript": "^5.9.0"examples/vue/dependent-queries/package.json (1)
15-18: Fix Vite/plugin-vue peer mismatch
@vitejs/[email protected]peers onlyvite@^5, but this example now depends onvite@^6.4.0. Update the plugin to the Vite‑6 compatible major (e.g.^6.0.0) and refresh the lockfile to avoid install/build failures.- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (49)
- examples/svelte/auto-refetching/package.json
- examples/vue/2.6-basic/package.json
- examples/angular/basic/package.json
- examples/svelte/simple/package.json
- packages/solid-query-devtools/package.json
- packages/query-test-utils/package.json
- examples/react/chat/package.json
- examples/solid/basic/package.json
- examples/vue/nuxt3/package.json
- examples/solid/simple/package.json
- integrations/react-webpack-5/package.json
- packages/query-sync-storage-persister/package.json
- integrations/react-webpack-4/package.json
- examples/svelte/playground/package.json
- packages/query-async-storage-persister/package.json
- packages/svelte-query-devtools/package.json
- examples/solid/basic-graphql-request/package.json
- packages/angular-query-experimental/package.json
- packages/vue-query-devtools/package.json
- examples/solid/astro/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/vue-query/package.json
- examples/react/rick-morty/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/react-native/package.json
- examples/vue/persister/package.json
- examples/svelte/optimistic-updates/package.json
- examples/react/default-query-function/package.json
- examples/angular/router/package.json
- examples/react/suspense/package.json
- examples/react/eslint-legacy/package.json
- packages/solid-query-persist-client/package.json
- examples/react/offline/package.json
- examples/angular/simple/package.json
- examples/solid/default-query-function/package.json
- packages/angular-query-persist-client/package.json
- packages/react-query-next-experimental/package.json
- examples/svelte/ssr/package.json
- packages/solid-query/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/basic/package.json
- integrations/react-vite/package.json
- examples/angular/rxjs/package.json
- packages/react-query-persist-client/package.json
- packages/query-core/package.json
- examples/react/shadow-dom/package.json
- examples/react/react-router/package.json
- packages/react-query-devtools/package.json
- examples/react/basic-graphql-request/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/svelte-query/package.jsonintegrations/react-next-15/package.jsonintegrations/solid-vite/package.jsonpackages/query-persist-client-core/package.jsonpackages/react-query/package.jsonpackages/svelte-query-persist-client/package.json
| "@vitejs/plugin-vue": "^5.2.4", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" | ||
| } |
There was a problem hiding this comment.
Align plugin-vue with Vite 6
@vitejs/[email protected] only supports vite@^5. With Vite upgraded to ^6.4.0 this pairing fails peer resolution (pnpm will refuse to install). Please bump the plugin to the Vite‑6 compatible major, e.g. @vitejs/plugin-vue@^6.0.0, before regenerating the lockfile.
- "@vitejs/plugin-vue": "^5.2.4",
+ "@vitejs/plugin-vue": "^6.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-vue": "^5.2.4", | |
| "typescript": "5.8.3", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| } | |
| "@vitejs/plugin-vue": "^6.0.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
In examples/vue/basic/package.json around lines 16 to 19, @vitejs/plugin-vue is
pinned to a 5.x release which is incompatible with vite@^6.4.0; update the
dependency to a Vite‑6 compatible major (for example "@vitejs/plugin-vue":
"^6.0.0") in package.json and then regenerate the lockfile (run your package
manager install, e.g. pnpm install) so peer resolution succeeds.
53ca8f4 to
11e1706
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/react/basic/package.json (1)
16-26: Align @types/react with React 19.*Deps use react/react-dom 19, but devDeps are @types/react/dom 18.x. Root overrides force 19, but local manifests should match to avoid confusion and isolated installs breaking.
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.2",
♻️ Duplicate comments (10)
packages/vue-query-devtools/package.json (1)
56-61: Align @vitejs/plugin-vue with Vite 6 (peer mismatch will break builds)Vite is ^6.4.0 but @vitejs/plugin-vue remains ^5.x (targets Vite 5). Bump the plugin to 6.x (or revert Vite) to satisfy peers.
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",examples/vue/persister/package.json (1)
18-22: Align @vitejs/plugin-vue with Vite 6 (avoid peer conflict)Vite is ^6.4.0 but @vitejs/plugin-vue is ^5.2.4 (targets Vite 5). Upgrade plugin to 6.x (or keep Vite 5).
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",To find all files with Vite 6 + plugin-vue 5.x mismatches:
#!/bin/bash set -euo pipefail files=$(rg -Pl '"vite":\s*"\^?6\.' --glob '**/package.json') for f in $files; do vite=$(rg -nP '"vite":\s*"[^\"]+"' "$f" | head -n1 | sed -E 's/.*"vite":\s*"([^"]+)".*/\1/') plugin=$(rg -nP '"@vitejs/plugin-vue":\s*"[^\"]+"' "$f" | sed -E 's/.*"@vitejs\/plugin-vue":\s*"([^"]+)".*/\1/' || true) if [[ -n "${plugin:-}" && "$plugin" =~ ^\^?5\. ]]; then echo "$f -> vite=$vite, plugin-vue=$plugin" fi doneexamples/react/default-query-function/package.json (1)
17-19: @vitejs/plugin-react needs a Vite 6–compatible major.Current: plugin ^4.7.0 with vite ^6.4.0. Bump plugin to v5.
- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/chat/package.json (1)
17-21: @vitejs/plugin-react must be bumped for Vite 6.Use v5 to satisfy peer deps.
- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",package.json (1)
8-8: Ensure CI pins [email protected].packageManager bump alone doesn’t enforce CI version. Add a Corepack step or pnpm/action-setup to workflows.
Run this to confirm workflows pin pnpm:
#!/usr/bin/env bash fd -H -t f -g ".github/workflows/*.yml" | xargs rg -n -C2 -e 'corepack (enable|use)' -e 'uses:\s*pnpm/action-setup' -e 'pnpm@[0-9]+\.[0-9]+\.[0-9]+'examples/angular/basic/package.json (1)
22-26: Bump TypeScript to satisfy Angular 20.3 peer requirements@angular/cli/build 20.3.x requires TypeScript >=5.9.0 <6.0.0. Pinning 5.8.3 will cause peer-resolution/build failures. Update and re-lock.
"devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.5", - "typescript": "5.8.3" + "typescript": "^5.9.0" }#!/bin/bash # Find Angular example packages still pinning TS <5.9 rg -nP --glob 'examples/angular/**/package.json' '"typescript"\s*:\s*"5\.8\.3"' -C2examples/angular/query-options-from-a-service/package.json (1)
23-27: Align TypeScript with Angular 20.3.xTS 5.8.3 is out of range; use >=5.9 <6.0.0 to satisfy peers and avoid install/build issues.
"devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.5", - "typescript": "5.8.3" + "typescript": "^5.9.0" }examples/angular/optimistic-updates/package.json (1)
23-27: Update TypeScript to Angular 20.3-supported rangeKeep TS within >=5.9.0 <6.0.0; 5.8.3 will fail peer checks.
"devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.5", - "typescript": "5.8.3" + "typescript": "^5.9.0" }examples/angular/auto-refetching/package.json (1)
22-26: Bump TypeScript for Angular 20.3 compatibilityTS 5.8.3 is incompatible with the updated Angular toolchain; move to >=5.9 <6.0.0.
"devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.5", - "typescript": "5.8.3" + "typescript": "^5.9.0" }examples/angular/simple/package.json (1)
22-26: Fix TypeScript version to match Angular 20.3 peersUpgrade from 5.8.3 to >=5.9.0 <6.0.0 to satisfy CLI/build peer deps.
"devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.5", - "typescript": "5.8.3" + "typescript": "^5.9.0" }
🧹 Nitpick comments (1)
package.json (1)
1-11: Add engines to align Node across contributors and CI.Helps prevent Vite/ESLint/TypeScript/node mismatches.
Apply:
"repository": { "type": "git", "url": "https://github.com/TanStack/query.git" }, + "engines": { + "node": ">=18.18 <23" + },Also applies to: 42-82
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (47)
- examples/vue/dependent-queries/package.json
- examples/svelte/playground/package.json
- examples/vue/basic/package.json
- integrations/vue-vite/package.json
- packages/svelte-query/package.json
- examples/solid/default-query-function/package.json
- integrations/angular-cli-20/package.json
- examples/angular/router/package.json
- examples/react/rick-morty/package.json
- packages/react-query/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/svelte/star-wars/package.json
- examples/vue/simple/package.json
- packages/solid-query/package.json
- examples/solid/astro/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/basic/package.json
- examples/react/simple/package.json
- examples/svelte/optimistic-updates/package.json
- packages/query-core/package.json
- examples/solid/basic/package.json
- examples/angular/rxjs/package.json
- packages/query-devtools/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/svelte/simple/package.json
- examples/react/shadow-dom/package.json
- packages/solid-query-devtools/package.json
- examples/react/react-native/package.json
- integrations/react-next-15/package.json
- packages/svelte-query-devtools/package.json
- packages/react-query-next-experimental/package.json
- packages/solid-query-persist-client/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/vue/nuxt3/package.json
- examples/react/eslint-legacy/package.json
- examples/react/star-wars/package.json
- examples/react/playground/package.json
- examples/angular/basic-persister/package.json
- packages/eslint-plugin-query/package.json
- examples/vue/2.7-basic/package.json
- examples/svelte/ssr/package.json
- examples/solid/basic-graphql-request/package.json
- packages/query-persist-client-core/package.json
- examples/react/react-router/package.json
- examples/angular/pagination/package.json
- examples/angular/devtools-panel/package.json
- integrations/react-webpack-5/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-async-storage-persister/package.jsonintegrations/react-vite/package.jsonpackages/svelte-query-persist-client/package.jsonpackages/react-query-persist-client/package.jsonpackages/vue-query-devtools/package.jsonpackages/query-sync-storage-persister/package.jsonpackages/react-query-devtools/package.jsonpackages/angular-query-experimental/package.jsonpackages/angular-query-persist-client/package.jsonintegrations/solid-vite/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (17)
integrations/react-vite/package.json (1)
11-15: Check peer/engine compatibility: @vitejs/plugin-react + Vite 6Likely fine, but please confirm the plugin’s peer range includes Vite 6 and that Node >= 18 is used, as required by Vite 6.
examples/solid/simple/package.json (1)
13-20: Verify vite-plugin-solid compatibility with Vite 6Please confirm vite-plugin-solid ^2.11.9 explicitly supports Vite 6 to avoid peer warnings.
packages/query-async-storage-persister/package.json (1)
65-68: LGTMDevDep bump to npm-run-all2 ^5.0.2 is fine. Workspace deps include @tanstack/query-core as required. Based on learnings
examples/react/suspense/package.json (1)
18-22: LGTMBumps to @vitejs/plugin-react ^4.7.0 and vite ^6.4.0 look consistent with the broader updates.
integrations/solid-vite/package.json (1)
11-14: Confirm Solid toolchain supports Vite 6Please verify solid-js ^1.9.9 and vite-plugin-solid ^2.11.9 peer with Vite ^6.4.0 to avoid install/build issues.
examples/vue/2.6-basic/package.json (1)
10-15: LGTMPatch bump to @tanstack/vue-query ^5.90.3 is safe for this Vue 2.6 example.
examples/solid/solid-start-streaming/package.json (1)
14-18: LGTM on Solid/vinxi bumps.Non-breaking version updates; no config changes needed.
integrations/react-webpack-4/package.json (1)
14-17: LGTM on webpack 4/Babel tooling updates.Versions are compatible with webpack 4; webpack-cli v4 is appropriate.
packages/angular-query-persist-client/package.json (1)
60-71: LGTM on Angular devDependency bumps.Versions align with peer ranges and repo tooling.
integrations/svelte-vite/package.json (1)
12-13: Svelte/Vite bump looks good.Consistent with repo-wide upgrades.
packages/angular-query-experimental/package.json (1)
92-104: LGTM on Angular/tooling updates.DevDeps upgraded; dependencies/peers unchanged and compatible.
packages/vue-query/package.json (1)
64-77: LGTM on Vue deps/tooling bumps.No API surface changes; versions compatible.
packages/query-test-utils/package.json (1)
38-39: LGTM: npm-run-all2 bump.Routine tooling update.
packages/query-sync-storage-persister/package.json (1)
66-68: LGTM: npm-run-all2 bump.Consistent with repo-wide tooling updates.
packages/svelte-query-persist-client/package.json (1)
55-63: DevDependency bumps look goodUpdates align with Svelte 5 and tooling; no public surface change. LGTM.
packages/react-query-devtools/package.json (1)
86-89: Dev tooling bumps are appropriate@testing-library/react, @vitejs/plugin-react, and npm-run-all2 updates are compatible with React 19 dev setup here. LGTM.
packages/react-query-persist-client/package.json (1)
67-70: Dev tooling updates look safeTesting-library and Vite plugin updates align with React 19. No runtime/API impact. LGTM.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
Resolve Vite 6 peer range: upgrade @vitejs/plugin-react to v5.
Prevents pnpm peer-dep failures.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-react": "^4.7.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
In examples/react/algolia/package.json around lines 21 to 23, the
@vitejs/plugin-react version (^4.7.0) is incompatible with Vite 6 peer ranges;
update the @vitejs/plugin-react entry to a V5 compatible range (e.g., "^5.0.0"
or "^5") in package.json, then run your package manager (pnpm install) to
refresh lockfiles and verify the project builds to ensure peer-dep issues are
resolved.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
Align plugin with Vite 6.
Upgrade @vitejs/plugin-react to v5.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-react": "^4.7.0", | |
| "vite": "^6.4.0" | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
In examples/react/basic-graphql-request/package.json around lines 19 to 20, the
@vitejs/plugin-react version is incompatible with Vite 6; update the dependency
entry to use the v5 release (e.g. change "@vitejs/plugin-react": "^4.7.0" to
"@vitejs/plugin-react": "^5.0.0" or appropriate v5 range), then run package
manager install (npm/yarn/pnpm) and verify the project builds to ensure the
plugin and Vite versions are aligned.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
🧩 Analysis chain
Fix peer mismatch: use @vitejs/plugin-react v5 with Vite 6.
v4 doesn’t declare Vite 6 in peers; pnpm will error. Bump to v5.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",Run to find all offenders and verify vite/plugin alignment:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Files with vite@^6 and plugin-react <5:"
rg -nP '"vite"\s*:\s*"\^6\.[^"]*"' -C2 | sed -n 's#^\(.*package\.json\)-.*#\1#p' | sort -u | while read -r pkg; do
echo "— $pkg"
rg -n '"@vitejs/plugin-react"\s*:\s*"\^([^5][^"]*)"' "$pkg" || true
doneLength of output: 2209
Align @vitejs/plugin-react with Vite 6 peer dependency
Bump @vitejs/plugin-react from ^4.7.0 to ^5.0.0 in all React example package.json files to satisfy Vite 6 peerDependencies and prevent pnpm errors.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-react": "^4.7.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
examples/react/devtools-panel/package.json lines 17-19: the @vitejs/plugin-react
dependency is incompatible with Vite 6 peerDependencies; update the version
specifier from "^4.7.0" to "^5.0.0" in this file (and mirror the same bump in
all React example package.json files), then run your package manager (pnpm
install / pnpm install --lockfile-only) to refresh lockfiles and ensure
peerDependency errors are resolved.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
Bump @vitejs/plugin-react to v5 for Vite 6 compatibility.
Avoids peer-dependency install errors.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-react": "^4.7.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
In examples/react/offline/package.json around lines 22 to 24, the project pins
"@vitejs/plugin-react" to "^4.7.0" which is incompatible with Vite 6; update the
dependency to a Vite 6–compatible release (bump "@vitejs/plugin-react" to
"^5.0.0" or the latest v5), then run your package manager to update lockfile
(npm/yarn/pnpm) and verify the app builds to avoid peer-dependency install
errors.
11e1706 to
caec393
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (7)
examples/svelte/playground/package.json (1)
15-22: Keep Vite on 5.x until SvelteKit/plugin support Vite 6.
@sveltejs/[email protected]and@sveltejs/[email protected]peer Vite ^5, not ^6; installs will fail/warn.- "vite": "^6.4.0" + "vite": "^5.4.11" // or latest compatible 5.x#!/bin/bash npm view @sveltejs/[email protected] peerDependencies --json npm view @sveltejs/[email protected] peerDependencies --jsonexamples/angular/rxjs/package.json (1)
22-26: Fix TS peer mismatch with Angular 20.3.xAngular 20.3.x requires TypeScript ≥5.9 <6. Current 5.8.3 will cause peer install/build failures.
Apply:
- "typescript": "5.8.3" + "typescript": "^5.9.0"Optionally confirm via web:
What TypeScript versions are supported by Angular CLI/build 20.3.x?examples/angular/query-options-from-a-service/package.json (1)
23-26: Align TypeScript with Angular 20.3.x peer rangeBump TS to ≥5.9 <6.0 to satisfy @angular/* 20.3.x peers.
- "typescript": "5.8.3" + "typescript": "^5.9.0"If a previous commit updated this, it seems reverted here—please re-apply and refresh the lockfile.
examples/angular/pagination/package.json (1)
22-26: Update TypeScript to supported range for Angular 20.3.xTS 5.8.3 is unsupported; use ≥5.9 <6.0.
- "typescript": "5.8.3" + "typescript": "^5.9.0"integrations/angular-cli-20/package.json (1)
23-26: Pin TypeScript to a compatible 5.9.xThis integration targets Angular 20.3.x but keeps TS ~5.8.2. Please bump.
- "typescript": "~5.8.2" + "typescript": "~5.9.0"examples/react/react-native/package.json (1)
19-29: Expo SDK 52 is incompatible with React Native 0.82 — choose one pathExpo 52 targets RN 0.76.x (0.77 opt-in). Declaring RN ^0.82.0 (and matching libs) will break Metro/native builds.
Pick one:
- Upgrade Expo to the SDK that targets RN 0.82 and align all RN/Expo packages.
- Or revert RN and RN-* packages to versions supported by Expo 52 (RN 0.76/0.77), then run
expo doctor.You can confirm support matrix:
Which React Native versions are supported by Expo SDK 52?Also applies to: 32-33
package.json (1)
8-8: [email protected] must be pinned in CI.Already flagged by another review; agree. Ensure workflows run corepack use [email protected] or pnpm/action-setup with version to avoid lockfile mismatches.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/react/suspense/package.json
🚧 Files skipped from review as they are similar to previous changes (57)
- examples/react/chat/package.json
- packages/solid-query-persist-client/package.json
- packages/query-async-storage-persister/package.json
- integrations/vue-vite/package.json
- packages/solid-query-devtools/package.json
- examples/react/simple/package.json
- examples/angular/devtools-panel/package.json
- examples/react/algolia/package.json
- examples/solid/basic-graphql-request/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/query-persist-client-core/package.json
- examples/solid/simple/package.json
- packages/react-query-persist-client/package.json
- packages/query-test-utils/package.json
- examples/vue/persister/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/react-query-next-experimental/package.json
- examples/react/devtools-panel/package.json
- packages/query-broadcast-client-experimental/package.json
- integrations/react-webpack-5/package.json
- packages/vue-query-devtools/package.json
- examples/angular/auto-refetching/package.json
- examples/svelte/ssr/package.json
- packages/solid-query/package.json
- examples/react/basic/package.json
- packages/eslint-plugin-query/package.json
- examples/solid/default-query-function/package.json
- examples/angular/basic/package.json
- examples/solid/solid-start-streaming/package.json
- examples/solid/astro/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/offline/package.json
- examples/react/eslint-legacy/package.json
- packages/query-devtools/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/basic-persister/package.json
- examples/react/react-router/package.json
- examples/svelte/simple/package.json
- examples/svelte/star-wars/package.json
- packages/angular-query-experimental/package.json
- integrations/react-vite/package.json
- packages/vue-query/package.json
- integrations/react-webpack-4/package.json
- examples/react/basic-graphql-request/package.json
- examples/vue/dependent-queries/package.json
- examples/angular/simple/package.json
- examples/angular/optimistic-updates/package.json
- examples/angular/router/package.json
- examples/react/shadow-dom/package.json
- packages/svelte-query/package.json
- packages/react-query-devtools/package.json
- examples/vue/basic/package.json
- integrations/solid-vite/package.json
- examples/svelte/optimistic-updates/package.json
- packages/svelte-query-devtools/package.json
- examples/vue/simple/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.jsonpackages/angular-query-persist-client/package.jsonpackages/react-query/package.jsonintegrations/react-next-15/package.json
🔇 Additional comments (14)
packages/query-core/package.json (1)
63-64: LGTM: devDependency bump only.
No runtime/API impact.integrations/react-next-15/package.json (1)
9-10: LGTM: safe polyfill bump.
No API/runtime impact.examples/solid/basic/package.json (1)
13-19: No changes required: [email protected] peerDependencies include Vite ^6.0.0.examples/react/star-wars/package.json (1)
19-24: [email protected] supports Vite ^6; no upgrade to v5 required.Likely an incorrect or invalid review comment.
packages/react-query/package.json (1)
73-79: Remove unnecessary@vitejs/plugin-reactbump
@vitejs/[email protected]already listsvite: "^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0"as a peerDependency, so upgrading to v5 isn’t required.Likely an incorrect or invalid review comment.
examples/react/default-query-function/package.json (1)
17-20: No upgrade needed: @vitejs/plugin-react@^4.7.0 already supports Vite 6
The peerDependencies for v4.7.0 include"vite": "^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0", so no bump to v5 is required.Likely an incorrect or invalid review comment.
examples/react/playground/package.json (1)
17-20: Drop upgrade suggestion for@vitejs/plugin-react: v4.7.0’s peer dependency already covers Vite ^6.0.0, so no bump to v5 is required.Likely an incorrect or invalid review comment.
examples/react/rick-morty/package.json (1)
15-24: React router + Vite/Tailwind bumps look goodNo breaking config changes expected here.
packages/angular-query-persist-client/package.json (1)
60-71: Dev deps bumps OKAngular and testing/lint tools updates look consistent; peer range remains broad. No issues.
integrations/svelte-vite/package.json (1)
12-13: Svelte + Vite bumps look safeNo config changes implied. LGTM.
examples/vue/2.7-basic/package.json (1)
11-11: LGTM — safe patch bump of @tanstack/vue-query.No compatibility concerns with Vue 2.7 here.
examples/vue/2.6-basic/package.json (1)
11-11: LGTM — patch bump to @tanstack/vue-query.No breaking changes expected for Vue 2.6 example.
examples/svelte/basic/package.json (1)
17-24: Compatibility confirmed: SvelteKit v2.47.0 supports Vite 6.x; ensure CI uses Node.js ≥18
- SvelteKit v2.47.0 peer deps include Vite ^6.0.0, so Vite 6.4.x is supported.
- Vite 6 requires Node.js ≥18; update your CI config if needed.
package.json (1)
42-81: Pin Node version in CI workflows
Noactions/setup-nodeornode-versionfound in.github/workflows; ensure your CI is configured to use Node ≥18 (required by Vite 6 and Nuxt 3.x).
examples/vue/nuxt3/package.json
Outdated
| "@tanstack/vue-query": "^5.90.4" | ||
| }, | ||
| "devDependencies": { | ||
| "nuxt": "^3.12.4" | ||
| "nuxt": "^3.19.3" | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
Confirm Nuxt 3.19 Node requirement in CI/local.
Nuxt 3.19 may raise minimum Node. Ensure workflows and dev environments meet it.
🌐 Web query:
What is the minimum Node.js version required by Nuxt 3.19?
💡 Result:
Nuxt 3.19 requires at least Node.js 16.10.0. [1][2]
Sources:
- Nuxt discussion on minimum Node.js versions (lists ^16.10.0). [1]
- Nuxt issue showing engines constraints including ^16.10.0. [2]
Ensure Node.js >=16.10.0 in CI and local setup
Nuxt 3.19 requires Node.js 16.10.0 or above—update your workflows (e.g., GitHub Actions node-version) and any .nvmrc or local configs accordingly.
🤖 Prompt for AI Agents
In examples/vue/nuxt3/package.json around lines 10 to 14, the project declares
Nuxt 3.19 which requires Node.js >=16.10.0; update CI and local Node configs to
enforce this. Modify your GitHub Actions workflows to set node-version to
"16.10" or higher, update any .nvmrc, .node-version, or README dev setup
instructions to "16.10.0" or newer, and ensure local dev scripts or engine
fields (if used) reflect the minimum Node version so CI and contributors run the
correct Node runtime.
caec393 to
15926e4
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (11)
packages/vue-query-devtools/package.json (1)
56-60: Align @vitejs/plugin-vue with Vite 6 (peer-dep conflict).plugin-vue 5.x peers Vite ^5; this package uses Vite ^6.4.0 → installs/builds will fail under pnpm. Bump plugin to 6.x or keep Vite on 5.x.
Apply one of:
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",or
- "vite": "^6.4.0", + "vite": "^5.4.11",Repo-wide quick check for Vite/plugin peer ranges:
#!/bin/bash set -euo pipefail echo "Scanning package.json files for Vite and related plugins..." fd -a package.json | while read -r f; do vite_ver=$(jq -r '.devDependencies.vite // .dependencies.vite // empty' "$f") vue_plug=$(jq -r '(.devDependencies["@vitejs/plugin-vue"] // .dependencies["@vitejs/plugin-vue"] // empty)' "$f") react_plug=$(jq -r '(.devDependencies["@vitejs/plugin-react"] // .dependencies["@vitejs/plugin-react"] // empty)' "$f") svelte_plug=$(jq -r '(.devDependencies["@sveltejs/vite-plugin-svelte"] // .dependencies["@sveltejs/vite-plugin-svelte"] // empty)' "$f") kit_ver=$(jq -r '(.devDependencies["@sveltejs/kit"] // .dependencies["@sveltejs/kit"] // empty)' "$f") solid_plug=$(jq -r '(.devDependencies["vite-plugin-solid"] // .dependencies["vite-plugin-solid"] // empty)' "$f") [[ -z "$vite_ver$vue_plug$react_plug$svelte_plug$solid_plug$kit_ver" ]] && continue echo "---- $f" echo "vite: ${vite_ver:-<absent>}" fetch_peer() { local name="$1" ver="$2" [[ -z "$ver" ]] && return local enc=${name//@/%40}; enc=${enc//\//%2F} curl -s "https://registry.npmjs.org/${enc}/${ver#^}" | jq -r '.peerDependencies.vite // empty' } if [[ -n "$vue_plug" ]]; then peer=$(fetch_peer "@vitejs/plugin-vue" "$vue_plug"); echo "@vitejs/plugin-vue: $vue_plug (peer vite: ${peer:-<none>})" fi if [[ -n "$react_plug" ]]; then peer=$(fetch_peer "@vitejs/plugin-react" "$react_plug"); echo "@vitejs/plugin-react: $react_plug (peer vite: ${peer:-<none>})" fi if [[ -n "$svelte_plug" ]]; then peer=$(fetch_peer "@sveltejs/vite-plugin-svelte" "$svelte_plug"); echo "@sveltejs/vite-plugin-svelte: $svelte_plug (peer vite: ${peer:-<none>})" fi if [[ -n "$kit_ver" ]]; then # SvelteKit also peers Vite peer=$(fetch_peer "@sveltejs/kit" "$kit_ver"); echo "@sveltejs/kit: $kit_ver (peer vite: ${peer:-<none>})" fi if [[ -n "$solid_plug" ]]; then peer=$(fetch_peer "vite-plugin-solid" "$solid_plug"); echo "vite-plugin-solid: $solid_plug (peer vite: ${peer:-<none>})" fi doneexamples/svelte/playground/package.json (1)
15-22: Vite 6 is not supported by SvelteKit/vite-plugin-svelte at these versions.@ sveltejs/kit 2.47.0 and @sveltejs/vite-plugin-svelte 5.1.1 peer Vite ^5, not ^6. Using Vite ^6.4.0 breaks peer requirements.
- "vite": "^6.4.0" + "vite": "^5.4.11"If a newer Kit/plugin release supports Vite 6, bump those instead and keep Vite 6. Please verify peers before merging.
examples/vue/simple/package.json (1)
16-19: Fix Vite 6 and @vitejs/plugin-vue 5.x peer conflict.plugin-vue 5.x peers Vite ^5; this example uses Vite ^6.4.0. Update plugin to 6.x or keep Vite on 5.x.
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",or
- "vite": "^6.4.0" + "vite": "^5.4.11"examples/react/default-query-function/package.json (1)
17-19: Bump @vitejs/plugin-react to a Vite 6-compatible major (or keep Vite 5).4.x doesn’t peer Vite 6; with Vite ^6.4.0 this will fail under pnpm.
- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",Or downgrade Vite to latest 5.x.
examples/angular/optimistic-updates/package.json (1)
12-26: Update TypeScript to Angular 20.3’s supported rangeAngular 20.3.x (CLI/build/compiler-cli) peers on
typescript >=5.9.0 <6.0.0. Keeping the pin at 5.8.3 violates that requirement and will break installs/builds. Please bump the devDependency to a compatible range (e.g.^5.9.0) and refresh the lockfile.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/devtools-panel/package.json (1)
23-26: TypeScript pin violates Angular 20.3 peer rangeAngular 20.3.x toolchain (build/cli/compiler-cli) requires TypeScript ≥5.9.0 <6.0.0, but Line 26 still pins 5.8.3. Installs will error under pnpm/npm and builds are unsupported. Please bump
typescriptto a compliant range (e.g.^5.9.0) and regenerate the lockfile.examples/angular/pagination/package.json (1)
22-25: Upgrade TypeScript to Angular 20.3-supported rangeTypeScript 5.8.3 (Line 25) falls outside the ≥5.9.0 <6.0.0 requirement enforced by @angular/cli 20.3.x. This causes peer dependency failures and unsupported builds. Please bump to a 5.9.x release (e.g.
^5.9.0) and refresh the lockfile.examples/angular/query-options-from-a-service/package.json (1)
23-26: TypeScript 5.8.3 is unsupported with Angular 20.3 toolingWith @angular/cli/build/compiler-cli 20.3.x, TypeScript must be ≥5.9.0 <6.0.0. Keeping 5.8.3 (Line 26) breaks installs/builds. Please raise this devDependency to a compatible 5.9.x version and update the lockfile accordingly.
examples/angular/router/package.json (1)
23-26: Update TypeScript to satisfy Angular 20.3 peer requirementLine 26 still pins TypeScript 5.8.3, but Angular 20.3.x CLI/build/compiler-cli mandate ≥5.9.0 <6.0.0. Leaving it as 5.8.3 causes peer dependency failures and unsupported builds. Please bump to a compliant 5.9.x range and refresh the lockfile.
examples/react/react-native/package.json (1)
19-34: React Native stack incompatible with Expo SDK 52Expo 52 ships with React Native 0.76.x (0.77 optional). Declaring
react-native^0.82.0 (Line 23) and matching gesture-handler/reanimated/screens/safe-area/web versions breaks Metro/native builds in the managed workflow. Either upgrade Expo (and associated Expo packages) to the SDK that targets RN 0.82, or revert the RN dependencies to the SDK 52-aligned versions (RN 0.76/0.77 plus compatible library versions) and verify withexpo doctor.examples/react/offline/package.json (1)
22-25: Align@vitejs/plugin-reactwith Vite 6Vite jumped to 6.4.0 (Line 24) but
@vitejs/plugin-reactremains on the v4 line (Line 22), whose peer range excludes Vite 6. This mismatch triggers peer install errors and broken dev/build. Please bump the plugin to the v5 series compatible with Vite 6.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (55)
- examples/vue/2.7-basic/package.json
- integrations/react-webpack-5/package.json
- packages/query-core/package.json
- examples/vue/nuxt3/package.json
- examples/react/suspense/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/angular/rxjs/package.json
- packages/react-query-next-experimental/package.json
- examples/vue/basic/package.json
- examples/solid/simple/package.json
- examples/solid/basic/package.json
- integrations/vue-vite/package.json
- examples/angular/simple/package.json
- packages/svelte-query-devtools/package.json
- integrations/angular-cli-20/package.json
- packages/query-devtools/package.json
- integrations/react-next-15/package.json
- examples/react/simple/package.json
- examples/svelte/auto-refetching/package.json
- packages/vue-query/package.json
- examples/react/devtools-panel/package.json
- packages/svelte-query/package.json
- packages/angular-query-persist-client/package.json
- packages/query-async-storage-persister/package.json
- examples/react/shadow-dom/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/algolia/package.json
- packages/svelte-query-persist-client/package.json
- examples/svelte/star-wars/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/star-wars/package.json
- examples/react/react-router/package.json
- examples/solid/default-query-function/package.json
- examples/solid/astro/package.json
- packages/query-persist-client-core/package.json
- packages/solid-query-devtools/package.json
- examples/vue/2.6-basic/package.json
- examples/svelte/simple/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/chat/package.json
- examples/angular/basic-persister/package.json
- examples/solid/solid-start-streaming/package.json
- packages/react-query-persist-client/package.json
- examples/angular/basic/package.json
- examples/angular/auto-refetching/package.json
- integrations/svelte-vite/package.json
- packages/angular-query-experimental/package.json
- packages/query-test-utils/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/vue/persister/package.json
- examples/react/rick-morty/package.json
- examples/vue/dependent-queries/package.json
- examples/svelte/basic/package.json
- examples/react/basic/package.json
- packages/eslint-plugin-query/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/vue-query-devtools/package.jsonpackages/react-query/package.jsonpackages/react-query-devtools/package.jsonintegrations/solid-vite/package.jsonintegrations/react-vite/package.jsonpackages/solid-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (2)
packages/solid-query/package.json (1)
74-78: LGTM on Solid tooling bumps.Versions look consistent; no peer conflicts apparent.
integrations/solid-vite/package.json (1)
11-14: Confirmed [email protected] supports Vite 6 – peerDependencies include^6.0.0.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
Bump @vitejs/plugin-react for Vite 6 compatibility
This example also moved to Vite 6.4.0 (Line 25) but keeps @vitejs/plugin-react on the v4 line (Line 23). Plugin v4 doesn’t advertise support for Vite 6, leading to peer dependency/install issues. Please upgrade the plugin to v5.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-react": "^4.7.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
In examples/react/eslint-legacy/package.json around lines 23 to 25, the project
uses "@vitejs/plugin-react" v4 while Vite has been bumped to 6.4.0; update the
plugin to the v5 line that supports Vite 6 (for example change the plugin
dependency to a v5 range such as "^5.0.0" or the current v5.x release) so the
peer dependency matches Vite 6 and avoids install issues.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" | ||
| } |
There was a problem hiding this comment.
Update @vitejs/plugin-react to a Vite 6-compatible major (or keep Vite 5).
plugin-react 4.x doesn’t list Vite 6 in peers; installs will fail/warn with Vite ^6.4.0. Bump plugin to 5.x (first Vite 6-compatible) or keep Vite on 5.x.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",Alternatively:
- "vite": "^6.4.0"
+ "vite": "^5.4.11"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-react": "^4.7.0", | |
| "react": "^19.0.0", | |
| "react-dom": "^19.0.0", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| } | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "react": "^19.0.0", | |
| "react-dom": "^19.0.0", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
integrations/react-vite/package.json lines 11-15: the dependency set pins
"@vitejs/plugin-react" at 4.x which is not compatible with Vite 6; update
package.json to either bump "@vitejs/plugin-react" to a Vite-6-compatible major
(e.g., "^5.0.0") or downgrade "vite" to a Vite 5 release (e.g., "^5.x") to align
peer versions, then run install and verify the dev server builds without peer
warnings.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (6)
examples/vue/dependent-queries/package.json (1)
15-17: Blocker: plugin-vue@5 breaks with Vite 6
@vitejs/[email protected]still peers onvite@^5. Bumpingviteto^6.4.0leaves an unsatisfied peer, so strict package managers (pnpm) refuse to install and even npm/yarn downgrade or warn. Please upgrade the plugin to the Vite‑6-compatible major (currently@vitejs/plugin-vue@^6) or hold Vite at the latest ^5 release.- "@vitejs/plugin-vue": "^5.2.4", - "vite": "^6.4.0" + "@vitejs/plugin-vue": "^6.0.0", + "vite": "^6.4.0"examples/svelte/star-wars/package.json (1)
18-21: Tailwind 4 upgrade breaks current setupJumping
@tailwindcss/viteandtailwindcssto 4.1.14 without the required Tailwind 4 migration (new configless setup, updated entrypoints, CSS changes) will make this Svelte example fail to build. Please either stay on Tailwind 3 for now or include the full Tailwind 4 migration in this PR.examples/angular/devtools-panel/package.json (1)
23-27: Bump TypeScript to Angular 20.3’s supported rangeAngular CLI/compiler-cli 20.3.x declare a peer dependency on TypeScript ≥5.9.0 <6.0.0. Leaving it pinned at 5.8.3 will trigger peer conflicts—and in stricter setups, installs/builds will fail. Please bump TypeScript to at least 5.9 and update the lockfile accordingly.
- "typescript": "5.8.3" + "typescript": "^5.9.0"After adjusting
package.json, rerun the package manager so the lockfile captures the new resolution.examples/react/offline/package.json (1)
22-24: Update @vitejs/plugin-react for Vite 6 compatibility
@vitejs/[email protected]pegs itspeerDependenciesto Vite^4 || ^5, so keeping it while bumpingviteto^6.4.0will throw peer-dependency install errors and block builds. Please upgrade the plugin to the v5 line.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/react-router/package.json (1)
26-28:@vitejs/[email protected]is incompatible with Vite 6.This mirrors the earlier review note: plugin-react 4.x only peers with Vite ^4 || ^5, so keeping it while bumping Vite to ^6.4.0 breaks installs. Please move to the first 5.x build that lists Vite 6 support (e.g.
^5.0.0) before merging.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/basic/package.json (1)
23-25: Upgrade the React plugin to match Vite 6.Keeping
@vitejs/plugin-react@^4.7.0while runningvite@^6.4.0violates the plugin’s peer range (^4 || ^5) and causes pnpm installs to fail. Please bump the plugin to the first 5.x release that supports Vite 6 (e.g.^5.0.0).- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/query-async-storage-persister/package.json
- integrations/svelte-vite/package.json
🚧 Files skipped from review as they are similar to previous changes (53)
- examples/react/star-wars/package.json
- examples/solid/basic/package.json
- packages/solid-query-devtools/package.json
- examples/react/default-query-function/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/svelte-query-persist-client/package.json
- packages/vue-query-devtools/package.json
- examples/vue/2.6-basic/package.json
- integrations/solid-vite/package.json
- examples/react/devtools-panel/package.json
- integrations/react-next-15/package.json
- examples/react/algolia/package.json
- packages/query-test-utils/package.json
- packages/eslint-plugin-query/package.json
- packages/solid-query-persist-client/package.json
- examples/react/shadow-dom/package.json
- examples/vue/basic/package.json
- examples/svelte/auto-refetching/package.json
- examples/react/eslint-legacy/package.json
- integrations/angular-cli-20/package.json
- examples/react/react-native/package.json
- examples/angular/simple/package.json
- examples/vue/persister/package.json
- packages/solid-query/package.json
- packages/query-core/package.json
- examples/angular/basic/package.json
- examples/solid/solid-start-streaming/package.json
- examples/angular/basic-persister/package.json
- examples/angular/pagination/package.json
- examples/react/basic-graphql-request/package.json
- examples/svelte/playground/package.json
- packages/react-query-persist-client/package.json
- examples/react/simple/package.json
- examples/angular/rxjs/package.json
- examples/react/chat/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/optimistic-updates/package.json
- examples/angular/auto-refetching/package.json
- examples/solid/basic-graphql-request/package.json
- packages/react-query/package.json
- packages/query-persist-client-core/package.json
- examples/react/suspense/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/router/package.json
- packages/query-devtools/package.json
- integrations/react-webpack-5/package.json
- package.json
- examples/vue/2.7-basic/package.json
- examples/react/playground/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/vue/simple/package.json
- integrations/vue-vite/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/angular-query-experimental/package.jsonpackages/angular-query-persist-client/package.jsonintegrations/react-vite/package.jsonpackages/react-query-devtools/package.jsonpackages/svelte-query-devtools/package.jsonpackages/svelte-query/package.jsonpackages/query-broadcast-client-experimental/package.json
🔇 Additional comments (3)
packages/svelte-query-devtools/package.json (1)
50-60: Dependency bumps look goodAll the tooling bumps stay within the existing peer ranges, and nothing here risks breaking downstream consumers. 👍
packages/react-query-devtools/package.json (1)
85-90: Dev tooling bumps look consistent.These version bumps match the workspace-wide Renovate sweep and keep parity with the rest of the packages. No issues spotted.
examples/vue/nuxt3/package.json (1)
13-13: Verify Node engine compatibility for Nuxt 3.19.3.The
nuxtpackage now targets 3.19.3, which raises the minimum supported Node.js version (Nuxt’sengines.nodefield tightened in recent 3.1x releases). Make sure every workflow and local config (.nvmrc,.node-version, CIsetup-node, docs, etc.) is updated to meet or exceed that requirement; otherwise builds/tests will fail once this lands.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "react": "^19.0.0", | ||
| "react-dom": "^19.0.0", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
Bump @vitejs/plugin-react to the Vite 6-compatible release.
@vitejs/plugin-react@^4.7.0 still declares a peer of vite@^4 || ^5, so pairing it with vite@^6.4.0 will hard-stop installs under pnpm’s strict peer check. Please upgrade the plugin to the first 5.x release that advertises Vite 6 support (e.g. ^5.0.0).
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-react": "^4.7.0", | |
| "react": "^19.0.0", | |
| "react-dom": "^19.0.0", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "react": "^19.0.0", | |
| "react-dom": "^19.0.0", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
integrations/react-vite/package.json lines 11-14: the @vitejs/plugin-react
dependency (^4.7.0) declares a peer of vite@^4 || ^5 and thus is incompatible
with vite@^6.4.0 causing pnpm peer-check failures; update @vitejs/plugin-react
to the first Vite‑6 compatible major (e.g. change to ^5.0.0 or the specific 5.x
release that advertises Vite 6 support) in package.json, then reinstall and
update the lockfile (pnpm install) to ensure peers resolve correctly.
15926e4 to
63bfa47
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (10)
examples/react/eslint-legacy/package.json (1)
23-25: Upgrade@vitejs/plugin-reactto the Vite 6-compatible major.Vite jumped to ^6.4.0 while the plugin stayed on the v4 line, whose peer dependency caps at Vite ^5. Package managers will warn or fail to install; dev/build commands break. Please bump the plugin to the v5 range (e.g.
^5.0.0or the current v5.x) to satisfy the peer requirement.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/svelte/playground/package.json (1)
15-22: Revert Vite to a 5.x range for SvelteKit compatibility.
@sveltejs/[email protected]and@sveltejs/[email protected]both declare"vite": "^5.0.0"as a peer dependency. Bumping this example tovite": "^6.4.0"violates that range, so pnpm will refuse to install (npm/yarn warn) and the example cannot run. Keep Vite on a compatible 5.x release until upstream ships Vite 6 support.- "vite": "^6.4.0" + "vite": "^5.4.11" // latest Vite 5.x compatible with Kit 2.47examples/react/react-router/package.json (1)
26-28: Upgrade@vitejs/plugin-reactfor Vite 6 compatibility.
@vitejs/plugin-react@^4.7.0does not declare support for Vite ^6.4.0, so installs/builds fail under pnpm’s peer checks. Please bump to the first major that supports Vite 6 (v5+).- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/basic-graphql-request/package.json (1)
19-20: Bump@vitejs/plugin-reactto the Vite 6-compatible major.
@vitejs/plugin-react@^4.7.0only peers with Vite ^4 || ^5, so pnpm/yarn/npm will error once it sees Vite ^6.4.0. Upgrade the plugin to the first release that advertises Vite 6 support (v5+).- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/angular/pagination/package.json (1)
22-26: Align TypeScript with Angular 20.3.x requirements.Angular 20.3.x (CLI/build 20.3.6) requires TypeScript ≥5.9.0 <6.0.0, but this example still pins 5.8.3. Installs/builds will fail until TypeScript is bumped into the supported range.
- "typescript": "5.8.3" + "typescript": "^5.9.0"package.json (1)
8-8: Pin pnpm 10.18.3 in CI (Corepack or setup action).packageManager alone doesn’t enforce CI version. Add either:
corepack enable && corepack use [email protected], oruses: pnpm/action-setup@v2withversion: "10.18.3".examples/angular/simple/package.json (1)
25-25: Angular 20.3.x requires TypeScript ≥5.9 <6.0 — bump TS.5.8.3 will trigger peer conflicts/build issues. Update to 5.9.x.
- "typescript": "5.8.3" + "typescript": "^5.9.0"integrations/angular-cli-20/package.json (1)
26-26: Bump TypeScript to Angular 20.3.x supported range.~5.8.2 is incompatible; use 5.9.x.
- "typescript": "~5.8.2" + "typescript": "~5.9.0"examples/react/react-native/package.json (1)
19-29: Expo SDK 52 is incompatible with React Native 0.82 — align the stack.Upgrade Expo (and all Expo/RN deps) to the SDK targeting RN 0.82, or revert RN and companion libs to SDK‑52 compatible versions. Run
expo doctorafter changes.packages/vue-query-devtools/package.json (1)
57-61: Align @vitejs/plugin-vue with Vite 6.Plugin v5 targets Vite 5; with Vite ^6.4.0, use plugin v6.
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (55)
- integrations/react-next-15/package.json
- packages/query-sync-storage-persister/package.json
- packages/react-query/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/algolia/package.json
- examples/vue/2.6-basic/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/offline/package.json
- examples/svelte/optimistic-updates/package.json
- examples/vue/persister/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/auto-refetching/package.json
- integrations/react-vite/package.json
- examples/vue/dependent-queries/package.json
- packages/solid-query-devtools/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/vue/2.7-basic/package.json
- integrations/solid-vite/package.json
- examples/react/basic/package.json
- integrations/vue-vite/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/suspense/package.json
- examples/svelte/basic/package.json
- packages/query-core/package.json
- examples/react/star-wars/package.json
- examples/vue/basic/package.json
- packages/react-query-devtools/package.json
- examples/angular/basic/package.json
- packages/query-devtools/package.json
- packages/react-query-next-experimental/package.json
- packages/query-test-utils/package.json
- integrations/react-webpack-4/package.json
- integrations/svelte-vite/package.json
- packages/svelte-query/package.json
- examples/react/simple/package.json
- packages/svelte-query-persist-client/package.json
- examples/angular/auto-refetching/package.json
- integrations/react-webpack-5/package.json
- examples/svelte/ssr/package.json
- examples/svelte/simple/package.json
- packages/react-query-persist-client/package.json
- examples/react/playground/package.json
- examples/solid/basic/package.json
- examples/svelte/star-wars/package.json
- examples/angular/rxjs/package.json
- examples/angular/router/package.json
- examples/react/default-query-function/package.json
- examples/react/devtools-panel/package.json
- examples/solid/simple/package.json
- examples/angular/basic-persister/package.json
- examples/angular/devtools-panel/package.json
- examples/vue/simple/package.json
- examples/react/shadow-dom/package.json
- examples/react/chat/package.json
- examples/angular/optimistic-updates/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/solid-query-persist-client/package.jsonpackages/query-persist-client-core/package.jsonpackages/angular-query-persist-client/package.jsonpackages/angular-query-experimental/package.jsonpackages/svelte-query-devtools/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/vue-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Preview
🔇 Additional comments (3)
packages/angular-query-experimental/package.json (1)
92-95: Angular devDep bumps look good.Versions align across Angular 20.3.x and tooling.
Also applies to: 97-103
packages/eslint-plugin-query/package.json (1)
62-70: LGTM on @typescript-eslint/eslint updates.Versions are mutually compatible with eslint ^9.
packages/vue-query/package.json (1)
66-66: Vue tooling bumps look good.No API changes; safe minor updates.
Also applies to: 73-73
| "@tailwindcss/vite": "^4.1.14", | ||
| "@vitejs/plugin-react": "^4.7.0", | ||
| "tailwindcss": "^4.1.14", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" | ||
| } |
There was a problem hiding this comment.
Upgrade @vitejs/plugin-react for Vite 6 compatibility.
Vite is pinned to ^6.4.0, but @vitejs/plugin-react@^4.7.0 only declares Vite ^4 || ^5 in its peer range, causing installs/builds to fail. Please bump to the first Vite 6-compatible major.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@tailwindcss/vite": "^4.1.14", | |
| "@vitejs/plugin-react": "^4.7.0", | |
| "tailwindcss": "^4.1.14", | |
| "typescript": "5.8.3", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| } | |
| "@tailwindcss/vite": "^4.1.14", | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "tailwindcss": "^4.1.14", | |
| "typescript": "5.8.3", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
In examples/react/rick-morty/package.json around lines 19 to 24,
@vitejs/plugin-react is pinned to ^4.7.0 which only supports Vite ^4||^5; update
that dependency to the first major that supports Vite 6 (bump to ^5.0.0 or the
exact first Vite‑6 compatible release), update package-lock/yarn.lock by
reinstalling (npm/yarn install), and verify the dev/build scripts run
successfully with Vite ^6.4.0.
63bfa47 to
65a7c20
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (10)
examples/svelte/playground/package.json (1)
15-22:⚠️ Duplicate: Vite 6 peer dependency conflict with SvelteKit/plugin-svelte — do not merge.This maintains the critical peer-dependency violation previously flagged.
@sveltejs/[email protected]and@sveltejs/[email protected]both declare"vite": "^5.0.0"in peerDependencies. Upgrading vite to^6.4.0will cause pnpm install to fail and npm/yarn to emit loud warnings, blocking this example from running.Action: Either keep vite on the latest 5.x line (e.g.,
"vite": "^5.4.11") or wait for official Vite 6 support from SvelteKit/plugin-svelte before upgrading.Apply this diff to restore compatibility:
- "vite": "^6.4.0" + "vite": "^5.4.11"examples/vue/simple/package.json (1)
16-18:⚠️ Duplicate: Vite 6 peer dependency conflict with @vitejs/plugin-vue — do not merge.This maintains the critical peer-dependency violation previously flagged.
@vitejs/[email protected]declares"vite": "^5"in peerDependencies. Bumping vite to^6.4.0violates this constraint; pnpm will refuse the install and npm/yarn will emit warnings, preventing this example from working.Action: Either keep vite on 5.x (e.g.,
"vite": "^5.4.11") or upgrade the plugin to a 6.x-compatible release once available.Apply this diff to restore compatibility:
- "vite": "^6.4.0" + "vite": "^5.4.11"examples/react/rick-morty/package.json (1)
19-23: @vitejs/plugin-react 4.x incompatible with Vite 6 (previously flagged).Same incompatibility as past review:
@vitejs/plugin-react@^4.7.0peer-depends onvite@^4 || ^5, but line 23 pinsvite@^6.4.0. Upgrade the plugin to Vite 6-compatible version.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/angular/basic/package.json (1)
22-25: TypeScript 5.8.3 incompatible with Angular 20.3.6 (previously flagged).Angular CLI 20.3.x requires TypeScript
>=5.9.0 <6.0.0. Current pin of5.8.3fails peer resolution and build. Upgrade TypeScript.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/router/package.json (1)
23-26: TypeScript 5.8.3 incompatible with Angular 20.3.6 (previously flagged).Angular CLI 20.3.x requires TypeScript
>=5.9.0 <6.0.0. Current pin of5.8.3fails peer resolution and build. Upgrade TypeScript.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/react/react-native/package.json (1)
19-29: React Native 0.82.0 incompatible with Expo SDK 52 (previously flagged as addressed, but versions unchanged).Expo SDK 52 bundles React Native 0.76.x (RN 0.77 opt-in), not 0.82.0. Declaring
react-native@^0.82.0and matching RN-* libraries will break Metro bundling and native builds. Either upgrade Expo and allexpo/*packages to an SDK targeting RN 0.82, or revert the RN stack to SDK 52-aligned versions (RN 0.76/0.77 + compatiblereact-native-{gesture-handler,reanimated,safe-area-context,screens,web}). After changes, runexpo doctorto confirm alignment.Please verify whether commit 63bfa47 addressed this through a different mechanism (e.g., configuration or conditional logic) rather than version alignment, and clarify the resolution path for this incompatibility.
package.json (1)
8-8: Enforce [email protected] in CI workflows (previously flagged).
packageManagerupdate to[email protected]alone doesn't guarantee CI uses the pinned version. Workflows must explicitly enable and pin pnpm viacorepack enable && corepack use [email protected]or thepnpm/action-setup@v2action to prevent lockfile version mismatches.Please verify that
.github/workflows/*.ymlincludes pnpm version pinning (either via Corepack or pnpm/action-setup).Also applies to: 8-8
packages/vue-query-devtools/package.json (1)
57-57: @vitejs/plugin-vue 5.x incompatible with Vite 6 (previously flagged).
@vitejs/plugin-vue@^5.2.4declares peer dependencyvite@^5, but line 60 pinsvite@^6.4.0. This peer conflict will break the build. Upgrade the plugin to Vite 6-compatible version.- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",Also applies to: 60-60
integrations/vue-vite/package.json (1)
13-16:⚠️ Unresolved:@vitejs/plugin-vueremains incompatible with Vite 6—update to 6.x.A prior review flagged that
@vitejs/plugin-vue@^5.2.xtargets Vite 5, whilevite@^6.4.0is Vite 6. This mismatch causes build/dev failures. The plugin needs a major version bump to 6.x (e.g.,^6.0.0) to align with Vite 6, or Vite must revert to 5.x.Apply this diff to align the plugin with Vite 6:
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",Alternatively, revert Vite to the 5.x line:
- "vite": "^6.4.0", + "vite": "^5.4.11",integrations/react-vite/package.json (1)
11-11:⚠️ Unresolved:@vitejs/plugin-react@^4.7.0is incompatible withvite@^6.4.0—update to 5.x.Prior reviews flagged this incompatibility twice:
@vitejs/[email protected]declares peers ofvite@^4 || ^5, which excludes Vite 6. Pairing it withvite@^6.4.0causes install failures under pnpm's strict peer checking. Bump the plugin to 5.x (first Vite 6-compatible release) or downgrade Vite to 5.x.Apply this diff to upgrade the plugin to Vite 6-compatible release:
- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",Alternatively, downgrade Vite to 5.x:
- "vite": "^6.4.0" + "vite": "^5.4.11"Also applies to: 14-14
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/angular/basic-persister/package.json
- examples/angular/optimistic-updates/package.json
🚧 Files skipped from review as they are similar to previous changes (56)
- examples/react/default-query-function/package.json
- examples/vue/nuxt3/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/auto-refetching/package.json
- packages/query-sync-storage-persister/package.json
- packages/react-query/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/simple/package.json
- examples/react/shadow-dom/package.json
- examples/vue/2.7-basic/package.json
- examples/react/offline/package.json
- packages/svelte-query-devtools/package.json
- packages/solid-query-persist-client/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/ssr/package.json
- packages/query-persist-client-core/package.json
- examples/react/basic/package.json
- packages/react-query-persist-client/package.json
- examples/solid/solid-start-streaming/package.json
- packages/svelte-query/package.json
- examples/react/eslint-legacy/package.json
- examples/react/chat/package.json
- packages/query-devtools/package.json
- examples/react/react-router/package.json
- examples/solid/basic/package.json
- packages/angular-query-experimental/package.json
- integrations/svelte-vite/package.json
- packages/solid-query/package.json
- examples/svelte/basic/package.json
- examples/svelte/star-wars/package.json
- packages/query-async-storage-persister/package.json
- integrations/react-webpack-5/package.json
- examples/react/devtools-panel/package.json
- examples/react/suspense/package.json
- examples/svelte/simple/package.json
- examples/solid/simple/package.json
- examples/angular/rxjs/package.json
- examples/react/simple/package.json
- examples/react/playground/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/query-core/package.json
- examples/vue/basic/package.json
- examples/react/algolia/package.json
- examples/vue/dependent-queries/package.json
- examples/svelte/optimistic-updates/package.json
- integrations/angular-cli-20/package.json
- packages/angular-query-persist-client/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/solid/default-query-function/package.json
- examples/vue/persister/package.json
- examples/react/basic-graphql-request/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/pagination/package.json
- examples/angular/devtools-panel/package.json
- packages/eslint-plugin-query/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/svelte-query-persist-client/package.jsonpackages/vue-query-devtools/package.jsonintegrations/react-vite/package.jsonintegrations/solid-vite/package.jsonintegrations/react-next-15/package.jsonpackages/react-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (11)
packages/solid-query-devtools/package.json (1)
71-74: Package updates look good.Patch-level bumps to npm-run-all2, solid-js, and vite-plugin-solid are consistent with updates elsewhere in the PR and pose no compatibility issues.
integrations/solid-vite/package.json (1)
11-13: Package updates align with broader PR changes.Solid-js and vite-plugin-solid patches are consistent with solid-query-devtools and Solid examples. No peer dependency concerns.
examples/vue/2.6-basic/package.json (1)
11-11: Patch update looks good.Minor dependency bump to @tanstack/vue-query is safe and consistent with updates to other Vue examples in this PR.
packages/svelte-query-persist-client/package.json (1)
55-63: Svelte ecosystem updates are consistent and safe.All changes (Svelte, svelte-check, ESLint plugins, and @sveltejs/package) are patch or minor-level updates that align with the broader PR refresh. The peer requirement of
svelte@^5.25.0is satisfied by the bump to^5.40.1. No Vite peer conflicts introduced, since this package does not directly pin vite.packages/query-test-utils/package.json (1)
38-38: Patch update is appropriate.Bump of npm-run-all2 to
^5.0.2is consistent with similar updates throughout the PR and poses no compatibility risks.examples/solid/astro/package.json (1)
15-22: Astro and Solid framework updates are safe.Minor and patch-level bumps to Astro integrations (@astrojs/solid-js, @astrojs/vercel), Solid-js, and Tailwind CSS are reasonable and consistent with other framework example updates in this PR. Astro manages vite internally, so no direct vite peer-dependency concerns here.
packages/react-query-devtools/package.json (1)
86-89: Dependency bumps look safe.These are incremental updates to test tooling and build utilities with no breaking compatibility issues for this package.
package.json (1)
43-80: DevDependency bumps are standard.Tool and plugin updates are consistent with the PR's scope (minor/patch version bumps). No breaking API changes in the root devDependencies.
integrations/react-next-15/package.json (1)
9-9: Patch-level bump to@js-temporal/polyfill@^0.5.1is safe.The minor version bump from 0.4.4 to 0.5.1 introduces non-breaking changes. No compatibility concerns identified.
packages/vue-query/package.json (1)
66-66: Patch-level dependency updates are compatible.Both
@vue/devtools-api@^6.6.4andeslint-plugin-vue@^10.5.1are patch-version bumps within stable ranges. No compatibility or functionality concerns.Also applies to: 73-73
integrations/react-webpack-4/package.json (1)
14-17: Babel and webpack tooling version bumps are safe.Updates to
@babel/*packages (^7.26–^7.28 range) andbabel-loader@^8.4.1are minor/patch-level bumps within compatible caret ranges. No peer-dependency conflicts or breaking changes anticipated.Also applies to: 21-21
| "@tailwindcss/vite": "^4.1.14", | ||
| "@vitejs/plugin-react": "^4.7.0", | ||
| "tailwindcss": "^4.1.14", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
@vitejs/plugin-react 4.x incompatible with Vite 6.
@vitejs/plugin-react@^4.7.0 declares peer dependency vite@^4 || ^5, but line 23 specifies vite@^6.4.0. This mismatch will cause install/build failures. Upgrade the plugin to a version that supports Vite 6.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@tailwindcss/vite": "^4.1.14", | |
| "@vitejs/plugin-react": "^4.7.0", | |
| "tailwindcss": "^4.1.14", | |
| "typescript": "5.8.3", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| "@tailwindcss/vite": "^4.1.14", | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "tailwindcss": "^4.1.14", | |
| "typescript": "5.8.3", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
In examples/react/star-wars/package.json around lines 19 to 23,
@vitejs/plugin-react@^4.7.0 declares a peer dependency on Vite ^4 || ^5 while
vite is set to ^6.4.0, causing an incompatibility; update the plugin to a
Vite-6-compatible release (e.g., bump @vitejs/plugin-react to a v5.x that
supports Vite 6), update package.json accordingly, run install to update
lockfile, and verify the dev build starts successfully.
65a7c20 to
b14c115
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (16)
examples/vue/basic/package.json (1)
16-18: Resolve Vite 6 plugin compatibility.
@vitejs/plugin-vuev5 only supportsvite@^5, but the file now specifiesvite@^6.4.0. This peer-range mismatch will prevent lockfile generation and install success with pnpm. Bump the plugin to the Vite 6-compatible major (v6).- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",examples/react/eslint-legacy/package.json (1)
23-25: Raise@vitejs/plugin-reactto the Vite 6-compatible major.
@vitejs/plugin-reactv4 does not supportvite@^6.4.0(peer range capped at Vite 5). This will cause install failures with pnpm due to peer-dependency violations. Bump to the v5 line that supports Vite 6.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/chat/package.json (1)
17-21: Raise@vitejs/plugin-reactto Vite 6-compatible major.While the Tailwind CSS and plugin versions are reasonable,
@vitejs/plugin-react@^4.7.0is incompatible withvite@^6.4.0(v4 peer range capped at Vite 5). This will trigger pnpm install failures. Upgrade the React plugin to v5.- "@tailwindcss/vite": "^4.1.14", - "@vitejs/plugin-react": "^4.7.0", + "@tailwindcss/vite": "^4.1.14", + "@vitejs/plugin-react": "^5.0.0",examples/angular/basic-persister/package.json (1)
12-15: Update TypeScript to meet Angular 20.3.6 peer requirements.Angular 20.3.6 requires TypeScript ≥5.9.0 <6.0.0, but Line 27 pins TypeScript to 5.8.3, which is below the minimum supported version. This was flagged in a previous review and remains unresolved.
Apply this diff to fix the incompatibility:
"devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.6", - "typescript": "5.8.3" + "typescript": "^5.9.0" }Also applies to: 21-21, 24-26
examples/react/offline/package.json (1)
22-22: Bump @vitejs/plugin-react to v5 for Vite 6 compatibility.@vitejs/plugin-react remains pinned to v4 (^4.7.0) while vite is bumped to v6. This is incompatible and was flagged in a previous review. v4 of the plugin does not support Vite 6.
Apply this diff to resolve the peer dependency conflict:
"devDependencies": { - "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0", "typescript": "5.8.3", "vite": "^6.4.0" }Also applies to: 24-24
examples/react/simple/package.json (1)
17-17: Bump @vitejs/plugin-react to v5 for Vite 6 compatibility.@vitejs/plugin-react remains pinned to v4 (^4.7.0) while vite is upgraded to v6. This is incompatible; v4 of the plugin does not support Vite 6. This issue was flagged in a previous review.
Apply this diff to resolve the peer dependency conflict:
"devDependencies": { - "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0", "typescript": "5.8.3", "vite": "^6.4.0" }Also applies to: 19-19
examples/angular/infinite-query-with-max-pages/package.json (1)
12-15: Update TypeScript to meet Angular 20.3.6 peer requirements.Angular 20.3.6 requires TypeScript ≥5.9.0 <6.0.0, but Line 25 pins TypeScript to 5.8.3, which is below the minimum supported version. This matches the issue flagged in a previous review for another Angular example.
Apply this diff to fix the incompatibility:
"devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.6", - "typescript": "5.8.3" + "typescript": "^5.9.0" }Also applies to: 19-19, 22-24
examples/svelte/optimistic-updates/package.json (1)
15-21: Verify @sveltejs/kit 2.47.0 peer compatibility with Vite 6.A prior review flagged a peer dependency conflict between @sveltejs/kit (expecting Vite ^5) and Vite ^6.4.0. Please confirm that @sveltejs/kit@^2.47.0 has been updated to declare Vite 6 support, or downgrade vite to ^5.x if not.
Does @sveltejs/kit 2.47.0 support Vite 6.x (peer dependency range)?examples/react/algolia/package.json (1)
21-21: @vitejs/plugin-react v4 incompatible with Vite 6; upgrade to v5.@vitejs/plugin-react v4.x declares a peer dependency on Vite ^5.x, but this project pins Vite ^6.4.0, causing peer resolution failures (particularly with pnpm).
"devDependencies": { - "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0", "typescript": "5.8.3", "vite": "^6.4.0" }Also applies to: 23-23
examples/svelte/star-wars/package.json (1)
18-18: Tailwind 4 requires migration steps; either include migration or revert to v3.Tailwind CSS v4 is a major breaking change from v3 with a new config format (no
tailwind.config.{js,ts}), updated entry points, and CLI changes. Upgrading @tailwindcss/vite and tailwindcss to ^4.1.14 without performing these migrations will break the build.Either:
- Complete the Tailwind 4 migration (update config, entry point, PostCSS setup), or
- Keep Tailwind at v3 for now (e.g.,
^3.4.x).Also applies to: 21-21
examples/angular/basic/package.json (1)
12-25: Critical: Angular 20.3.x requires TypeScript >=5.9.0; bump from 5.8.3.Angular 20.3.6 enforces a peer range of
>=5.9.0 <6.0.0for TypeScript. Keeping version 5.8.3 will cause peer dependency resolution failures (blocking installs, especially with pnpm) and build errors."devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.6", - "typescript": "5.8.3" + "typescript": "^5.9.0" }examples/angular/simple/package.json (1)
12-25: Critical: Angular 20.3.x requires TypeScript >=5.9.0; bump from 5.8.3.Angular 20.3.6 enforces a peer range of
>=5.9.0 <6.0.0for TypeScript. Keeping version 5.8.3 will cause peer dependency resolution failures and build errors."devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.6", - "typescript": "5.8.3" + "typescript": "^5.9.0" }examples/angular/query-options-from-a-service/package.json (1)
12-26: Critical: Angular 20.3.x requires TypeScript >=5.9.0; bump from 5.8.3.Angular 20.3.6 enforces a peer range of
>=5.9.0 <6.0.0for TypeScript. Keeping version 5.8.3 will cause peer dependency resolution failures and build errors."devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.6", - "typescript": "5.8.3" + "typescript": "^5.9.0" }package.json (1)
8-8:⚠️ Enforce [email protected] in CI workflows.The
packageManagerfield alone does not enforce the pnpm version in CI. CI workflows must be updated to pin [email protected] to prevent lockfile version mismatches and build failures.Verify that
.github/workflows/*.ymlinclude a setup step that pins pnpm to 10.18.3. Use one of the following approaches:
Via Corepack (recommended if Node.js ≥16.9):
corepack enable && corepack use [email protected]Via pnpm/action-setup:
- uses: pnpm/action-setup@v2 with: version: "10.18.3"Please confirm that all workflows running pnpm commands include this setup step before install/build tasks.
examples/angular/router/package.json (1)
12-26:⚠️ TypeScript 5.8.3 is incompatible with Angular 20.3.6 – this will break the build.Angular CLI/compiler 20.3.x require TypeScript ≥5.9.0 <6.0.0, but the project pins 5.8.3 (line 26). Update TypeScript to
^5.9.0or later to match the Angular peer dependency range.Apply this diff:
"devDependencies": { "@angular/build": "^20.3.6", "@angular/cli": "^20.3.6", "@angular/compiler-cli": "^20.3.6", - "typescript": "5.8.3" + "typescript": "^5.9.0" }After updating, verify
tsconfig.jsoncompiler options remain compatible and re-run build/tests.examples/react/react-native/package.json (1)
19-29:⚠️ Expo SDK 52 is incompatible with React Native 0.82 – Metro and native builds will fail.Expo SDK 52 ships with React Native 0.76.x (0.77 opt-in), but the current configuration declares RN ^0.82.0 and matching native packages. This mismatch will break the Metro bundler and native builds in the managed workflow.
Action required: Choose one of the following:
- Upgrade Expo to the SDK version that targets RN 0.82 (e.g., likely SDK 53+) and update all Expo companion packages to match.
- Downgrade React Native stack to SDK 52-aligned versions (RN 0.76/0.77 plus compatible gesture-handler/reanimated/screens/safe-area/web), then run
expo doctorto verify alignment.Past review marked this as addressed in commit 63bfa47, but the current code still shows the incompatible versions. Please verify the fix status and apply the appropriate resolution.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (49)
- examples/react/devtools-panel/package.json
- examples/angular/rxjs/package.json
- packages/svelte-query-persist-client/package.json
- integrations/angular-cli-20/package.json
- packages/react-query-persist-client/package.json
- integrations/react-vite/package.json
- packages/react-query-next-experimental/package.json
- packages/query-broadcast-client-experimental/package.json
- integrations/react-webpack-5/package.json
- examples/solid/astro/package.json
- examples/vue/simple/package.json
- examples/react/default-query-function/package.json
- packages/solid-query-persist-client/package.json
- examples/vue/dependent-queries/package.json
- integrations/solid-vite/package.json
- examples/react/basic/package.json
- packages/react-query/package.json
- examples/angular/auto-refetching/package.json
- integrations/svelte-vite/package.json
- examples/angular/pagination/package.json
- examples/svelte/simple/package.json
- packages/query-async-storage-persister/package.json
- packages/query-sync-storage-persister/package.json
- examples/solid/basic/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/optimistic-updates/package.json
- packages/vue-query-devtools/package.json
- examples/vue/nuxt3/package.json
- examples/vue/persister/package.json
- packages/react-query-devtools/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/shadow-dom/package.json
- examples/react/star-wars/package.json
- packages/solid-query/package.json
- packages/query-test-utils/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/react-router/package.json
- integrations/vue-vite/package.json
- packages/query-persist-client-core/package.json
- packages/angular-query-experimental/package.json
- examples/svelte/playground/package.json
- examples/react/basic-graphql-request/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/rick-morty/package.json
- examples/svelte/basic/package.json
- integrations/react-webpack-4/package.json
- packages/svelte-query-devtools/package.json
- packages/eslint-plugin-query/package.json
- packages/angular-query-persist-client/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.jsonpackages/svelte-query/package.jsonintegrations/react-next-15/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (14)
packages/query-core/package.json (1)
63-63: LGTM!Patch bump to npm-run-all2 is a safe, standard dependency update.
examples/solid/default-query-function/package.json (1)
13-18: LGTM!All dependency bumps are patch versions (minor version improvements) and present no compatibility concerns.
packages/solid-query-devtools/package.json (1)
71-74: LGTM!All dependency bumps are patch versions and present no compatibility concerns.
integrations/react-next-15/package.json (1)
9-9: LGTM!Minor version bump to the polyfill is a safe dependency update with no expected breaking changes.
packages/vue-query/package.json (1)
66-66: Patch updates are safe.Both @vue/devtools-api (6.6.3 → 6.6.4) and eslint-plugin-vue (10.5.0 → 10.5.1) are patch-level updates within stable caret ranges with no known breaking changes.
Also applies to: 73-73
examples/solid/simple/package.json (1)
13-13: Patch and minor updates are compatible.solid-js (1.9.7 → 1.9.9), vite (6.3.6 → 6.4.0), and vite-plugin-solid (2.11.6 → 2.11.9) are all backward-compatible patch or minor bumps.
Also applies to: 18-19
examples/svelte/ssr/package.json (1)
15-16: Patch and minor updates are compatible.All devDependency updates (@sveltejs/adapter-auto, @sveltejs/kit, svelte, svelte-check, vite) are backward-compatible patch or minor bumps within their respective major versions.
Also applies to: 18-22
examples/svelte/auto-refetching/package.json (1)
15-16: Patch and minor updates are compatible.All devDependency updates (@sveltejs/adapter-auto, @sveltejs/kit, svelte, svelte-check, vite) are backward-compatible patch or minor bumps within their respective major versions.
Also applies to: 18-22
examples/react/playground/package.json (1)
17-19: LGTM!The dependency versions are compatible and represent safe patch/minor updates.
packages/svelte-query/package.json (1)
55-55: LGTM!All devDependency updates are compatible patches/minor versions; peer constraint
svelte ^5.25.0is satisfied.Also applies to: 59-62
packages/query-devtools/package.json (1)
67-80: LGTM!Dev dependency updates are aligned across the Solid ecosystem (minor/patch bumps). No API or build surface changes detected.
package.json (1)
43-80: Verify devDependency updates for breaking changes or peer dependency conflicts.Multiple devDependency updates are present (ESLint, Vite, testing libraries, TypeScript, nx, etc.). While these appear to be minor/patch bumps, confirm:
- No TypeScript-dependent packages (e.g., @types/*, eslint plugins) conflict with the pinned TS 5.8.3 in examples (e.g., examples/angular/router/package.json).
- ESLint 9.37.0 and @eslint-react/eslint-plugin 2.2.2 are compatible with the project's lint rules.
- Vite 6.4.0 updates (line 80) do not introduce breaking changes for example builds that still use older Vite versions (e.g., examples/vue/2.7-basic/ pinned to ^4.5.14).
examples/vue/2.7-basic/package.json (1)
11-11: LGTM!Patch bump to @tanstack/vue-query is routine and compatible.
examples/vue/2.6-basic/package.json (1)
11-11: LGTM!Patch bump to @tanstack/vue-query is routine and compatible.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
Raise @vitejs/plugin-react to Vite 6-compatible version.
@vitejs/plugin-react v4 declares peer dependencies only up to vite@^5, incompatible with vite@^6.4.0 now specified. Bump the plugin to v5 to resolve the peer-range violation.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-react": "^4.7.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
In examples/react/suspense/package.json around lines 19 to 21,
@vitejs/plugin-react is pinned to v4 which lists a peer dependency for Vite up
to ^5 and therefore conflicts with the project's vite ^6.4.0; update the
dependency to @vitejs/plugin-react v5 (or the latest v5-compatible release) in
package.json so its peer range includes Vite 6, then run yarn/npm install and
test the dev build to confirm the peer-range violation is resolved.
b14c115 to
a993f09
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
71-71: Upgrade TypeScript to resolve peer dependency conflict with Angular 20.3.x.Verification confirms @angular/cli 20.3.x is used across 12 workspace packages (examples and integrations). The current TypeScript 5.8.3 is incompatible with Angular 20.3.x's peer requirement of >=5.9.0 <6.0.0, causing install/build errors.
Update package.json line 71:
- "typescript": "5.8.3", + "typescript": "^5.9.0",
♻️ Duplicate comments (9)
examples/vue/persister/package.json (1)
19-21: @vitejs/plugin-vue version mismatch persists.As flagged in the previous review,
@vitejs/plugin-vuev5.x targets Vite 5, while Vite is at 6.4.0. This creates a compatibility mismatch. Bump the plugin to v6.x to align with Vite 6, or roll Vite back to the 5.x line.Option A: Upgrade plugin to v6
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",Option B: Downgrade Vite to 5.x (if you prefer to stay on Vite 5)
- "vite": "^6.4.0" + "vite": "^5.x"examples/react/devtools-panel/package.json (1)
17-19: Fix Vite/plugin-react version mismatch (critical blocker).This file still carries the peer-dependency incompatibility flagged in the previous review:
@vitejs/plugin-reactv4.x does not declare Vite 6 in peerDependencies. Bump to v5.x to support Vite 6.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/basic/package.json (1)
23-25: Fix Vite/plugin-react version mismatch (critical blocker).As flagged in the previous review,
@vitejs/plugin-reactv4.x targets Vite 5 and does not include Vite 6 in peerDependencies. This will cause pnpm to fail. Bump to v5.x.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/chat/package.json (1)
17-21: @vitejs/plugin-react v4 is incompatible with vite v6—peer-dep violation will block installs.The dependency spec bumps vite to
^6.4.0but leaves@vitejs/plugin-reactat^4.7.0. Plugin v4 declares peer support only forvite ^4 || ^5, so pnpm (with strict peer checking enabled) will refuse to install. This was flagged in previous reviews and remains unresolved.Bump the plugin to a Vite 6-compatible major (v5+):
- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/offline/package.json (1)
22-24: @vitejs/plugin-react v4 incompatible with vite v6—unresolved peer-dep violation.Plugin-react v4 does not support vite v6 in its peer range. This causes install failures with strict peer checking. Prior review flagged this; it remains unresolved.
Upgrade plugin to v5:
- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/rick-morty/package.json (1)
19-23: @vitejs/plugin-react v4 incompatible with vite v6—critical peer-dep violation.This is the third example in the PR with this unresolved issue. Vite v6.4.0 requires plugin-react v5+. Prior reviews flagged this as critical; it must be fixed.
Upgrade plugin to v5:
- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/angular/rxjs/package.json (1)
22-27:⚠️ CRITICAL: TypeScript 5.8.3 violates Angular 20.3.6 peer requirements.Angular 20.3.6 requires TypeScript >=5.9.0 and <6.0.0. The package.json pins TypeScript to 5.8.3, which is incompatible and will cause install/build failures.
Update TypeScript to a compatible version:
- "typescript": "5.8.3" + "typescript": "^5.9.0"Then regenerate the lockfile with your package manager.
examples/angular/router/package.json (1)
26-26:⚠️ Duplicate: TypeScript 5.8.3 incompatible with @angular/cli 20.3.6 — not fixed from previous review.This is the same critical issue flagged in a prior review: @angular/cli 20.3.x requires TypeScript >=5.9.0 <6.0.0, but this file pins 5.8.3. This will cause install/build errors. The Angular dependencies were bumped to 20.3.6 (lines 12–25) but TypeScript was not updated to maintain compatibility.
Upgrade TypeScript to a compatible version:
- "typescript": "5.8.3" + "typescript": "^5.9.0"After updating, run
pnpm installto update the lockfile, verifytsconfig.jsonsettings still work, and re-run build/tests to confirm no regressions.package.json (1)
8-8:⚠️ Duplicate: pnpm CI enforcement not added — not fixed from previous review.The
packageManagerfield was updated to[email protected], but CI workflows still lack enforcement. Withoutcorepack enable && corepack use [email protected]or apnpm/action-setup@v2action in.github/workflows/*.yml, CI will not use the pinned version and may produce lockfile mismatches.Add pnpm pinning to all CI workflows:
#!/bin/bash # Check if CI workflows have pnpm setup enforcement fd -t f '.github/workflows' --exec grep -l 'corepack\|pnpm/action-setup' {} \;If missing, add a step to pin pnpm in each workflow (before any pnpm commands):
- name: Setup pnpm uses: pnpm/action-setup@v2 with: version: "10.18.3"Or use Corepack:
corepack enable && corepack use [email protected]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- examples/react/default-query-function/package.json
🚧 Files skipped from review as they are similar to previous changes (52)
- examples/solid/default-query-function/package.json
- packages/query-persist-client-core/package.json
- packages/query-async-storage-persister/package.json
- packages/vue-query/package.json
- examples/angular/basic-persister/package.json
- packages/react-query-devtools/package.json
- integrations/react-webpack-5/package.json
- examples/svelte/basic/package.json
- packages/react-query-persist-client/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/astro/package.json
- packages/query-test-utils/package.json
- integrations/svelte-vite/package.json
- packages/react-query/package.json
- examples/solid/basic-graphql-request/package.json
- packages/query-devtools/package.json
- examples/react/star-wars/package.json
- examples/vue/simple/package.json
- examples/angular/basic/package.json
- examples/vue/basic/package.json
- integrations/vue-vite/package.json
- packages/vue-query-devtools/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/optimistic-updates/package.json
- packages/angular-query-experimental/package.json
- examples/react/react-router/package.json
- integrations/react-vite/package.json
- packages/solid-query-devtools/package.json
- examples/react/playground/package.json
- integrations/solid-vite/package.json
- integrations/react-webpack-4/package.json
- examples/angular/auto-refetching/package.json
- examples/react/eslint-legacy/package.json
- examples/svelte/auto-refetching/package.json
- examples/solid/basic/package.json
- examples/react/suspense/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/react-native/package.json
- packages/solid-query/package.json
- examples/angular/pagination/package.json
- packages/query-core/package.json
- examples/vue/nuxt3/package.json
- examples/vue/dependent-queries/package.json
- examples/react/algolia/package.json
- packages/svelte-query-devtools/package.json
- examples/solid/simple/package.json
- examples/angular/simple/package.json
- integrations/angular-cli-20/package.json
- packages/svelte-query-persist-client/package.json
- packages/angular-query-persist-client/package.json
- examples/svelte/ssr/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/solid-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: autofix
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (17)
examples/vue/2.7-basic/package.json (1)
11-11: Patch dependency bump looks good.This is a straightforward patch-level update with no compatibility concerns.
examples/solid/solid-start-streaming/package.json (1)
14-18: Solid ecosystem updates look correct.All dependency bumps are minor/patch updates within compatible version ranges. No compatibility concerns detected.
integrations/react-next-15/package.json (1)
9-9: Polyfill minor bump is safe.The update to
@js-temporal/polyfill^0.5.1 is a routine minor-version bump with no detected compatibility issues.examples/react/simple/package.json (1)
17-19: Fix Vite/plugin-react version mismatch (critical blocker).
@vitejs/plugin-reactv4.x targets Vite 5 only; v5.x is required for Vite 6 compatibility. Upgrade to v5.0.0 or later to avoid pnpm peer-dependency errors.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",Likely an incorrect or invalid review comment.
examples/vue/2.6-basic/package.json (1)
11-11: Dependency bump is safe and compatible.Patch-level semver bump for
@tanstack/vue-querywith vite remaining on v4 poses no peer-dependency risks.examples/react/offline/package.json (1)
16-16: msw and react-hot-toast bumps are safe.Patch and minor semver bumps pose no breaking changes.
Also applies to: 19-19
packages/svelte-query/package.json (1)
55-62: Svelte and tooling bumps are safe and compatible.All updates are minor/patch versions within declared peer ranges. No compatibility issues detected.
packages/query-broadcast-client-experimental/package.json (1)
65-67: @testing-library/react and npm-run-all2 bumps are safe.Patch-level updates within declared ranges. If this package uses vite v6, verify @vitejs/plugin-react compatibility (not visible in provided excerpt).
examples/react/rick-morty/package.json (1)
15-16: react-router and react-router-dom minor bumps are safe.Semver-compatible updates within declared ranges.
packages/eslint-plugin-query/package.json (1)
62-62: ESLint and TypeScript tooling patch bumps are safe.All updates remain within declared semver ranges and peerDependencies. No compatibility issues.
Also applies to: 65-69
packages/query-sync-storage-persister/package.json (1)
67-67: npm-run-all2 patch bump is safe.Minor patch version update within declared range poses no compatibility risk.
examples/svelte/simple/package.json (1)
14-21: Minor/patch version bumps for Svelte tooling—no issues.Vite ^6.4.0 is safe here since this example doesn't depend on @sveltejs/kit or @sveltejs/vite-plugin-svelte, which would otherwise have vite ^5.x peer constraints.
packages/solid-query-persist-client/package.json (1)
69-77: Patch-version bumps for Solid tooling—no issues.All updates are minor patch increments. Solid.js peerDependency constraint (^1.6.0) is satisfied by the new ^1.9.9 version.
examples/svelte/star-wars/package.json (1)
18-18: Review comment is incorrect — migration is already complete.The project has already been migrated to Tailwind 4. The
app.cssfile uses the Tailwind 4 CSS-first format with@import 'tailwindcss'and@themeblocks. Thevite.config.jsalready imports@tailwindcss/viteand includes it in the plugins array. Notailwind.config.jsexists because it's not required in Tailwind 4's CSS-first approach. The version bump to^4.1.14is simply updating to the latest patch within the major version that's already in use.Likely an incorrect or invalid review comment.
examples/angular/query-options-from-a-service/package.json (1)
22-27: ❌ INCORRECT REVIEW COMMENTThe review incorrectly states that Angular 20.3.6 requires
"typescript": ">=5.9.0 <6.0.0". Angular 20.x requires TypeScript 5.8—specifically Angular 20 (including 20.0–20.3) has a peer dependency of"typescript": ">=5.8 <5.9".TypeScript 5.8.3 is correct and fully compatible with Angular 20.3.6. No changes are needed. The code is valid as-is.
Additionally, commit f76c947 referenced in the review does not exist in the repository history, further confirming the issue basis is flawed.
Likely an incorrect or invalid review comment.
examples/angular/devtools-panel/package.json (1)
22-27: The review comment contains incorrect peer dependency information.Angular 20.3.6 requires TypeScript matching ^20.19.0, ^22.12.0, or ^24.0.0, not the ">=5.9.0 <6.0.0" range stated in the review. While TypeScript 5.8.3 is indeed incompatible with Angular 20.3.6, the specific version constraints and suggested fix (^5.9.0) in the review comment are incorrect and would not resolve the incompatibility.
The actual TypeScript version needs to be in one of the compatible ranges (20.19+, 22.12+, or 24.0+), not 5.9.x.
Likely an incorrect or invalid review comment.
package.json (1)
69-70: Dependencies are actively used throughout the codebase—this review comment is based on incomplete information.Both
tinyglobbyandtsupare established build tools with clear purposes:
- tinyglobby: Used in
scripts/verify-links.tsandscripts/generateDocs.tsfor file globbing during build and documentation generation.- tsup: Core bundler for the entire monorepo—integrated across 20+ packages with dedicated
tsup.config.tsfiles and build scripts invokingtsup --tsconfig tsconfig.prod.json.These are not unexplained additions but foundational dependencies that are extensively referenced and actively integrated into the build infrastructure.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
Fix Vite/plugin-react version mismatch.
@vitejs/plugin-react v4.x targets Vite 5, while v5.x targets Vite 6. Keeping v4 with Vite 6.4.0 will cause pnpm peer-dependency resolution errors.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-react": "^4.7.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.3.6" | |
| "vite": "^6.4.0" | |
| "@vitejs/plugin-react": "^5.0.0", | |
| "typescript": "5.8.3", | |
| "vite": "^6.4.0" |
🤖 Prompt for AI Agents
In examples/react/shadow-dom/package.json around lines 19 to 21, the
@vitejs/plugin-react version (v4.x) is incompatible with Vite 6.x; update the
plugin to a v5 release that targets Vite 6 (e.g., change "@vitejs/plugin-react"
to "^5.0.0" or the latest 5.x) so peer-dependency resolution succeeds, or
alternatively downgrade Vite to a 5.x version—prefer bumping the plugin to 5.x
to match Vite 6.
| "@sveltejs/adapter-auto": "^6.1.1", | ||
| "@sveltejs/kit": "^2.47.1", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "svelte": "^5.39.3", | ||
| "svelte-check": "^4.3.1", | ||
| "svelte": "^5.40.2", | ||
| "svelte-check": "^4.3.3", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
🧩 Analysis chain
@sveltejs/[email protected] and @sveltejs/[email protected] both require "vite": "^5.0.0" in peerDependencies. The current vite ^6.4.0 violates this constraint. A past review indicated commit 63bfa47 addressed this, but the current code still shows the incompatible version.
Either:
- Downgrade vite to ^5.4.11 (or latest 5.x) to match peer requirements.
- Verify that a newer SvelteKit/plugin release exists with Vite 6 support and update both.
Clarify whether commit 63bfa47 actually fixed this or if this is a rebased PR. If unresolved, downgrade vite to a compatible ^5.x line.
I'll verify the claims in this review comment by checking the current package configuration and the peer dependencies of the referenced packages.
🏁 Script executed:
#!/bin/bash
# Check the actual current state of the package.json file
cat examples/svelte/optimistic-updates/package.jsonLength of output: 566
🌐 Web query:
@sveltejs/kit 2.47.1 vite peer dependencies
💡 Result:
@sveltejs/kit 2.47.1 requires Vite 5 (vite@^5) and the @sveltejs/vite-plugin-svelte v3 as peer dependencies. It also expects Svelte 4 and Node ≥ 18.13. [1][2]
Sources:
[1] SvelteKit docs — "Updated dependency requirements" (vite@5, @sveltejs/vite-plugin-svelte@3, svelte@4, Node 18.13+).
[2] GitHub issue/error referencing the peer dependency requirement for @sveltejs/vite-plugin-svelte.
🌐 Web query:
@sveltejs/vite-plugin-svelte 5.1.1 vite peer dependencies
💡 Result:
For @sveltejs/[email protected] the peerDependencies are:
- svelte: ^5.0.0. [1]
- vite: ^6.0.0. [1][2]
Sources: [1] package info / lockfile excerpts showing the plugin's peerDeps; [2] npm package listing for the v5.x line.
@sveltejs/[email protected] requires Vite 5 (vite@^5), but the package.json specifies vite@^6.4.0. Additionally, @sveltejs/[email protected] expects @sveltejs/vite-plugin-svelte v3, but the file contains @sveltejs/[email protected] — a major version mismatch.
The correct versions should align with @sveltejs/[email protected]'s peer dependencies. Either:
- Downgrade @sveltejs/vite-plugin-svelte to @3.x and vite to ^5.x to match [email protected] requirements.
- Or upgrade @sveltejs/kit to a version compatible with @sveltejs/[email protected] and [email protected].
🤖 Prompt for AI Agents
In examples/svelte/optimistic-updates/package.json around lines 15-21, the
@sveltejs/[email protected] entry is incompatible with vite@^6.4.0 and
@sveltejs/[email protected]; align versions by either downgrading vite
and the plugin to Kit's peers or upgrading Kit to match the newer vite/plugin.
To fix quickly, change vite to a v5 release (e.g., ^5.x) and
@sveltejs/vite-plugin-svelte to the v3 major that matches [email protected] (e.g.,
^3.x), then run npm install (or pnpm install) and validate the app starts;
alternatively, if you prefer newer vite/plugin, upgrade @sveltejs/kit to a
version that lists vite@^6 and plugin@^5 as peers, update package.json
accordingly and reinstall.
| "@sveltejs/adapter-auto": "^6.1.1", | ||
| "@sveltejs/kit": "^2.47.1", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "@tailwindcss/vite": "^4.1.13", | ||
| "svelte": "^5.39.3", | ||
| "svelte-check": "^4.3.1", | ||
| "tailwindcss": "^4.1.13", | ||
| "@tailwindcss/vite": "^4.1.14", | ||
| "svelte": "^5.40.2", | ||
| "svelte-check": "^4.3.3", | ||
| "tailwindcss": "^4.1.14", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
🧩 Analysis chain
@sveltejs/[email protected] and @sveltejs/[email protected] require "vite": "^5.0.0". Bumping vite to ^6.4.0 violates peer constraints and will block installs.
Downgrade vite to a ^5.x line:
- "vite": "^6.4.0"
+ "vite": "^5.4.11"Downgrade vite to a compatible ^5.x version or verify that newer SvelteKit releases support Vite 6.
I'll verify the peer dependency claims in the review comment by searching for information about the specific package versions mentioned.
🌐 Web query:
@sveltejs/kit 2.47.1 peer dependencies vite
💡 Result:
Do you want me to look up the exact peerDependency requirement for @sveltejs/[email protected] (which Vite versions it accepts)? If so I’ll fetch the package metadata and report the exact vite range.
🌐 Web query:
@sveltejs/vite-plugin-svelte 5.1.1 peer dependencies vite
💡 Result:
@ sveltejs/vite-plugin-svelte v5.1.1 requires Vite 6 — peer dependency: "vite": "^6.0.0". [1][2]
Sources:
- Renovate changelog / MR for v5.1.1 noting v5.x requires Vite 6 and v5.1.0 change requiring Vite 6.2 for CSS scoping. [1]
- Example package/lock entries showing peerDependencies include vite: ^6.0.0. [2]
References:
[1] https://git.inpt.fr/inp-net/frappe/-/merge_requests/114
[2] https://gist.github.com/manutheblacker/f4c47c32848609a96329250e7e3de9fa
I need to verify the peer dependency for @sveltejs/[email protected] to complete the analysis:
🌐 Web query:
@sveltejs/kit version 2.47.1 vite peer dependency requirement
💡 Result:
@sveltejs/[email protected] requires Vite 5 — i.e. peer dependency vite@"^5.0.0". [1][2]
References:
[1] SvelteKit docs — "Updated dependency requirements" (requires vite@5).
[2] SvelteKit GitHub releases / package notes (SvelteKit 2.x uses Vite 5 and makes @sveltejs/vite-plugin-svelte a peer dependency).
The packages have conflicting Vite requirements: @sveltejs/[email protected] requires vite@^5.0.0 while @sveltejs/[email protected] requires vite@^6.0.0. The current vite@^6.4.0 violates the SvelteKit constraint. Downgrading vite to ^5.x would break the vite-plugin-svelte package instead.
Resolution options:
- Upgrade @sveltejs/kit to a version supporting Vite 6 (e.g., 2.48.0+)
- Downgrade @sveltejs/vite-plugin-svelte to a version supporting Vite 5
- Keep current versions only if peer dependency warnings are acceptable
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
a993f09 to
8b44964
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
♻️ Duplicate comments (10)
examples/react/default-query-function/package.json (1)
17-19: CRITICAL: @vitejs/plugin-react@^4.7.0 is incompatible with vite@^6.4.0.@vitejs/plugin-react version 5.0.4 is the latest release, and version 4.x does not declare Vite 6 in its peer dependencies. This configuration will cause strict peer-dependency resolution failures under pnpm with the message:
peer vite@"^4 || ^5"violates the specifiedvite@^6.4.0.Please upgrade @vitejs/plugin-react to a Vite 6-compatible version (e.g.,
^5.0.0).- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/devtools-panel/package.json (1)
17-19: @vitejs/plugin-react 4.x incompatible with Vite 6 peerDependencies.
@vitejs/plugin-react@^4.7.0declares peer dependency onvite@^4 || ^5, but this file specifiesvite@^6.4.0. This mismatch will cause pnpm peer-dependency resolution failures during install. Upgrade the plugin to a Vite-6-compatible version.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/react/star-wars/package.json (1)
19-23: @vitejs/plugin-react 4.x incompatible with Vite 6.
@vitejs/plugin-react@^4.7.0does not support Vite 6; it declares peer dependency onvite@^4 || ^5only. Withvite@^6.4.0specified on line 23, this will cause installation failures. Upgrade the plugin to v5.x.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/angular/infinite-query-with-max-pages/package.json (1)
12-25: TypeScript 5.8.3 incompatible with Angular 20.3.6 peer requirements.Angular 20.3.6 requires TypeScript >=5.9.0 <6.0.0, but line 25 pins
typescriptto5.8.3. Peer dependency violation will cause resolution/build failures.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/query-options-from-a-service/package.json (1)
12-26: TypeScript 5.8.3 incompatible with Angular 20.3.6 peer requirements.Angular 20.3.6 requires TypeScript >=5.9.0 <6.0.0, but line 26 pins
typescriptto5.8.3. This violates the peer dependency constraint and will fail dependency resolution. Past review comment indicates this should have been addressed, but the version remains incompatible.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/basic/package.json (1)
12-25: TypeScript 5.8.3 incompatible with Angular 20.3.6 peer requirements.Angular 20.3.6 requires TypeScript >=5.9.0 and <6.0.0, but line 25 pins
typescriptto5.8.3. This violates the peer dependency constraint. Update to a compatible version.- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/devtools-panel/package.json (1)
12-26: TypeScript 5.8.3 incompatible with Angular 20.3.x—update or this PR will fail peer dependency checks.Angular 20.3.x requires TypeScript >=5.9.0 <6.0.0. With TS pinned at 5.8.3, the install will fail with a peer dependency conflict (pnpm strict enforcement). This issue was flagged in a previous review on this PR but remains unresolved.
Update TypeScript to a compatible range:
- "typescript": "5.8.3" + "typescript": "^5.9.0"Then run
npm install(or your package manager equivalent) to update the lockfile.examples/react/react-router/package.json (1)
26-28: @vitejs/plugin-react@^4.7.0 incompatible with Vite ^6.4.0—update plugin or this PR will fail peer dependency checks.@vitejs/plugin-react ^4.7.0 only supports Vite ^4.2.0 || ^5.0.0 and does not declare support for Vite 6.x. With pnpm's strict peer enforcement, the install will fail. This issue was flagged in a previous review on this PR but remains unresolved.
Bump @vitejs/plugin-react to the first release that supports Vite 6:
- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",Then run
npm install(or your package manager equivalent) to update the lockfile.examples/angular/simple/package.json (1)
12-25: TypeScript 5.8.3 incompatible with Angular 20.3.x—update or this PR will fail peer dependency checks.Angular 20.3.x requires TypeScript >=5.9.0 <6.0.0. With TS pinned at 5.8.3, the install will fail with a peer dependency conflict (pnpm strict enforcement). This same issue was flagged in a previous review on this PR for examples/angular/devtools-panel.
Update TypeScript to a compatible range:
- "typescript": "5.8.3" + "typescript": "^5.9.0"Then run
npm install(or your package manager equivalent) to update the lockfile.package.json (1)
8-8:⚠️ Duplicate concern: CI workflows must enforce [email protected].This issue was already flagged in a previous review comment. The
packageManagerfield alone doesn't enforce the pnpm version in CI environments. Ensure that.github/workflows/*.ymlincludes either:
- A run step:
corepack enable && corepack use [email protected](before pnpm commands)- Or the
pnpm/action-setup@v2action withversion: "10.18.3"This prevents lockfile version mismatches between local and CI environments.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/react/eslint-legacy/package.json
- examples/react/playground/package.json
🚧 Files skipped from review as they are similar to previous changes (52)
- examples/vue/nuxt3/package.json
- packages/react-query-devtools/package.json
- examples/react/simple/package.json
- packages/solid-query-devtools/package.json
- examples/react/rick-morty/package.json
- examples/angular/router/package.json
- examples/react/shadow-dom/package.json
- packages/vue-query/package.json
- examples/react/basic-graphql-request/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/chat/package.json
- packages/svelte-query/package.json
- examples/svelte/simple/package.json
- packages/query-core/package.json
- packages/query-persist-client-core/package.json
- examples/vue/persister/package.json
- examples/react/basic/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/rxjs/package.json
- packages/vue-query-devtools/package.json
- examples/vue/basic/package.json
- integrations/vue-vite/package.json
- examples/react/offline/package.json
- packages/react-query/package.json
- integrations/svelte-vite/package.json
- examples/vue/2.7-basic/package.json
- examples/angular/auto-refetching/package.json
- examples/svelte/optimistic-updates/package.json
- integrations/solid-vite/package.json
- examples/vue/dependent-queries/package.json
- examples/react/suspense/package.json
- examples/solid/simple/package.json
- examples/react/react-native/package.json
- packages/solid-query/package.json
- integrations/react-webpack-5/package.json
- examples/vue/simple/package.json
- integrations/react-next-15/package.json
- examples/svelte/star-wars/package.json
- packages/query-async-storage-persister/package.json
- examples/vue/2.6-basic/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/ssr/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/pagination/package.json
- integrations/angular-cli-20/package.json
- examples/angular/basic-persister/package.json
- examples/solid/astro/package.json
- packages/svelte-query-devtools/package.json
- packages/svelte-query-persist-client/package.json
- examples/angular/optimistic-updates/package.json
- packages/query-test-utils/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/react-query-next-experimental/package.jsonintegrations/react-vite/package.jsonpackages/solid-query-persist-client/package.jsonpackages/angular-query-experimental/package.jsonpackages/react-query-persist-client/package.jsonpackages/angular-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Test
- GitHub Check: Preview
- GitHub Check: autofix
🔇 Additional comments (12)
examples/solid/default-query-function/package.json (1)
13-13: Solid example dependencies look good.No peer-dependency conflicts detected in this Solid.js example. The vite, solid-js, and vite-plugin-solid updates are consistent.
Also applies to: 17-18
examples/solid/solid-start-streaming/package.json (1)
14-14: Solid-Start streaming example is consistent.No peer-dependency conflicts. The version bumps for SolidStart, solid-js, and vinxi are appropriate.
Also applies to: 17-18
examples/solid/basic/package.json (1)
13-13: Solid basic example is consistent.Version updates are appropriate for the Solid.js ecosystem.
Also applies to: 17-18
examples/svelte/basic/package.json (1)
17-23: Svelte ecosystem updates look good.All version bumps are minor/patch increments within compatible ranges. No peer dependency conflicts detected.
packages/solid-query-persist-client/package.json (1)
73-76: Solid.js ecosystem updates are compatible.These are routine minor/patch increments with no peer dependency conflicts or breaking changes expected.
integrations/react-webpack-4/package.json (1)
14-21: Webpack 4 integration tooling updates are compatible.Babel and webpack-cli versions align with the existing Webpack 4 setup. No incompatibilities detected.
packages/react-query-persist-client/package.json (1)
64-72: Package updates look safe.The dependency bumps are compatible and properly aligned with workspace references. The Vite plugin version (^4.7.0) is suitable for a library package that uses Vite for dev tooling without runtime bundling concerns.
packages/angular-query-experimental/package.json (1)
92-102: Package updates are compatible and well-aligned.Angular dependencies satisfy peer constraints, testing/linting tooling updated safely, and build plugins are properly configured. No peer dependency conflicts detected.
packages/angular-query-persist-client/package.json (1)
60-70: Package updates are compatible and properly scoped to devDependencies.Angular framework, testing libraries, and tooling all updated safely. Peer dependencies satisfied and no conflicts detected.
packages/query-devtools/package.json (1)
67-80: Solid.js ecosystem updates are well-coordinated and safe.All component library, utility, and build tool versions updated consistently within safe ranges. No peer dependency conflicts or breaking changes.
packages/eslint-plugin-query/package.json (1)
62-69: TypeScript-ESLint and ESLint updates are properly aligned.All @typescript-eslint packages updated to consistent version (8.46.1), and ESLint upgraded within supported peer range (^8.57.0 || ^9.0.0). No conflicts or compatibility issues.
package.json (1)
43-81: Review devDependency updates for breaking changes.Most updates are minor/patch versions (safe). However, verify compatibility for:
@arethetypeswrong/cli: ^0.15.3 → ^0.18.2 — Pre-1.0 version jump; confirm no breaking changes in 0.18.x.tinyglobby&tsup(new entries) — Confirm these are properly integrated into build scripts or configuration files. The additions suggest toolchain updates; verify they're used and configured correctly.- TypeScript versions (typescript50–typescript57) — Good practice for multi-version testing; confirm the test infrastructure actually runs against these versions.
| }, | ||
| "dependencies": { | ||
| "@algolia/client-search": "5.2.1", | ||
| "@algolia/client-search": "5.40.1", |
There was a problem hiding this comment.
CRITICAL: @vitejs/plugin-react@^4.7.0 is incompatible with vite@^6.4.0.
Same peer-dependency conflict as other React examples in this PR. Upgrade @vitejs/plugin-react to a Vite 6-compatible version.
Separately, the @algolia/client-search version bump looks good.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",Also applies to: 21-21, 23-23
🤖 Prompt for AI Agents
In examples/react/algolia/package.json around lines 11, 21 and 23, the
dependency @vitejs/plugin-react@^4.7.0 is incompatible with vite@^6.4.0; update
the @vitejs/plugin-react entry to a Vite 6–compatible release (e.g. bump to a
^5.x or the plugin version that declares peer support for vite@^6), modify all
occurrences on the referenced lines to the chosen compatible version, and run
npm/yarn install to regenerate lockfile and verify the peer-dependency conflict
is resolved.
| "@sveltejs/adapter-auto": "^6.1.1", | ||
| "@sveltejs/kit": "^2.47.1", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "svelte": "^5.39.3", | ||
| "svelte-check": "^4.3.1", | ||
| "svelte": "^5.40.2", | ||
| "svelte-check": "^4.3.3", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.3.6" | ||
| "vite": "^6.4.0" |
There was a problem hiding this comment.
CRITICAL: @sveltejs/[email protected] requires vite@^5.x, not ^6.4.0.
SvelteKit 2 requires minimum dependency versions including @sveltejs/vite-plugin-svelte@3. However, @sveltejs/[email protected] declares a peer dependency on vite@^5.x, which conflicts with the specified vite@^6.4.0 in this file. This will cause installation failures under pnpm's strict peer-dependency resolution.
Either upgrade @sveltejs/kit to a Vite 6-compatible version, or downgrade vite to ^5.x.
🤖 Prompt for AI Agents
In examples/svelte/playground/package.json around lines 15 to 21, the specified
vite version (^6.4.0) conflicts with @sveltejs/[email protected] which requires
vite@^5.x; update the file to resolve the peer dependency by either upgrading
@sveltejs/kit to a Vite 6-compatible release or, simpler, downgrade the vite
entry to a 5.x range (e.g., "vite": "^5.x") and ensure
@sveltejs/vite-plugin-svelte remains compatible with that Vite version before
reinstalling dependencies.
| "@tanstack/react-query": "workspace:*", | ||
| "@tanstack/react-query-devtools": "workspace:*", | ||
| "@vitejs/plugin-react": "^4.3.4", | ||
| "@vitejs/plugin-react": "^4.7.0", |
There was a problem hiding this comment.
CRITICAL: @vitejs/plugin-react@^4.7.0 violates Vite 6 peer requirements.
This critical issue was flagged in multiple previous reviews but remains unaddressed. @vitejs/plugin-react version 5.0.4 is the latest and supports Vite 6, whereas version 4.x does not. Strict peer-dependency resolution (enabled by default in pnpm) will fail.
Upgrade to @vitejs/plugin-react@^5.0.0 to resolve the peer-dependency conflict.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",Also applies to: 14-14
🤖 Prompt for AI Agents
In integrations/react-vite/package.json around lines 11 (and also line 14), the
dependency "@vitejs/plugin-react": "^4.7.0" violates Vite 6 peer requirements;
update the package.json to use "@vitejs/plugin-react": "^5.0.0" (or "^5.0.4") to
meet Vite 6 peer deps, run the package manager (pnpm install) to update the
lockfile, and verify build/start succeeds with Vite 6.
| "@tanstack/react-query": "workspace:*", | ||
| "@types/react": "^19.0.1", | ||
| "@vitejs/plugin-react": "^4.3.4", | ||
| "@vitejs/plugin-react": "^4.7.0", |
There was a problem hiding this comment.
CRITICAL: @vitejs/plugin-react@^4.7.0 is incompatible with Vite 6.
The workspace is updating to vite@^6.4.0, but @vitejs/[email protected] only peers on vite@^4 || ^5. This will cause peer-dependency resolution failures. Upgrade the plugin to a Vite 6-compatible version.
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",Also applies to: 63-63
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
8b44964 to
0ab9a68
Compare
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
0ab9a68 to
9a02864
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (12)
packages/vue-query-devtools/package.json (1)
57-60: [DUPLICATE] Align@vitejs/plugin-vuewith Vite 6.This issue was previously flagged and remains unresolved. Line 57 has
@vitejs/plugin-vuepinned to ^5.2.4 while line 60 updates Vite to ^6.4.0. The plugin major version must match Vite's major: plugin 5.x targets Vite 5, plugin 6.x targets Vite 6. This mismatch causes peer dependency conflicts at install time.Update the plugin to ^6.0.0 or higher, or revert Vite to a 5.x version.
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",integrations/vue-vite/package.json (1)
13-15: [DUPLICATE] Upgrade@vitejs/plugin-vueto the Vite 6-compatible major.This issue was previously flagged and remains unresolved. Line 13 pins
@vitejs/plugin-vueto ^5.2.4 while line 15 updates Vite to ^6.4.0. Plugin major versions must align with Vite majors (5.x for Vite 5, 6.x for Vite 6). This peer dependency mismatch breaks npm install and development workflows.Update the plugin to ^6.0.0 or higher, or downgrade Vite to a 5.x version.
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",examples/vue/persister/package.json (1)
19-21: [DUPLICATE] Align@vitejs/plugin-vuewith Vite 6.This issue was previously flagged and remains unresolved. Line 19 pins
@vitejs/plugin-vueto ^5.2.4 while line 21 updates Vite to ^6.4.0. The plugin major version must track Vite's major (5.x for Vite 5, 6.x for Vite 6). This peer dependency mismatch causes install errors and build failures.Update the plugin to ^6.0.0 or higher, or downgrade Vite to a 5.x version.
- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",examples/react/eslint-legacy/package.json (1)
23-25: [DUPLICATE] Bump@vitejs/plugin-reactfor Vite 6 compatibility.This issue was previously flagged and remains unresolved. Line 23 pins
@vitejs/plugin-reactto ^4.7.0 while line 25 updates Vite to ^6.4.0. Plugin version 4.x targets Vite 4.x (peer dependency), version 5.x targets Vite 5.x, and version 6.x targets Vite 6.x. This major version mismatch (two versions apart) breaks npm install and prevents the dev server from running.Update the plugin to ^5.0.0 or ^6.0.0 (whichever supports Vite 6), or revert Vite to a 4.x version.
- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/vue/dependent-queries/package.json (1)
15-17: CRITICAL: @vitejs/plugin-vue@^5.2.4 requires vite@^5.x, not ^6.4.0—peer-dependency mismatch.
@vitejs/plugin-vue@^5.2.4(Line 15) declares a peer dependency onvite@^5, butvite@^6.4.0(Line 17) is outside that range. This will fail pnpm strict peer checks.Upgrade
@vitejs/plugin-vueto^6(Vite 6-compatible) or downgradeviteto^5.x.- "@vitejs/plugin-vue": "^5.2.4", + "@vitejs/plugin-vue": "^6.0.0",Or alternatively:
- "vite": "^6.4.0" + "vite": "^5.4.0"integrations/react-vite/package.json (1)
11-14: CRITICAL: @vitejs/plugin-react@^4.7.0 is incompatible with vite@^6.4.0—this is an unresolved blocker flagged multiple times.
@vitejs/plugin-react@^4.7.0declares peersvite@^4 || ^5only. Pairing it withvite@^6.4.0(Line 14) will fail pnpm's strict peer-dependency resolution and warn in npm/yarn.Upgrade
@vitejs/plugin-reactto^5.0.0or later, which supports Vite 6.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",examples/angular/pagination/package.json (1)
12-25: CRITICAL: TypeScript 5.8.3 does not satisfy Angular 20.3.6 requirements (TS ≥5.9.0).Angular 20.3.6 (Lines 12–24) requires TypeScript ≥5.9.0 <6.0.0, but Line 25 pins
[email protected]. This version is too old and will cause build/type-check failures.Update TypeScript to at least 5.9.0:
- "typescript": "5.8.3" + "typescript": "^5.9.0"examples/angular/infinite-query-with-max-pages/package.json (1)
12-15: Bump TypeScript to ≥5.9.0 to satisfy Angular 20.3.6 peer requirements.Angular 20.3.6 requires TypeScript ≥5.9.0 <6.0.0, but Line 25 pins TypeScript to 5.8.3, which falls below this range. This will cause peer dependency violations and build failures.
Update TypeScript to a compatible version:
- "typescript": "5.8.3" + "typescript": "^5.9.0"After updating, run
pnpm install(or your package manager) to regenerate the lock file.Also applies to: 19-19, 22-24
integrations/angular-cli-20/package.json (1)
11-20: Bump TypeScript to ≥5.9.0 to satisfy Angular 20.3.6 peer requirements.Angular CLI/build 20.3.6 requires TypeScript ≥5.9.0 <6.0.0. Line 26 pins TypeScript to ~5.8.2, which is below the minimum supported version. This will trigger peer dependency warnings and potential build failures.
Update TypeScript to a compatible range:
- "typescript": "~5.8.2" + "typescript": "~5.9.0"After updating, run
pnpm installto regenerate the lock file and verify the build succeeds locally.Also applies to: 26-26
examples/angular/query-options-from-a-service/package.json (1)
12-16: Bump TypeScript to ≥5.9.0 to satisfy Angular 20.3.6 peer requirements.Angular 20.3.6 requires TypeScript ≥5.9.0 <6.0.0, but Line 26 pins TypeScript to 5.8.3, which violates this requirement. This will cause peer dependency errors and build failures.
Update TypeScript to a supported range:
- "typescript": "5.8.3" + "typescript": "^5.9.0"Then run
pnpm installto regenerate the lock file.Also applies to: 20-20, 23-25
examples/angular/rxjs/package.json (1)
12-16: Bump TypeScript to ≥5.9.0 to satisfy Angular 20.3.6 peer requirements.Angular 20.3.6 requires TypeScript ≥5.9.0 <6.0.0, but Line 26 pins TypeScript to 5.8.3, which is incompatible. This will trigger peer dependency violations and build failures.
Update TypeScript to a compatible version:
- "typescript": "5.8.3" + "typescript": "^5.9.0"Run
pnpm installto regenerate the lock file and verify builds succeed.Also applies to: 20-20, 23-25
package.json (1)
8-8: Duplicate concern: pnpm 10.18.3 in packageManager requires CI enforcement.This is a continuation of the previous review's critical issue: updating
packageManagerto pnpm 10.18.3 alone does not guarantee CI uses this version. pnpm 10.18.3 includes a bugfix for infinite recursion when using verifyDepsBeforeInstall with pre/post install scripts, but CI workflows must explicitly pin the version to avoid lockfile mismatches.The past review flagged that
.github/workflows/*.ymlhad nocorepack enable/useorpnpm/action-setupsetup. If CI workflows are part of this PR, ensure they runcorepack enable && corepack use [email protected]or use thepnpm/action-setup@v2action.
🧹 Nitpick comments (1)
packages/react-query-devtools/package.json (1)
86-89: @vitejs/plugin-react@^4.7.0 may need alignment with broader Vite 6 transition.This file updates
@testing-library/reactandnpm-run-all2cleanly. However, Line 88 specifies@vitejs/plugin-react@^4.7.0. While this file doesn't explicitly listviteas a dependency, the broader PR shows vite ^6.4.0 being adopted. Consider upgrading the plugin to^5.0.0for future compatibility or consistency across devtools/examples, even if no immediate peer conflict exists here.- "@vitejs/plugin-react": "^4.7.0", + "@vitejs/plugin-react": "^5.0.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (79)
examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (53)
- examples/react/chat/package.json
- examples/react/basic-graphql-request/package.json
- packages/solid-query/package.json
- examples/vue/2.7-basic/package.json
- packages/query-async-storage-persister/package.json
- packages/svelte-query/package.json
- examples/react/playground/package.json
- packages/query-persist-client-core/package.json
- examples/solid/simple/package.json
- packages/vue-query/package.json
- examples/vue/nuxt3/package.json
- packages/solid-query-persist-client/package.json
- examples/react/devtools-panel/package.json
- examples/react/basic/package.json
- packages/solid-query-devtools/package.json
- examples/angular/basic/package.json
- examples/svelte/simple/package.json
- examples/vue/simple/package.json
- examples/react/offline/package.json
- examples/react/simple/package.json
- examples/angular/router/package.json
- packages/react-query-next-experimental/package.json
- integrations/react-webpack-4/package.json
- examples/svelte/optimistic-updates/package.json
- packages/query-core/package.json
- examples/angular/basic-persister/package.json
- integrations/solid-vite/package.json
- examples/svelte/ssr/package.json
- integrations/react-next-15/package.json
- packages/svelte-query-persist-client/package.json
- examples/react/shadow-dom/package.json
- integrations/react-webpack-5/package.json
- examples/react/suspense/package.json
- examples/svelte/auto-refetching/package.json
- examples/react/algolia/package.json
- examples/vue/basic/package.json
- packages/query-devtools/package.json
- examples/vue/2.6-basic/package.json
- examples/solid/basic/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/angular-query-persist-client/package.json
- packages/svelte-query-devtools/package.json
- examples/react/star-wars/package.json
- examples/angular/simple/package.json
- examples/angular/optimistic-updates/package.json
- packages/react-query-persist-client/package.json
- examples/react/react-router/package.json
- examples/angular/auto-refetching/package.json
- packages/react-query/package.json
- examples/angular/devtools-panel/package.json
- examples/solid/default-query-function/package.json
- examples/svelte/star-wars/package.json
- examples/react/default-query-function/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/vue-query-devtools/package.jsonpackages/react-query-devtools/package.jsonpackages/angular-query-experimental/package.jsonpackages/query-sync-storage-persister/package.jsonpackages/query-broadcast-client-experimental/package.jsonintegrations/react-vite/package.jsonexamples/solid/basic-graphql-request/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (13)
packages/query-test-utils/package.json (1)
38-38: LGTM!Patch bump for npm-run-all2 is safe and non-breaking.
packages/query-sync-storage-persister/package.json (1)
67-67: LGTM!Patch bump for npm-run-all2 is safe and non-breaking.
examples/vue/persister/package.json (1)
15-15: LGTM!Patch bump for idb-keyval is safe and non-breaking.
examples/svelte/basic/package.json (1)
17-23: LGTM!All devDependency updates are within safe ranges (minor/patch versions). @sveltejs/kit and svelte track together appropriately, and the vite 6.4.0 minor bump is compatible.
examples/solid/solid-start-streaming/package.json (1)
14-18: LGTM!All dependency updates are within safe ranges (minor/patch versions). @solidjs/start and solid-js track together appropriately, and vinxi patch bumps are non-breaking.
examples/solid/astro/package.json (1)
15-22: Astro and Solid dependencies updated cleanly.The updates to Astro integrations, Solid.js, and Tailwind CSS look appropriate with no apparent peer-dependency conflicts.
examples/solid/basic-graphql-request/package.json (1)
13-20: Dependency updates are compatible; no issues found.[email protected] supports Vite 6, so there are no peer-dependency concerns. The updates to graphql, graphql-request, and vite are all compatible and reasonable.
examples/svelte/playground/package.json (1)
15-21: The review comment is incorrect. @sveltejs/[email protected] supports Vite 6.SvelteKit 2.47.1 updates peer-dependency compatibility so SvelteKit works with Vite 6. The code's dependency versions are compatible:
- @sveltejs/kit@^2.47.1 ✓ (Vite 6 compatible)
- @sveltejs/vite-plugin-svelte@^5.1.1 ✓ (Vite 6 compatible)
- vite@^6.4.0 ✓
There is no peer dependency conflict and pnpm strict peer-dependency checks will not fail.
packages/query-broadcast-client-experimental/package.json (1)
62-62: Approved: Straightforward tooling version bumps.These are all non-major version increments (patch and minor) for testing and build tooling. No compatibility concerns identified.
Also applies to: 65-67
integrations/svelte-vite/package.json (1)
12-13: Approved: Minor version bumps for framework and build tooling.Svelte and Vite minor updates are within the same major version ranges. No compatibility concerns.
packages/angular-query-experimental/package.json (1)
92-95: Approved: Consistent minor version bumps for Angular and tooling.All changes are non-major increments (patch and minor) for Angular dev dependencies and build tooling. The broad Angular peer dependency range (≥16.0.0) is satisfied by ^20.3.6 without issues.
Also applies to: 97-102
packages/eslint-plugin-query/package.json (1)
62-69: ✓ ESLint tooling updates look good.Minor/patch version bumps for @typescript-eslint packages, eslint, and npm-run-all2 are low-risk and align with the non-major update scope. The caret ranges permit these updates without breaking changes.
package.json (1)
43-80: ✓ devDependencies updates are safe non-major bumps.All updates span patch/minor versions (e.g., @arethetypeswrong/cli ^0.15.3→^0.18.2, eslint ^9.36.0→^9.38.0, nx 21.5.3→21.6.5, vite ^6.3.6→^6.4.0) within the non-major scope of this batched update PR. No vulnerabilities found in pnpm 10.18.x, and no direct vulnerabilities reported for this package in Snyk's vulnerability database. Caret ranges permit these updates without breaking changes.
| "expo": "^52.0.47", | ||
| "expo-constants": "^17.1.7", | ||
| "expo-status-bar": "^2.2.3", |
There was a problem hiding this comment.
🧩 Analysis chain
Block: React Native 0.82 is incompatible with Expo SDK 52.
Expo SDK 52 bundles React Native 0.76/0.77 only (0.77 is opt-in via SDK 52.1+). Upgrading to React Native ^0.82.0 will break Metro bundling and native builds in the managed workflow. This must be resolved before merging.
Choose one approach:
-
Upgrade to Expo SDK that targets RN 0.82: Update Expo and all Expo packages together to the SDK version that supports RN 0.82, then update the RN ecosystem packages (gesture-handler, reanimated, screens, safe-area, web) to compatible versions. Finally, run
expo doctorto confirm alignment. -
Revert RN stack to SDK 52-compatible versions: Downgrade React Native to 0.76 or 0.77, and revert all React-Native-* packages to SDK 52-compatible versions. Then run
expo doctorto verify.
After making changes, run:
Also applies to: 23-29
🏁 Script executed:
#!/bin/bash
# Verify Expo and React Native compatibility
cd examples/react/react-native
expo doctor
npm installLength of output: 1843
Now let me check the actual package.json to see if this compatibility issue still exists in the code:
Based on my verification of official Expo and React Native documentation:
Review comment is correct. Expo SDK 52 includes React Native 0.76. The update to React Native 0.82 is not compatible with SDK 52 which only supports React Native 0.76 (default) and 0.77 (opt-in). React Native 0.82 is available only as part of expo@canary releases, and the next stable SDK (SDK 55) will ship with React Native 0.83.
The npm install succeeded, but this only validates dependency resolution—not runtime compatibility. The actual issue will manifest during Metro bundling and native builds.
🤖 Prompt for AI Agents
examples/react/react-native/package.json lines 19-21: the project lists Expo SDK
52 but uses React Native 0.82 (incompatible); change dependencies so React
Native matches the Expo SDK (use RN 0.76 or opt-in 0.77 for SDK 52) or upgrade
Expo to a release that supports RN 0.82 (canary or wait for SDK 55), then run
npm/yarn install and verify Metro bundling and native builds; update
package.json accordingly and re-run the native build to confirm runtime
compatibility.
| "@vitejs/plugin-react": "^4.3.4", | ||
| "tailwindcss": "^4.1.13", | ||
| "@tailwindcss/vite": "^4.1.14", | ||
| "@vitejs/plugin-react": "^4.7.0", |
There was a problem hiding this comment.
CRITICAL: @vitejs/plugin-react@^4.7.0 incompatible with vite@^6.4.0.
@vitejs/plugin-react@^4.7.0 (Line 20) peers only vite@^4 || ^5, but vite@^6.4.0 (Line 23) is outside that range. This will fail pnpm strict peer checks.
Upgrade @vitejs/plugin-react to ^5.0.0 or later (Vite 6-compatible).
- "@vitejs/plugin-react": "^4.7.0",
+ "@vitejs/plugin-react": "^5.0.0",Also applies to: 23-23
🤖 Prompt for AI Agents
In examples/react/rick-morty/package.json around lines 20 and 23,
@vitejs/plugin-react@^4.7.0 (line 20) is incompatible with vite@^6.4.0 (line 23)
because the plugin peers only vite@^4 || ^5; update the plugin to a Vite
6‑compatible version (e.g., "^5.0.0" or later) in package.json so the peer range
matches Vite 6, then run pnpm install (or pnpm update) to refresh the lockfile
and verify pnpm strict peer checks pass.
1 participant
This PR contains the following updates:
5.2.1->5.40.1^20.0.0->^20.3.6^20.0.0->^20.3.6^20.0.0->^20.3.6^20.0.0->^20.3.6^20.0.0->^20.3.6^20.0.0->^20.3.6^20.0.0->^20.3.6^20.0.0->^20.3.6^20.0.0->^20.3.6^20.0.0->^20.3.6^0.15.3->^0.18.2^5.0.7->^5.1.1^8.1.3->^8.2.10^7.26.0->^7.28.4^7.24.9->^7.28.4^7.26.0->^7.28.3^7.25.9->^7.27.1^2.29.5->^2.29.7^2.0.1->^2.2.2^10.0.5->^10.0.11^0.4.4->^0.5.1^0.13.4->^0.13.11^1.2.2->^1.5.2^2.0.26->^2.1.3^1.1.3->^1.2.0^6.1.0->^6.1.1^2.42.2->^2.47.1^2.4.0->^2.5.4^4.1.13->^4.1.14^4.0.14->^4.1.14^0.20.2->^0.22.0^5.90.2->^5.90.5^18.0.0->^18.1.0^10.4.0->^10.4.1^6.8.0->^6.9.1^16.1.0->^16.3.0^2.0.0->^2.0.1^5.0.4->^5.0.5^8.44.1->^8.46.1^8.44.1->^8.46.1^8.44.1->^8.46.1^4.3.4->^4.7.0^5.2.1->^5.2.4^1.1.36->^1.3.23^6.6.3->^6.6.4^8.3.0->^8.4.1^7.0.0->^7.1.0^9.36.0->^9.38.0^50.5.0->^50.8.0^3.11.0->^3.12.4^10.5.0->^10.5.1^1.2.1->^1.2.2^52.0.11->^52.0.47^17.0.3->^17.1.7^2.0.0->^2.2.3^2.1.16->^2.1.18^16.9.0->^16.11.0^7.1.2->^7.3.0^5.6.3->^5.6.4^6.2.1->^6.2.2^27.0.0->^27.0.1^5.63.1->^5.66.0^2.6.6->^2.11.5^5.0.0->^5.0.2^3.12.4->^3.19.321.5.3->21.6.510.17.0->10.18.3^0.3.13->^0.3.14^2.5.2->^2.6.0^0.76.3->^0.82.0^2.20.2->^2.28.0^5.12.5->^5.14.5^3.16.2->^3.19.3^4.12.0->^4.14.1^4.1.0->^4.17.1^0.19.13->^0.21.2^6.25.1->^6.30.1^6.25.1->^6.30.1^8.0.0->^8.4.0~7.8.0->~7.8.2^1.9.7->^1.9.9^0.2.3->^0.3.0^5.39.3->^5.41.0^4.3.1->^4.3.3^4.1.13->^4.1.14^3.4.7->^3.4.18^4.0.14->^4.1.14^2.3.0->^2.8.1^0.5.3->^0.5.8^6.3.6->^6.4.04.2.3->4.5.4^0.9.0->^0.10.0^2.11.6->^2.11.9~0.15.0->~0.15.10.15.0->0.15.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
algolia/algoliasearch-client-javascript (@algolia/client-search)
v5.40.1Compare Source
v5.40.0Compare Source
v5.39.0Compare Source
v5.38.0Compare Source
composition&composition-full(#5333) by @ClaraMullerv5.37.0Compare Source
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit