Skip to content

ci: oidc #9764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ci: oidc #9764

wants to merge 4 commits into from
+26 −1

Conversation

manudeli
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: dc92de6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@tanstack/angular-query-experimental Patch
@tanstack/angular-query-persist-client Patch
@tanstack/eslint-plugin-query Patch
@tanstack/query-async-storage-persister Patch
@tanstack/query-broadcast-client-experimental Patch
@tanstack/query-core Patch
@tanstack/query-devtools Patch
@tanstack/query-persist-client-core Patch
@tanstack/query-sync-storage-persister Patch
@tanstack/query-test-utils Patch
@tanstack/react-query Patch
@tanstack/react-query-devtools Patch
@tanstack/react-query-next-experimental Patch
@tanstack/react-query-persist-client Patch
@tanstack/solid-query Patch
@tanstack/solid-query-devtools Patch
@tanstack/solid-query-persist-client Patch
@tanstack/svelte-query Patch
@tanstack/svelte-query-devtools Patch
@tanstack/svelte-query-persist-client Patch
@tanstack/vue-query Patch
@tanstack/vue-query-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@manudeli manudeli self-assigned this Oct 16, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 16, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit dc92de6

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 38s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-18 23:36:29 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 16, 2025 •
edited
Loading

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9764

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9764

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9764

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9764

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9764

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9764

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9764

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9764

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9764

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9764

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9764

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9764

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9764

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9764

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9764

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9764

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9764

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9764

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9764

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9764

commit: dc92de6

lachlancollins
lachlancollins requested changes Oct 16, 2025
View reviewed changes
Copy link
Member

@lachlancollins lachlancollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't have a changeset, since it doesn't actually affect the content of published packages. This also requires specific settings to be enabled by Tanner on NPM.

@manudeli
Copy link
Collaborator Author

This shouldn't have a changeset, since it doesn't actually affect the content of published packages.

I thought adding a changeset and releasing a new version would still be fine, since switching to OIDC changes the publishing workflow itself — even if the package content doesn’t. It also helps confirm that the new OIDC-based release flow works as expected.

This also requires specific settings to be enabled by Tanner on NPM.

If the release workflow fails, we can just rerun the changeset workflow after Tanner finishes the NPM configuration to verify everything’s working properly. Hopefully that should confirm the setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lachlancollins lachlancollins lachlancollins requested changes

Assignees

@manudeli manudeli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manudeli @lachlancollins