Fixed updateFn doc #202
Merged
Fixed updateFn doc #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViewableGravy
suggested changes
Jun 17, 2025
docs/quick-start.md
Outdated
Comment on lines
39
to
40
| updateFn: (prevValue) => updateValue => { | ||
| return updateValue + prevValue; | ||
| return updateValue(prevValue) + previous; |
There was a problem hiding this comment.
While you are here, given the prevValue is using () arrow function syntax, would it also make sense to define updateValue in () syntax for consistency?
updateFn: (prevValue) => (updateValue) => {
...There was a problem hiding this comment.
@ViewableGravy Done
crutchcorn
approved these changes
Jun 29, 2025
|
View your CI Pipeline Execution ↗ for commit 29369fc.
☁️ Nx Cloud last updated this comment at |
@tanstack/angular-store
@tanstack/react-store
@tanstack/solid-store
@tanstack/store
@tanstack/svelte-store
@tanstack/vue-store
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateValueis a function so can not return function + number. If it's not expected behaviour then we need to fix library.