Skip to content

fix: make solid adapter behave more like how we'd expect #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025

Conversation

crutchcorn
Copy link
Member

This PR migrates us away from solid-js/store and towards shallow selection. It appears to fix some issues we were running into with Form and may even increase performance for our needs

Copy link

nx-cloud bot commented Jul 6, 2025

View your CI Pipeline Execution ↗ for commit 5ec8ab4

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 36s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-06 22:09:11 UTC

Copy link

pkg-pr-new bot commented Jul 6, 2025

@tanstack/angular-store

npm i https://pkg.pr.new/@tanstack/angular-store@214

@tanstack/react-store

npm i https://pkg.pr.new/@tanstack/react-store@214

@tanstack/solid-store

npm i https://pkg.pr.new/@tanstack/solid-store@214

@tanstack/store

npm i https://pkg.pr.new/@tanstack/store@214

@tanstack/svelte-store

npm i https://pkg.pr.new/@tanstack/svelte-store@214

@tanstack/vue-store

npm i https://pkg.pr.new/@tanstack/vue-store@214

commit: 5ec8ab4

@crutchcorn crutchcorn merged commit 4694359 into main Jul 6, 2025
4 checks passed
@crutchcorn crutchcorn deleted the fix-solid-adapter branch July 6, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant