Skip to content

Fixed k8s setup for tandoor 2 #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MyDigitalLife
Copy link

@MyDigitalLife MyDigitalLife commented Jul 31, 2025

I'm running Tandoor in k8s with the default setup described in the documentation. As its not tested i noticed It didn't work after updating to Tandoor 2.

Checking the code the init container has the collectstatic_js_reverse command. The dependency that was needed was removed from the requirements.txt with the upgrade so it worked after removing the command in the init container.

Also added a extra link in the documentation as the location of the files is never disclosed in the documentation. Very confusing.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2025

CLA assistant check
All committers have signed the CLA.

@MeneDev
Copy link

MeneDev commented Aug 1, 2025

Can confirm I have it running like that now.

I haven't followed the v2 development, but isn't nginx now part of the image? A bit unclear to my, why we still need it?
When I look at the diff in 7ccdb90 for the "plain" docker-compose setup, I would expect quite a simplification here as well?

@vabene1111
Copy link
Collaborator

perfect, yes this command is no longer required. @MeneDev is correct, an additional nginx is no longer needed, users will only need a reverse proxy (if they want).

Do you want to review the setup regarding this or should I merge the current state?

Thanks for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants