fix: search by rating filter: <= #4303
Open
+7
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the bug in the recipe search functionality where the <= "lte" rating filter was incorrectly applying >= "gte".
Detailed description
As seen in #4280, searching for recipes with a rating of 3 stars or less would return results for those of 3 stars or more instead. This is incorrect.
The rating filter is defined in
cookbook/helper/recipe_search.pyand the query being run for the "lte" filter was actually the same as the "gte" filter. This fixes the issue. Also re-enable a commented test case that was failing but now passes with this fix, expanding the comment explaining how the test works. This test covers all of the rating filters.File changes:
cookbook/helper/recipe_search.pyrating_filtermethod: correctself._rating_ltecasecookbook/tests/other/test_recipe_full_text_search.pytest_search_count: uncomment the test case for the "lte=3" filter and explain why it worksFixes #4280