Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MT-1504] Refresh and Reload improvements #331

Merged
merged 33 commits into from
May 2, 2024
Merged

[MT-1504] Refresh and Reload improvements #331

merged 33 commits into from
May 2, 2024

Commits on Mar 21, 2024

  1. Make remote commands accept local paths with and without extension de… 

    …finition
    @Enricoza
    Enricoza committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    8eef183 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Use constants for dle and tiq urls

    @Enricoza
    Enricoza committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    79f81e0 View commit details
    Browse the repository at this point in the history

  2. Share a ResourceRetriever and ResourceRefresher for RemoteCommands an… 

    …d RemotePublishSettings

Fix RemoteCommands issues:
- load url remote commands successfully after others have been previously added
- refresh remote commands on interval
- fix cache usage for remote commands
- use etag instead of if-not-modified-since
- safely extract fileName from url
- always use commandId to access different remote commands instead of a mix of commandId and fileName

Add a way for PublishSettings to be retrieved from local bundle

Fix ResourceRetriever to accept all 20x responses as correct
    @Enricoza
    Enricoza committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    3a38bcd View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Add retry mechanism for ResourceRetriever and improve shouldRefresh c… 

    …hecks in ResourceRefresher

Move the should refresh entirely inside of the resource refresher
Move the logging in the delegate calls instead
    @Enricoza
    Enricoza committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    36199bc View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Fix refresh logic with wrong conditions 

    Fix sessionbaseURL with double //
Add delegate call for cached/bundle settings
Fix old tests
    @Enricoza
    Enricoza committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1bb1965 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Remove resource retriever forced refresh when not cached and add back… 

    …off for cooldown Interval
    @Enricoza
    Enricoza committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9abfc7c View commit details
    Browse the repository at this point in the history

  2. Make condition clearer for when to use local bundle RemoteCommand config

    @Enricoza
    Enricoza committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    2cd3b72 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Use commandId instead of filename for remote commands cache and asset… 

    … bundle for url remote commands

Create an internal bundle option just for tests
    @Enricoza
    Enricoza committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0d4dc83 View commit details
    Browse the repository at this point in the history

  2. Reorganize files

    @Enricoza
    Enricoza committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    16fdaf9 View commit details
    Browse the repository at this point in the history

  3. Improve VisitorServiceRetriever urlSession and completion calls

    @Enricoza
    Enricoza committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    44466d1 View commit details
    Browse the repository at this point in the history

  4. Simplify Resource Refresher error handling

    @Enricoza
    Enricoza committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b5955ef View commit details
    Browse the repository at this point in the history

  5. Improve Collect urlSession and Completion calls

    @Enricoza
    Enricoza committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a2f5ce9 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Test ResourceRetriever with a new MockURLSession

    @Enricoza
    Enricoza committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    7af2aad View commit details
    Browse the repository at this point in the history

  2. Fix ResourceRefresher Cooldown logic and add some tests

    @Enricoza
    Enricoza committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    810c7e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Add ResourceRefresher tests and create ErrorCooldown utility to help … 

    …with tests
    @Enricoza
    Enricoza committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e941a4b View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Improve and test ErrorCooldown 

    Make sure that when errorCooldown is nil the normal refreshInterval is used
    @Enricoza
    Enricoza committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    cc14be1 View commit details
    Browse the repository at this point in the history

  2. Remove settings from bundle option

    @Enricoza
    Enricoza committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    62254b1 View commit details
    Browse the repository at this point in the history

  3. Fix old remote commands manager tests

    @Enricoza
    Enricoza committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    104c99f View commit details
    Browse the repository at this point in the history

  4. Fix collect completion

    @Enricoza
    Enricoza committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    2cacf9a View commit details
    Browse the repository at this point in the history

  5. Fix remaining old tests for remote commands 

    Remove MockRemoteCommandsDiskStorage
    @Enricoza
    Enricoza committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    cb3e492 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Add RemoteCommands tests for bundle and refreshes

    @Enricoza
    Enricoza committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9ba0b93 View commit details
    Browse the repository at this point in the history

  2. Fix TagManagement flaky tests

    @Enricoza
    Enricoza committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0fda51a View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Reload webview after session updates

    @Enricoza
    Enricoza committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    ca99430 View commit details
    Browse the repository at this point in the history

  2. Add some documentation and improve isFileCached

    @Enricoza
    Enricoza committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1d92dfe View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Fix comment spacing

    @Enricoza
    Enricoza committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    dfac7bb View commit details
    Browse the repository at this point in the history

  2. Fix inAppPurchase tests

    @Enricoza
    Enricoza committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    eff227e View commit details
    Browse the repository at this point in the history

  3. Improve readability of dynamicTrack and fix mock webview in tests

    @Enricoza
    Enricoza committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a52b0d2 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Try to use M1 mac on CICD

    @Enricoza
    Enricoza committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    89a13c1 View commit details
    Browse the repository at this point in the history

  2. Fix wrong macos specification

    @Enricoza
    Enricoza committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    08c8061 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Reset EccordCooldown counter on non-errors

    @Enricoza
    Enricoza committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a79d1bb View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Make publishsettings tests more reliable

    @Enricoza
    Enricoza committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d7756a5 View commit details
    Browse the repository at this point in the history

  2. Ignore 304 errors from ResourceRetriever in ResourceRefresher's Error… 

    …Cooldown
    @Enricoza
    Enricoza committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    fb1e7f2 View commit details
    Browse the repository at this point in the history

  3. Try to make Autotracking UI tests more reliable on slow CICD

    @Enricoza
    Enricoza committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    073631e View commit details
    Browse the repository at this point in the history