Mt 1480 - Moments API (#334) #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * initial commit of moments api * small fix * WIP * Added tests * Added tests * WIP * switched to new engine response format * swiftlint changes * accepted recommended project changes * swiftlint updates * sample updates * updated consent expiry * fix conflict * updated test schemes * updated imports * updated tvos scheme * Updated surfile * Updates from PR review * Added input field for moments API engine ID * bumped ruby version * Further code review updates * Switched to using MockURLSession from core * Handled missing/null responses from Moments API * Made properties optional to align with visitor profile. Skipped null values * Updated referrer spelling, added package.swift and podspec * fix test build issue * updated test.yml * Updated project and fastlane config * removed destination from test.yml * re-added macOS test scheme * updated test yaml * fixed tests.yaml * fixed tests.yaml * changed simulator destination * changed simulator destination for UI tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MT-1480
Note: there are some tests failing in the CICD environment (Github Actions) due to slow macOS runners. These tests are passing locally, and will be fixed in a future release.