Conversation
ChaeAg
approved these changes
Jan 10, 2024
src/main/java/com/wss/websoso/userNovel/UserNovelInfosResponse.java
Outdated
Show resolved
Hide resolved
ResponseEntity 사용
기존 Optional + if 분기 -> Optional 사용X + orElseThrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
Memo,Platform엔티티에서 Nullable 함이 명시되어 있지 않았기에 옵션을 명시했습니다.
BaseTimeEntityUserNovelInfosResponse of 메서드에서 createdDate를 get하기 위해 @Getter 추가했습니다.
API 구현명세에 맞게, 계층별로 분리하여 구현했습니다.
authroization관련엔드포인트에서 리소스에 접근에 관련한 유저 인가가 이루어지지 않아 추가했습니다.
To Reviewers
[FIX] 서재 작품 목록 조회 API 수정 #35 로 이슈 새로 파서 수정 예정입니다.
인가 관련 고민을 함께 해줘서 고맙습니다 ^_^