Skip to content

Formalise errors, updae to 2025 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 4, 2025
Merged

Formalise errors, updae to 2025 #44

merged 14 commits into from
Jan 4, 2025

Conversation

Astatin3
Copy link
Contributor

@Astatin3 Astatin3 commented Jan 4, 2025

 ▗▄▄▖ ▗▄▖ ▗▖  ▗▖
▐▌   ▐▌ ▐▌▐▛▚▖▐▌
▐▌   ▐▛▀▜▌▐▌ ▝▜▌
▝▚▄▄▖▐▌ ▐▌▐▌  ▐▌(t)

@Astatin3 Astatin3 requested a review from C4llSqin January 4, 2025 21:22
@Astatin3
Copy link
Contributor Author

Astatin3 commented Jan 4, 2025

I just made a change btw.

The unused QueryStatus function is now used, basically as just a function to call to post to ShuffleBoard. It is run every 500ms on a thread started from Robot.java

IDK if that will interfere with anything, but I think it will be good.

Copy link
Collaborator

@C4llSqin C4llSqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I don't know how much of a performance hit creating a new smart dashboard thread would be, we can always move it into robot periotic or increase the sleep.

@C4llSqin C4llSqin merged commit 4df0434 into master Jan 4, 2025
1 check passed
@C4llSqin C4llSqin deleted the formalise branch January 4, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants