update ondemand workflow & fix CI #4241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishnuSanal
changed the title
VishnuSanal
added
the
PR-Awaiting-Initial-Review
|
please revert build failure fixes here |
VishnuSanal
force-pushed
the
ondemand-comment-artifact
branch
from
27aa40d to
1793cad
Compare
|
@VishnuSanal how do I test this? Is this ready? |
yes
please comment on this PR: VishnuSanal#3 (meanwhile, I will fix the CI failures) |
EmmanuelMess
approved these changes
May 15, 2025
EmmanuelMess
added
PR-Awaiting-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
soo, after years of hard work... I have a useless feature working. ;)
this PR updates the ondemand workflow to give the user a heads-up comment with the artifact links