-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form new create #5
base: external_resource_submission
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 😄
How about translations.js
? Does it need to be updated? I noticed that it is in client/.gitignore
🤔
@external_resource = ExternalResource.new external_resources_params | ||
if @external_resource.save | ||
redirect_to new_resource_path, | ||
notice: 'Your suggestion has been submitted!' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need a translation key
{ | ||
id: 999, | ||
name: 'external_resource[languages][]', | ||
label: 'Choose a language', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might need a tranlsation key
@AlineRibeiro It seems |
Description
More Details
Corresponding Issue
Screenshots
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!