Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form new create #5

Open
wants to merge 12 commits into
base: external_resource_submission
Choose a base branch
from

Conversation

AlineRibeiro
Copy link

Description

More Details

Corresponding Issue

Screenshots


Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!

Copy link

@guialbuk guialbuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 😄

How about translations.js? Does it need to be updated? I noticed that it is in client/.gitignore 🤔

app/controllers/resources_controller.rb Outdated Show resolved Hide resolved
@external_resource = ExternalResource.new external_resources_params
if @external_resource.save
redirect_to new_resource_path,
notice: 'Your suggestion has been submitted!'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need a translation key

app/controllers/resources_controller.rb Outdated Show resolved Hide resolved
app/controllers/resources_controller.rb Show resolved Hide resolved
app/helpers/external_resources_form_helper.rb Outdated Show resolved Hide resolved
{
id: 999,
name: 'external_resource[languages][]',
label: 'Choose a language',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need a tranlsation key

client/app/widgets/Resources/index.jsx Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
@guialbuk
Copy link

guialbuk commented Jul 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants