add proxy settings #12691
Open
add proxy settings #12691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
feature request
AudricV
added
the
template ignored
|
Need this feature! |
TobiGr
requested changes
Dec 20, 2025
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Thank you for this PR. Things that need to be taken into account:
- Enabling the proxy in the settings should enable the proxy immediately or prompt the user to restart the app. Currently it looks like the proxy is enabled in the settings UI although it is actually not.
Contributor
There was a problem hiding this comment.
it is a good idea to separate the strings so that strings.xml is not cluttered too much. However, I think this should be done for all strings at the same time in a separate PR. Please make this a section in string.xml for now.
Contributor
There was a problem hiding this comment.
Where does this file come from?
Contributor
|
Proxy for downloads is missing (see DownloadMission#openConnection) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Add proxy settings
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence