Replace Illegal{State,Argument} exceptions with more idiomatic kotlin code #13028
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustdfg
commented
Jan 9, 2026
Comment on lines
95
to
109
| else -> throw IllegalArgumentException("Unknown position for ViewPager2") | ||
| else -> error("Unknown position for ViewPager2") | ||
| } | ||
| } | ||
|
|
||
| override fun getItemCount(): Int { | ||
| // Show 2 total pages. | ||
| return totalCount | ||
| } | ||
|
|
||
| fun getPageTitle(position: Int): Int { | ||
| return when (position) { | ||
| posAbout -> R.string.tab_about | ||
| posLicense -> R.string.tab_licenses | ||
| else -> throw IllegalArgumentException("Unknown position for ViewPager2") | ||
| else -> error("Unknown position for ViewPager2") | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Just formally it replaces IllegalArgumentException with IllegalStateException but the errors by itself are both Argument and State errors. In this PR you can also see that other places like these were using State exception so I think that just using error is appropriate enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence