security: improve state restoration safety #13054
Open
+32
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RinZ27
force-pushed
the
fix/insecure-deserialization
branch
from
8dd6538 to
cd0f07e
Compare
github-actions
bot
added
size/small
AudricV
added
the
template missing
Contributor
Author
|
@AudricV Updated the PR description to follow the required template. Ready for review. |
Member
This template isn't the one you used, the correct one is at https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/PULL_REQUEST_TEMPLATE.md. Please update your pull request description, and do not make use of AI to generate it (see the contribution guidelines). |
AudricV
added
the
waiting for author
Contributor
Author
|
Sorry about the description. I've updated it to be more concise and focused on the technical changes. I'll make sure to follow the guidelines more strictly from now on. |
github-actions
bot
removed
the
waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Moved state saving logic to use the internal cache directory instead of external storage. This prevents other apps from having read/write access to these files, which is better for overall privacy and consistency.
Also introduced a
ValidatingObjectInputStreaminStateSaver.java. It implements a whitelist for deserialization, only allowingjava.lang,java.util, and NewPipe's own classes. This adds a safety layer against potential insecure deserialization when loading stored state.Fixes the following issue(s)
Due diligence