VideoDetailFragment: composfiy views and thumbs chunck#13273
Open
dustdfg wants to merge 1 commit intoTeamNewPipe:refactorfrom
Open
VideoDetailFragment: composfiy views and thumbs chunck#13273dustdfg wants to merge 1 commit intoTeamNewPipe:refactorfrom
dustdfg wants to merge 1 commit intoTeamNewPipe:refactorfrom
Conversation
Contributor
Author
|
Well, this looks more like original view based version then previous PR and uses styles rather than plain fontSizes. I couldn't normally convert channel part so basically it is copy of previous PR with mentioned changes (github didn't let me reopen that PR after forcepush)... |
dustdfg
commented
Feb 21, 2026
| alignment = LineHeightStyle.Alignment.Proportional, | ||
| trim = LineHeightStyle.Trim.LastLineBottom | ||
| ) | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Don't ask me about it. Idk. It helped the text box to be smaller and look more like original view based version. Why, how, idk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence