-
Notifications
You must be signed in to change notification settings - Fork 19
fix thumbnail prevew animation regression #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will take a while to fix, |
|
Mmmh I remember noticing the same issue both with and without #20 but maybe I remember wrongly. Does the problem happen also on an emulator or only in previews? |
|
It happens in preview, the emulator and on device. The title preview isn't the issue though. This PR already delivers a fix for the issue. However additionally I noticed that, #18, made the preview thumbnail position calculation be wrong now. In order to apply my fix right now, we'd have to roll back the chapter thumbnail preview. |
6c95284 to
630d128
Compare
458f941 to
973696d
Compare
|
Ok so I learned today that Please note that I renamed chapter preview text to thumbnail preview text. This way also things like the playback position could be encoded into the text. |
8757dd4 to
f39e407
Compare
…apter can be shown
f39e407 to
cde4b81
Compare
Dear @Stypox when you simplified the ThumbnailPreview you introduced a regression :P. The
getHeight()function as well as theBoxinside theAnimatedVisibilityis necesary to prevent glitches to appear when fading in or out. This is because compose does not seem to be able to calculate the size and position of the thumbnail correctly during animation. For this reason we just animate the whole strip where the thumbnail can move on.With glitches:
with_glitch.webm
Glitches fixed:
glitch_fix.webm