fix: make theater mode toggle button visible on light theme#4143
Open
pierreeurope wants to merge 1 commit intoTeamPiped:masterfrom
Open
fix: make theater mode toggle button visible on light theme#4143pierreeurope wants to merge 1 commit intoTeamPiped:masterfrom
pierreeurope wants to merge 1 commit intoTeamPiped:masterfrom
Conversation
The chevron button to toggle theater mode was invisible on the light theme because it inherited the dark text color while being positioned against the video's dark background. Adding text-white ensures the button is always visible regardless of the selected theme, since it always appears against the dark video background. Fixes TeamPiped#4072 Signed-off-by: pierreeurope <pierre.europe@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The chevron button to toggle theater mode (collapse/expand sidebar) was invisible on the light theme because it inherited the dark text color while being positioned against the video's dark background.
Changes
Added
text-whiteclass to the theater mode toggle button, ensuring it's always visible regardless of the selected theme. Since the button always appears against the dark video player background, white text is appropriate for both light and dark themes.Fixes #4072