fabric 1.20.1 functional port #222
Conversation
I want to do it the right way This reverts commit 3a8a187.
I don't want any legal problems with THAT guy. So I will delete it even on github.
They can't copyright the names of the sounds, don't get me wrong
(finally I can focus on code)
|
Have you confirmed that every single method in AsmHooks gets triggered? |
| @@ -59,75 +65,91 @@ public class ForceFieldBlock extends Block implements SimpleWaterloggedBlock, En | |||
|
|
|||
| public ForceFieldBlock(BlockBehaviour.Properties properties) { | |||
| super(properties); | |||
| this.registerDefaultState(this.getStateDefinition().any().setValue(WATERLOGGED, false) | |||
| this.registerDefaultState(this.getStateDefinition().any().setValue(WATERLOGGED, false).setValue(AXIS, Direction.Axis.Y) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
There's no AXIS property in the forge codebase.
There was a problem hiding this comment.
In fact, this entire class doesn't match at all.
There was a problem hiding this comment.
I guess I decided to use old force fields because I struggled with making the new ones work. I will try it one more time
There was a problem hiding this comment.
There must be full parity with the 1.20.1 forge codebase.
There was a problem hiding this comment.
alright, I guess I will handle that giving that I have more idea of the code base now
The most of them are getting hit, though I will need to check the yellow ones tomorrow (book, lead, cloud, mountFix, getPlayerPOVHitResultForReach, renderMultiparts): |
|
wait a moment.. why is asm using Java.type('net.minecraftforge.coremod.api.ASMAPI') if we are in fabric |
|
bruh was it broken since 1.18 EDIT: I will be inactive for some time, I will let @IAFEnvoy work on this |
No description provided.