[IMP] Allow disabling autoreload on start #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please only one commit per unrelated fix, and check CI. |
david-banon-tecnativa
force-pushed
the
imp-allow_disabling_reload
branch
from
fafa3a5 to
f33ca8e
Compare
carlos-lopez-tecnativa
requested changes
Jul 15, 2025
| @@ -537,14 +537,14 @@ def lint(c, verbose=False): | |||
|
|
|||
|
|
|||
| @task() | |||
| def start(c, detach=True, debugpy=False): | |||
| def start(c, detach=True, debugpy=False, _reload=True): | |||
There was a problem hiding this comment.
Why does the variable name start with an underscore?
Suggested change
| def start(c, detach=True, debugpy=False, _reload=True): | |
| def start(c, detach=True, debugpy=False, reload=True): |
There was a problem hiding this comment.
Reload used to be a python keyword, and the editor highlighted as such, and i didn't like that.
Invoke ignores underscores leding a variable name for arguments, ex this would still be used like --reload and --no-reload on cli.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes color for pre-commit on updatepot
@Tecnativa