make scroll logic more stable

Telefonica · Oct 29, 2024 · 75cea2d · 75cea2d
1 parent 35376e6
commit 75cea2d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/navigation-bar.tsx b/src/navigation-bar.tsx
@@ -465,9 +465,11 @@ const MainNavigationBarDesktopMenu = ({
         // Disable scroll in menu content until height's animation is finished to avoid
         // showing the scrollbar while the menu's container is changing it's height
         setIsMenuContentScrollable(false);
-        const id = setTimeout(() => setIsMenuContentScrollable(true), menuAnimationDuration);
-        return () => clearTimeout(id);
-    }, [openedSection, menuAnimationDuration]);
+        if (isMenuOpen) {
+            const id = setTimeout(() => setIsMenuContentScrollable(true), menuAnimationDuration);
+            return () => clearTimeout(id);
+        }
+    }, [isMenuOpen, openedSection, menuAnimationDuration]);
 
     const columns = sections[openedSection]?.menu?.columns || [];
     const customContent = sections[openedSection]?.menu?.content;