Add automatic download and installation for PAGViewer #2940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements automatic download and installation functionality for PAGViewer. When users click to preview PAG files, the system now detects whether PAGViewer is installed and automatically downloads and installs it if not found.
- Adds cross-platform PAGViewer detection and installation system
- Implements a Qt-based installation dialog with progress tracking
- Integrates installation workflow into the PAG file preview process
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| exporter/src/ui/PAGViewerInstallModel.h/.cpp | New Qt model for installation dialog UI and workflow management |
| exporter/src/platform/win/PlatformHelper.cpp | Enhanced with download path utilities and preview integration |
| exporter/src/platform/win/PAGViewerInstallerWin.cpp | Windows-specific PAGViewer installation logic |
| exporter/src/platform/win/PAGViewerCheck.cpp | Windows registry-based PAGViewer detection |
| exporter/src/platform/mac/PlatformHelper.mm | macOS implementation with NSWorkspace integration |
| exporter/src/platform/mac/PAGViewerInstallerMac.mm | macOS-specific installation handling |
| exporter/src/platform/mac/PAGViewerCheck.mm | macOS bundle-based application detection |
| exporter/src/platform/PlatformHelper.h | Added new platform abstraction functions |
| exporter/src/platform/PAGViewerInstaller.h/.cpp | Cross-platform installer with Qt networking |
| exporter/src/platform/PAGViewerCheck.h | Common interfaces for application detection |
| exporter/assets/qml/PAGViewerInstall.qml | Installation dialog UI implementation |
| exporter/CMakeLists.txt | Added Qt6::Network dependency |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2940 +/- ##
==========================================
- Coverage 77.28% 77.27% -0.01%
==========================================
Files 419 419
Lines 22322 22322
Branches 6425 6425
==========================================
- Hits 17251 17250 -1
- Misses 3795 3796 +1
Partials 1276 1276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shlzxjp
reviewed
Jul 24, 2025
shlzxjp
reviewed
Jul 25, 2025
| InstallResult result; | ||
| std::string errorMessage; | ||
|
|
||
| InstallStatus() = default; |
Comment on lines
+125
to
+127
| return executeInstaller(filePath); | ||
| #else | ||
| return extractAndInstall(filePath); |
There was a problem hiding this comment.
感觉这两个函数也可以合并成一个，在不同的平台上有不同的实现，win上安装exe，mac上解压zip
| QDir(tempDir).removeRecursively(); | ||
| } | ||
|
|
||
| void PAGViewerInstaller::onDownloadProgress(qint64 bytesReceived, qint64 bytesTotal) { |
There was a problem hiding this comment.
看QT的api 文档，bytesTotal是有可能为0和-1的，这里对异常情况处理下
https://doc.qt.io/qt-6/qnetworkreply.html#downloadProgress
Comment on lines
+47
to
+49
| NSString* downloadsPath = [NSString stringWithUTF8String:downloadsPathStr.c_str()]; | ||
| NSString* fullPath = [downloadsPath stringByAppendingPathComponent:@"PAGViewer.dmg"]; | ||
| return [fullPath UTF8String]; |
There was a problem hiding this comment.
这里没必要转NSString，直接使用std::string就可以了
| } | ||
|
|
||
| void AppConfig::addConfig(const std::string& key, const std::string& value) { | ||
| this->platformConfig[key] = value; |
| return info; | ||
| } | ||
|
|
||
| std::vector<PackageInfo> PAGViewerCheck::findSoftwareByName(const std::string& namePattern) { |
There was a problem hiding this comment.
函数名和返回值类型匹配起来，例如：findPackageInfoByName
| } | ||
|
|
||
| static void executePreviewLogic(const std::string& pagFilePath) { |
|
|
||
| static std::string wstringToString(const std::wstring& wstr) { | ||
| if (wstr.empty()) { | ||
| return std::string(); |
| return results.empty() ? PackageInfo() : results[0]; | ||
| } | ||
|
|
||
| std::vector<PackageInfo> PAGViewerCheck::findSoftwareByName(const std::string& namePattern) { |
| return ""; | ||
| } | ||
|
|
||
| static void ExecutePreview(const std::string& pagFilePath) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
点击预览PAG文件时，检测是否安装PAGViewer，如果未安装则自动下载与安装