Skip to content

Comments

feat: webhook事件补充 --story=129476203#613

Merged
dengyh merged 1 commit intoTencentBlueKing:masterfrom
guohelu:master_0224
Feb 25, 2026
Merged

feat: webhook事件补充 --story=129476203#613
dengyh merged 1 commit intoTencentBlueKing:masterfrom
guohelu:master_0224

Conversation

@guohelu
Copy link
Collaborator

@guohelu guohelu commented Feb 24, 2026

Reviewed, transaction id: 74274

# Reviewed, transaction id: 74274
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码审查总结

本次 PR 新增了 webhook 事件功能,整体实现清晰。发现以下需要关注的问题:

⚠️ 关键问题

  • webhook 广播缺少异常处理,若广播失败可能导致主流程异常中断
  • 建议在广播调用处添加 try-except 保护

建议

  • 考虑将 webhook 广播改为异步执行,避免阻塞主流程
  • 统一 webhook 广播的错误处理策略

代码变更符合预期,测试覆盖充分。

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@f2946a9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
bkflow/apigw/views/operate_task.py 50.00% 2 Missing ⚠️
bkflow/apigw/views/release_template.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #613   +/-   ##
=========================================
  Coverage          ?   81.39%           
=========================================
  Files             ?      239           
  Lines             ?    13575           
  Branches          ?        0           
=========================================
  Hits              ?    11049           
  Misses            ?     2526           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dengyh dengyh merged commit 7159608 into TencentBlueKing:master Feb 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants