feat:插件发布时发布描述内容支持读取插件代码库最近提交信息 #12080 #12082
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kzhou991
requested review from
carlyin0801,
irwinsun,
mingshewhe,
randychen2046,
royalhuang,
stubenhuang and
tangruotian
as code owners
carlyin0801
reviewed
Aug 6, 2025
| lateinit var redisOperation: RedisOperation | ||
|
|
||
| @Autowired | ||
| lateinit var atomReleaseService: AtomReleaseServiceImpl |
| } | ||
| val taskConfigMap = parseTaskJsonToMap(taskJson) | ||
| // 检查是否需要使用仓库提交信息作为发布说明 | ||
| val useRepoCommits = taskConfigMap[USE_REPO_COMMITS_FOR_RELEASE_NOTES] as? Boolean ?: false |
There was a problem hiding this comment.
从task.json获取提交信息？没有这么要求啊
| if (!useRepoCommits) { | ||
| return null | ||
| } | ||
| return getGitRecentCommitMessage(userId, codeSrc, branch) |
There was a problem hiding this comment.
应该是用户没有主动填版本信息才需要获取仓库的代码提交记录，另外这个逻辑要封装成公用的
carlyin0801
reviewed
Aug 20, 2025
| @Operation(summary = "根据插件分支获取插件代码库最新提交信息") | ||
| @GET | ||
| @Path("/desk/atom/release/commitMessage/get") | ||
| fun getAtomGitRecentCommitMessage( |
carlyin0801
reviewed
Sep 1, 2025
| @Parameter(description = "userId", required = true) | ||
| @HeaderParam(AUTH_HEADER_USER_ID) | ||
| userId: String, | ||
| @Parameter(description = "分支", required = true) |
There was a problem hiding this comment.
非必填字段应该是required = false
| @Parameter(description = "gitProjectId", required = false) | ||
| @QueryParam("gitProjectId") | ||
| gitProjectId: Long? = null, | ||
| @Parameter(description = "获取提交信息数量(默认读取最近5条)", required = false) |
There was a problem hiding this comment.
这个非空字段又是required = false
| ) | ||
| } | ||
|
|
||
| override fun getStoreGitRecentCommitMessages( |
There was a problem hiding this comment.
改成getRecentGitCommitMessages这个更符合英语特性的名字吧
| gitProjectId: Long?, | ||
| commitNumber: Int | ||
| ): String { | ||
| val accessToken = client.get(ServiceOauthResource::class).gitGet(userId).data?.accessToken |
There was a problem hiding this comment.
commitNumber要做下合法性校验，要限制下大小，比如1到10条，不允许用户无限制拉取
| // 过滤合并提交信息 | ||
| val filteredCommits = commits.filter { commit -> | ||
| !commit.message.isNullOrBlank() && | ||
| !commit.message!!.trimStart().startsWith("Merge ", ignoreCase = true) |
| } | ||
| } | ||
|
|
||
| override fun getStoreGitRecentCommitMessages( |
There was a problem hiding this comment.
getStoreGitRecentCommitMessages这个接口放在repository服务更合适
carlyin0801
reviewed
Sep 1, 2025
| val accessToken = client.get(ServiceOauthResource::class).gitGet(userId).data?.accessToken | ||
| if (accessToken.isNullOrBlank()) { | ||
| logger.warn("User [$userId] has not performed OAUTH authorization. Please authorize first.") | ||
| return "" |
| ).data?.id | ||
|
|
||
| if (projectId == null) { | ||
| return "" |
carlyin0801
reviewed
Sep 8, 2025
| import java.nio.charset.Charset | ||
| import java.nio.file.Files | ||
| import java.time.LocalDateTime | ||
| import java.util.* |
| private val logger = LoggerFactory.getLogger(GitService::class.java) | ||
| private const val MAX_FILE_SIZE = 1 * 1024 * 1024 | ||
| private const val SLEEP_MILLS_FOR_RETRY = 2000L | ||
| private const val MAX_COMMIT_NUMBER = 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.