bug：研发商店插件与流水线关联信息展示不正确 #12307 #12319
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kzhou991
requested review from
carlyin0801,
irwinsun,
mingshewhe,
randychen2046,
royalhuang,
stubenhuang and
tangruotian
as code owners
carlyin0801
reviewed
Oct 16, 2025
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema | ||
|
|
||
| data class PipelineAtomInfo ( |
| startUpdateTime: LocalDateTime? = null, | ||
| endUpdateTime: LocalDateTime? = null | ||
| endUpdateTime: LocalDateTime? = null, | ||
| isCheckTpi: Boolean = true |
There was a problem hiding this comment.
isCheckTpi什么意思，看不懂，另外方法定义的参数太多了
| startUpdateTime: LocalDateTime? = null, | ||
| endUpdateTime: LocalDateTime? = null, | ||
| page: Int? = null, | ||
| pageSize: Int? = null |
There was a problem hiding this comment.
方法定义参数太多，参数太多得封装成对象，另外page和pageSize不要允许传空
|
|
||
| pipelineAtomVersionInfo[key]?.add(atomVersion) | ||
| } | ||
| return allRecords.map { record -> |
There was a problem hiding this comment.
dao不要写这么复杂的逻辑，而且这个逻辑有性能问题。方案是：这个dao方法只分页查出插件对应的流水线信息，在service里面根据当前页的流水线信息批量查出流水线使用的插件的版本（使用失效时间半小时的本地缓存，缓存中有的数据就不要去db查了，没有的数据才去db查）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.