fix:未能正确发送续期通知 #2952
Open
fix:未能正确发送续期通知 #2952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 56558
nannan00
reviewed
Sep 29, 2025
saas/config/celery_app.py
Outdated
| crontab(minute=minute, hour=hour), | ||
| permission_expire_remind.s(tenant_id), | ||
| name=f"periodic_permission_expire_remind_{tenant_id}", | ||
| ) |
Collaborator
There was a problem hiding this comment.
之前注释掉的原因是：存在顺序问题，比如执行 python manage.py xxx 相关命令时，该函数会由于加载文件而被触发，导致报错异常等问题；
原先的设计是想由于该周期任务并不是固定周期，而是从 DB 里读取执行周期后"下发"，但错误使用 celery 的 on_after_finalize 信号，导致加载时被触发；正常这类任务应该是初始化一次即可
正确做法应该是
（1） permission_expire_remind 移动到 apps/tenant 的 tasks 模块下
（2）tenant 模块提供 django command 命令，初始化每个租户的通知任务（实际上就是 执行每个租户的 update_periodic_permission_expire_remind_schedule ）
# Reviewed, transaction id: 59748
yunlong098
force-pushed
the
fix_notifications_not_sent
branch
from
1236ac4 to
2ea302a
Compare
yunlong098
force-pushed
the
fix_notifications_not_sent
branch
from
05a89e5 to
8410b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed, transaction id: 56558
变更点(Changes)
相关issues (Which issues this PR fixes)
备注(Special notes)