feat: Metadata: 索引轮转--强制轮转时,跳过文档数统计,避免超时 --story=128023081 #8456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 60836
EASYGOING45
added
feat
There was a problem hiding this comment.
Pull Request Overview
This PR changes index rotation logic to skip potentially slow document count operations when a force rotation is requested, reducing timeouts.
- Prioritizes the force_rotate branch to avoid calling Elasticsearch count
- Removes the previous elif force_rotate block and adjusts comments/logging accordingly
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+3112
to
+3117
| if force_rotate: # 强制轮转时,直接进行创建 | ||
| new_index = current_index_info["index"] + 1 | ||
| logger.info("update_index_v2:table_id>[%s],index->[%s],will force_rotate", self.table_id, new_index) | ||
| elif (bounded_not_expired_alias_length != 0) and ( | ||
| self.es_client.count(index=last_index_name).get("count", 0) == 0 | ||
| ): | ||
| ): # 7.1 如果last_index存在已经绑定的别名，且其中的数据为空，那么则进行删除重建操作 |
There was a problem hiding this comment.
[nitpick] Reordering the condition changes precedence: when force_rotate is True, the 7.1 'delete-and-recreate if empty' branch will no longer execute. Add an explicit comment to document this behavior so future readers understand that force rotation intentionally bypasses the empty-index deletion path to avoid the count call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.