Skip to content

Conversation

@unique0lai
Copy link
Collaborator

Upgrade arrow dependency to 1.2.3 and migrate arrow.replace() calls to arrow.shift() for relative time adjustments in the bkmonitor subproject.

The arrow library's replace() method in older versions (like 0.6.0) allowed for both absolute assignments and relative offsets. In arrow 1.0.0 and later, replace() was strictly defined for absolute assignments, and shift() was introduced for relative time adjustments. This PR updates all relative replace() calls to shift() to ensure compatibility with the new arrow version.


Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Dec 4, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@tencentblueking-adm
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

请在 PR 中添加项目标签,例如:project/monitorproject/apmproject/logproject/publicproject/aiops

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

请在 PR 中添加类型标签,例如:fixfeatdocsstylerefactortestchoremerge, perf

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

请在 PR 中添加项目标签,例如:project/monitorproject/apmproject/logproject/publicproject/aiops

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

请在 PR 中添加类型标签,例如:fixfeatdocsstylerefactortestchoremerge, perf

This change ensures consistent use of integer timestamps for all time-related operations, improving accuracy and performance.

Co-authored-by: laymanmlai <[email protected]>
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

请在 PR 中添加类型标签,例如:fixfeatdocsstylerefactortestchoremerge, perf

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

请在 PR 中添加项目标签,例如:project/monitorproject/apmproject/logproject/publicproject/aiops

@unique0lai unique0lai self-assigned this Dec 4, 2025
This change standardizes the use of `int_timestamp` over `timestamp` when working with arrow objects to ensure consistent integer representations of time.

Co-authored-by: laymanmlai <[email protected]>
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

请在 PR 中添加类型标签,例如:fixfeatdocsstylerefactortestchoremerge, perf

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

请在 PR 中添加项目标签,例如:project/monitorproject/apmproject/logproject/publicproject/aiops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants