feat: 特性开关使用 redis 存储 --story=130059585 #1195
Open
+900
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamcleren
reviewed
Jan 22, 2026
| ) | ||
|
|
||
| var ( | ||
| basePath = "bkmonitorv3:unify-query" |
shamcleren
reviewed
Jan 22, 2026
pkg/unify-query/redis/redis.go
Outdated
| } | ||
|
|
||
| // WatchChange 监听指定 channel，监听触发时，channel将会传出信息（用于特性开关等场景） | ||
| var WatchChange = func(ctx context.Context, channel string) (<-chan any, error) { |
Collaborator
There was a problem hiding this comment.
Watch 逻辑应该放到 featureFlag 模块下，另外，redis.go 这个文件，应该在后续的版本更新中逐步弃用了，这种全局定义函数的方式在做单测非常不友好，建议构建一个独立结构体处理 featureFlag 逻辑，redis client 作为入参体现，参考 GetInfluxDBRouter() 中 influxdb.NewRouter(prefix, redis.Client()) 的实现方式，这样 redis 就可以作为整个 mock 注入进去。
shamcleren
reviewed
Jan 22, 2026
pkg/unify-query/redis/featureFlag.go
Outdated
| } | ||
|
|
||
| // GetFeatureFlagsChannel 获取特性开关变更通知的 Redis channel | ||
| func GetFeatureFlagsChannel() string { |
Collaborator
There was a problem hiding this comment.
如果涉及到很多的函数调用，建议抽象成一个独立结构体，同时需要明确哪些是对外哪些是对内函数，特别重要的一点，就是外部依赖使用注入的方式获取，尽量不要使用全局变量的方式。
shamcleren
reviewed
Jan 22, 2026
| var data []byte | ||
| var err error | ||
|
|
||
| // 根据配置选择数据源 |
Collaborator
There was a problem hiding this comment.
如果是做向前兼容设计，默认应该是读 consul，通过配置改成 redis，等功能完整整个验收之后，后续才把默认改成 redis
shamcleren
reviewed
Jan 22, 2026
|
|
||
| var ch <-chan any | ||
| // 根据配置选择监听方式 | ||
| if DataSource == "consul" { |
Collaborator
There was a problem hiding this comment.
太多地方做 consul 还是 redis 的判定了，既然同时支持 consul 和 redis 只需要在启动调用的时候做判定就够了，剩下的 redis 和 consul 都可以公共抽象成两个函数来调用。
shamcleren
reviewed
Jan 22, 2026
|
|
||
| func LoadConfig() { | ||
| DataSource = viper.GetString(DataSourceConfigPath) | ||
| if DataSource != "consul" && DataSource != "redis" { |
Collaborator
There was a problem hiding this comment.
同上，默认使用 consul，达到最坏情况，改动不影响之前的任何功能
shamcleren
reviewed
Jan 22, 2026
pkg/unify-query/service/http/info.go
Outdated
| var err error | ||
| var dataSource string | ||
|
|
||
| if source == "consul" { |
….com:gongzhaolong/bkmonitor-datalink into feat/redis_FeatureFlags/#1010158081130059585
….com:gongzhaolong/bkmonitor-datalink into feat/redis_FeatureFlags/#1010158081130059585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.