refactor: decouple the dependency on ProcessSpec for cnative app #1726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piglei
reviewed
Nov 15, 2024
| from paasng.platform.engine.models.deployment import ProcessTmpl | ||
|
|
||
|
|
||
| def _list_proc_specs(env: ModuleEnvironment) -> List[Dict]: | ||
| """Return all processes specs of an app | ||
| @define |
There was a problem hiding this comment.
之前是不是讨论过 shim 模块的定位模糊，这些代码是不是不要放在 shim 里面？
There was a problem hiding this comment.
已统一调整至 processes.py
| procs = self.deployment.get_processes() | ||
| proc_mgr = ProcessManager(self.engine_app.env) | ||
| proc_mgr.sync_processes_specs(procs) | ||
| proc_mgr.sync_processes_probes(procs) |
There was a problem hiding this comment.
这里不能完全去除，比如 sync_processes_probes 仍然需要（刚好在改这块）
There was a problem hiding this comment.
这里是处理的云原生应用，云原生应用的探针都在 ModuleProcessSpec.probes 定义, 如果有的话，应该想办法统一到 ModuleProcessSpec.probes 中。sync_processes_probes 主要是同步到 paas_wl.bk_app.processes.models.ProcessProbe 中，里面的探针仅用于普通应用
narasux
reviewed
Nov 19, 2024
narasux
reviewed
Nov 19, 2024
narasux
reviewed
Nov 19, 2024
piglei
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解耦云原生应用对 paas_wl 侧 ProcessSpec 等模型的依赖，改为直接从线上解析 Spec