Fix pep8 and UT issues #79
Conversation
|
@r0h4n @nthomas-redhat @shtripat Please review |
|
Changes Unknown when pulling e46363b on nnDarshan:FixPep8 into ** on Tendrl:master**. |
| from tendrl.commons.persistence.etcd_persister import EtcdPersister | ||
|
|
||
| config = load_config( | ||
| "gluster-integration", | ||
| "/etc/tendrl/tendrl.conf" |
There was a problem hiding this comment.
Might not work. tendrl.conf is gone and you will have module specific files. Also this function expected to load yaml files
There was a problem hiding this comment.
+1 @nnDarshan , this is a yaml loader, ensure you pass a yaml file path here
|
Changes Unknown when pulling daf53a5 on nnDarshan:FixPep8 into ** on Tendrl:master**. |
|
Changes Unknown when pulling bd2c79c on nnDarshan:FixPep8 into ** on Tendrl:master**. |
| config = TendrlConfig() | ||
| config = load_config( | ||
| "ceph-integration", | ||
| "/etc/tendrl/ceph-integration/ceph-integration.conf.yaml" |
There was a problem hiding this comment.
We are following the naming as ceph-integration.yaml
tendrl-bug-id: Tendrl#62 Signed-off-by: nnDarshan <[email protected]>
|
Changes Unknown when pulling 0faaa46 on nnDarshan:FixPep8 into ** on Tendrl:master**. |
|
Please update this PR |
tendrl-bug-id: #62
Signed-off-by: nnDarshan [email protected]