Conversation
Author
|
Changes Unknown when pulling e46363b on nnDarshan:FixPep8 into ** on Tendrl:master**. |
cybernth
requested changes
Jan 16, 2017
|
|
||
| config = load_config( | ||
| "gluster-integration", | ||
| "/etc/tendrl/tendrl.conf" |
There was a problem hiding this comment.
Might not work. tendrl.conf is gone and you will have module specific files. Also this function expected to load yaml files
There was a problem hiding this comment.
+1 @nnDarshan , this is a yaml loader, ensure you pass a yaml file path here
|
Changes Unknown when pulling daf53a5 on nnDarshan:FixPep8 into ** on Tendrl:master**. |
|
Changes Unknown when pulling bd2c79c on nnDarshan:FixPep8 into ** on Tendrl:master**. |
shtripat
reviewed
Jan 16, 2017
| config = TendrlConfig() | ||
| config = load_config( | ||
| "ceph-integration", | ||
| "/etc/tendrl/ceph-integration/ceph-integration.conf.yaml" |
Member
There was a problem hiding this comment.
We are following the naming as ceph-integration.yaml
tendrl-bug-id: Tendrl#62 Signed-off-by: nnDarshan <[email protected]>
|
Changes Unknown when pulling 0faaa46 on nnDarshan:FixPep8 into ** on Tendrl:master**. |
|
Please update this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tendrl-bug-id: #62
Signed-off-by: nnDarshan [email protected]