Closed
Conversation
pjonsson
force-pushed
the
viewstateoptions-all-params
branch
from
ab1e52b to
6e6f679
Compare
4 tasks
There are two arguments required for ViewStateOptions, so put in a second argument with an undefined value which is what is used at other call sites.
pjonsson
force-pushed
the
viewstateoptions-all-params
branch
from
6e6f679 to
5e8005b
Compare
pjonsson
added a commit
to pjonsson/TerriaMap
that referenced
this pull request
Feb 15, 2025
There are two arguments required for ViewStateOptions, so put in a second argument with an undefined value which is what is used at other call sites. This mirrors the same change in terriajs: TerriaJS/terriajs#7204
Collaborator
|
the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
There are two arguments required
for ViewStateOptions, so put in
a second argument with an undefined
value which is what is used
at other call sites.
Test me
Test only changes.
Checklist
doc/.