Update to react-virtual 2.10.4

[pjonsson]

What this PR does

Commit 236b9c9 locked the version
to 2.3.2 to avoid a bug in 2.4. The
bug in question has hopefully been
fixed in the past 3 years.

Test me

No idea how to test this.

Checklist

• There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
• I've updated relevant documentation in doc/.
• I've updated CHANGES.md with what I changed.
• I've provided instructions in the PR description on how to test this PR.

[zoran995]

My previous tests regarding this was that this line is causing issue with react-virtual

terriajs/lib/ReactViews/Tools/ItemSearchTool/SearchResults.tsx

Line 31 in dd2a2a5

const parentRef = React.createRef<HTMLDivElement>();

createRef is not valid in functional components and useRef should be used instead.

react-virtual is added to support search inside items, here is the PR #5112, maybe you can utilize the info from that PR to test this one. The other relevant doc are here https://docs.terria.io/guide/connecting-to-data/item-search/ and https://docs.terria.io/guide/connecting-to-data/item-search/indexed-item-search/. I am not aware of other easier way to really test this

[pjonsson]

terriajs/lib/ReactViews/Tools/ItemSearchTool/SearchResults.tsx

Line 31 in dd2a2a5

const parentRef = React.createRef<HTMLDivElement>();

createRef is not valid in functional components and useRef should be used instead.

@zoran995 Thank you for the help. If you really mean that createRef is not valid in functional components, and SearchResults is a functional component, that sounds like an outright bug that should be fixed separately. Is there something subtle about it, or can createRef just be replaced with useRef in general?

[zoran995]

They are the same just intended to be used in different type of components, here is react docs
https://react.dev/reference/react/createRef#migrating-from-a-class-with-createref-to-a-function-with-useref. It might be necessary just to pass null as default value to satisfy typescript.
But as everything in programming it would be good to test if everything works correctly

[zoran995]

@pjonsson there is an example link in #7290 that can be used for testing the item search tool.

[pjonsson]

Rebased to latest main to resolve conflicts, and updated CHANGES.md.

[zoran995]

Hi @pjonsson, can you rebase this on the latest main?

[pjonsson]

@zoran995 sorry, big pile of stuff in the PR queue so hard to keep track of what needs to be rebased after things are merged. Just rebased this and #7411 that you approved yesterday.

[ljowen]

Tested with @ykiu 's link locally

[zoran995]

Thanks @pjonsson. Sometimes it’s easier for us to ping you about rebasing something than for you to constantly rebase everything.