CI: sync versions of dependencies #7301
Conversation
The ^ on the request version was lost in TerriaJS#6986, so put it back so we get a slightly less ancient version that is what terriajs-server also uses. Also remove the addition of moment, that is already installed because of the dependencies of terriajs.
pjonsson
force-pushed
the
ci-build-updates
branch
from
f5f629e to
1eed359
Compare
|
Noticed that moment is already installed in TerriaMap because of the dependencies of terriajs, so updated this to not |
| @@ -19,7 +19,7 @@ gh api /repos/${GITHUB_REPOSITORY}/statuses/${GITHUB_SHA} -f state=pending -f co | |||
| # Install some tools we need from npm | |||
| npm install -g https://github.com/terriajs/sync-dependencies | |||
| npm install -g yarn@^1.19.0 | |||
| yarn add -W request@2.83.0 | |||
| yarn add -W request@^2.88.2 | |||
There was a problem hiding this comment.
Sync-dependencies got converted to got 5 years ago: TerriaJS/sync-dependencies#3
What is it in this workflow that requires installing request?
There was a problem hiding this comment.
It's buildprocess/ci-cleanup.js that uses request.
There was a problem hiding this comment.
AFAICT it's only used in buildprocess/ci-cleanup.js now that's we running node v20 on CI we could just use fetch here instead
There was a problem hiding this comment.
That seems reasonable.
The deployment stuff is difficult to test for those of us who don't push to a branch of this repository though, could this PR be merged to fix the immediate issues and then someone at Terria takes care of the long-term solution of converting to fetch when that is convenient for you?
There was a problem hiding this comment.
I've created a PR here just need to work out where the type error is coming from #7547
There was a problem hiding this comment.
Replacing the deprecated request is better than updating it, so closing this in favor of #7547.
What this PR does
The ^ on the request version was lost
in #6986 (cc @ljowen), so put it back so
we get a slightly less ancient version that
is what terriajs-server also uses.
Also remove the addition of moment,
that is already installed because
of the dependencies of terriajs.
Test me
Run the CI-flow that runs this script.
Checklist
doc/.