Only await something thenable #7355

pjonsson · 2024-12-08T12:05:51Z

This avoids pausing the execution
until the next microtask.

I believe this is tested by CI?

There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
I've updated relevant documentation in doc/.
I've updated CHANGES.md with what I changed.
I've provided instructions in the PR description on how to test this PR.

lib/Models/Catalog/CatalogGroups/ThreddsCatalogGroup.ts

na9da · 2024-12-09T01:55:57Z

@pjonsson. Thanks for the improvements - other than the THREDDS one, the other changes look correct to me.

This avoids pausing the execution until the next microtask.

na9da reviewed Dec 9, 2024

View reviewed changes

lib/Models/Catalog/CatalogGroups/ThreddsCatalogGroup.ts Outdated Show resolved Hide resolved

pjonsson force-pushed the remove-non-promise-await branch from 540e124 to de1d44b Compare December 9, 2024 09:07

pjonsson mentioned this pull request Dec 9, 2024

ThreddsCatalogGroup: fix interface types #7356

Merged

4 tasks

pjonsson requested a review from na9da February 20, 2025 20:41

Only await something thenable

773c893

This avoids pausing the execution until the next microtask.

pjonsson force-pushed the remove-non-promise-await branch from de1d44b to 773c893 Compare March 9, 2025 12:02

Provide feedback