Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert search box and results to functional component #7477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zoran995
Copy link
Collaborator

@zoran995 zoran995 commented Feb 19, 2025

What this PR does

Fixes: #7518

This is needed for mobx-react upgrade as part of an upgrade to react 18.

Test me

Verify that search box and results for the same as on main:

  • search results are properly renderer and click on search results
  • clearing search box closes the search results panel
  • clearing the search box removes the marker from the map

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • [ ] I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@zoran995 zoran995 force-pushed the functional-search-box branch from a9978d0 to f4e193d Compare February 19, 2025 23:24
@zoran995 zoran995 mentioned this pull request Feb 28, 2025
15 tasks
@zoran995 zoran995 force-pushed the functional-search-box branch from f4e193d to 31d65fe Compare March 7, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tsify SearchBoxAndResults and convert to functional component
2 participants