fix basemaps ordering #7537
Open
fix basemaps ordering #7537
+38
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na9da
reviewed
Mar 11, 2025
| if (baseMapItem.item && !ModelReference.isRemoved(baseMapItem.item)) { | ||
| const itemModel = this.terria.getModelById( | ||
| BaseModel, | ||
| String(baseMapItem.item) |
There was a problem hiding this comment.
Doubt: What's the reason we need to wrap with String() here?
na9da
reviewed
Mar 11, 2025
| - Remove unused pmtiles dependency. | ||
| - Update data styling docs | ||
| - Remove unused babel/eslint-parser dependency. | ||
| - Hide 'Story' button in mobile view if story panel is active. | ||
| - Update empty workbench help text | ||
| - Remove unused `arraysAreEqual`, `autoUpdate`, `flattenNested`, `freezeInDebug`, `isPromise`, `loadJsonp`, `OrUndefined`, and `superGet` files from lib/Core. | ||
| - Fix basemaps order |
There was a problem hiding this comment.
Suggestion: It might be good to add that it now follows the order given by enabledBaseMaps setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #7169
Supersedes the #7170 since there was no feedback on it by PR author.
Test me
How should reviewers test this? (Hint: If you want to provide a test catalog item, create a Gist of its catalog JSON, add its url and your branch name to this url:
http://ci.terria.io/<branch name>/#clean&<raw url of your gist>, and then paste that in the body of this PR)Checklist
doc/.