Upgrade blueprintjs from 3 to 5 #157
Conversation
Upgrade blueprintjs 5
|
Hey @ryan-stackwave, Awesome work and thank you so much for contributing to this repo! I'll be able to give you some more specific feedback about this PR after I've had some time to get up to speed with everything needed to go to bp3 --> bp5! In order for this PR to make it into this repo, we at teselagen need to roughly coordinate its release with the upgrading of our own private closed source repository from bp3 to bp5. It sounds like there is a good amount of enthusiasm at our company to make this change happen hopefully sometime within the next 6 months but we'll probably want to first make sure there won't be any horribly unexpected migration gotchas. That's where this repo will be a good test case! It looks like our automated cypress tests are passing on your branch for the ui package - https://cloud.cypress.io/projects/gwixeq/branches/upgrade-blueprintjs-5/runs And perhaps failing in a few more spots (~20?) for the ove package - https://cloud.cypress.io/projects/mp89gp/branches/upgrade-blueprintjs-5/runs Those tests will all need to be passing (except for the 1 or 2 tests that are currently failing on master) before this branch can be merged in as well :) I've made a separate ticket in this repo for tracking the todos for both repos - #158 Please let me know if that all makes sense and if the linked ticket needs to have any bullet points added to it. Thanks very much! |
|
@tnrich sounds good, thanks! Let me know if there's anything I can do to help as y'all get closer to upgrade. |
|
@tnrich what do you think about collaborating in the meantime on something like a 2.0-beta branch in the tg-oss repo or in master on my repo that we can release to npm for upgrading some libraries, such as blueprint, and potentially removing conflicts with React 19? This would allow folks who are getting some library conflicts to move onto the v2 line while your internal code continues to integrate with the v0 line. Hopefully this will also make your internal upgrade much smoother in 6 months and give you some experience with any patterns of issues created by the upgrades. |
|
@ryan-stackwave that sounds good to me! ❤️ |
|
@tnrich , excellent. Would you prefer that we create a branch in the tg-oss repo or use my master? |
|
I think a branch in tg-oss would be preferable! Thanks for taking this on :) |
|
Actually, on 2nd thought maybe just go ahead and keep working on your fork When necessary I can make a branch off of it in the teselagen tg-oss repo |
|
@ryan-stackwave how's this looking :) |
@tnrich, apologies, I've been redirected to other priorities for now but I'll reach out when I get some time to look at this again. Please let me know if you need me to be a guinea pig any of your team's progress on upgrades. |
@tnrich