Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Throw correct exception when using File.Replace with case-only changes on MacOS #638

Merged
merged 6 commits into from
Aug 12, 2024
Merged

fix: Throw correct exception when using File.Replace with case-only changes on MacOS #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff34a19
Add tests for case-only changes in File.Copy, File.Move and File.Replace
vbreuss Aug 11, 2024
400bedf
Ensure correct casing in `Directory.Move` tests
vbreuss Aug 11, 2024
97d39e7
Fix Replace test for Linux
vbreuss Aug 11, 2024
c7b8eca
Throw correct exception on MacOS
vbreuss Aug 12, 2024
668473e
Use correct exception message
vbreuss Aug 12, 2024
7c3a792
Fix indentation
vbreuss Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Source/Testably.Abstractions.Testing/Helpers/ExceptionFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ internal static IOException ProcessCannotAccessTheFile(string path, int hResult)
$"The process cannot access the file '{path}' because it is being used by another process.",
hResult);

internal static IOException ReplaceSourceMustBeDifferentThanDestination(
string sourcePath, string destinationPath)
=> new($"The source '{sourcePath}' and destination '{destinationPath}' are the same file.", -2146232800);

#pragma warning disable MA0015 // Specify the parameter name
internal static ArgumentException SearchPatternCannotContainTwoDots()
=> new(
Expand Down
6 changes: 6 additions & 0 deletions Source/Testably.Abstractions.Testing/Storage/InMemoryStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,12 @@ public IStorageContainer GetOrCreateContainer(
throw ExceptionFactory.AccessToPathDenied(source.FullPath);
}

if (_fileSystem.Execute.IsMac &&
source.FullPath.Equals(destination.FullPath, StringComparison.OrdinalIgnoreCase))
{
throw ExceptionFactory.ReplaceSourceMustBeDifferentThanDestination(source.FullPath, destination.FullPath);
}

using (_ = sourceContainer.RequestAccess(
FileAccess.ReadWrite,
FileShare.None,
Expand Down
2 changes: 1 addition & 1 deletion Tests/Testably.Abstractions.Tests/FileSystem/Directory/MoveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public void Move_CaseOnlyChange_ShouldMoveDirectoryWithContent(string path)
FileSystem.Directory.Exists(source).Should().Be(!Test.RunsOnLinux);
FileSystem.Should().HaveDirectory(destination);
FileSystem.Directory.GetDirectories(".").Should()
.ContainSingle(d => d.Contains(destination));
.ContainSingle(d => d.Contains(destination, StringComparison.Ordinal));
FileSystem.Directory.GetFiles(destination, initialized[1].Name)
.Should().ContainSingle();
FileSystem.Directory.GetDirectories(destination, initialized[2].Name)
Expand Down
27 changes: 27 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/File/CopyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,33 @@ public abstract partial class CopyTests<TFileSystem>
: FileSystemTestBase<TFileSystem>
where TFileSystem : IFileSystem
{
[SkippableTheory]
[AutoData]
public void Copy_CaseOnlyChange_ShouldThrowIOException_ExceptOnLinux(
string name, string contents)
{
string sourceName = name.ToLowerInvariant();
string destinationName = name.ToUpperInvariant();
FileSystem.File.WriteAllText(sourceName, contents);

Exception? exception = Record.Exception(() =>
{
FileSystem.File.Copy(sourceName, destinationName);
});

if (Test.RunsOnLinux)
{
exception.Should().BeNull();
FileSystem.File.Exists(sourceName).Should().BeTrue();
FileSystem.File.Exists(destinationName).Should().BeTrue();
}
else
{
exception.Should()
.BeException<IOException>(hResult: Test.RunsOnWindows ? -2147024816 : 17);
}
}

[SkippableTheory]
[AutoData]
public void
Expand Down
2 changes: 2 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/File/MoveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ public void Move_CaseOnlyChange_ShouldMoveFileWithContent(

FileSystem.Should().HaveFile(destinationName)
.Which.HasContent(contents);
FileSystem.Directory.GetFiles(".").Should()
.ContainSingle(d => d.Contains(destinationName, StringComparison.Ordinal));
}

[SkippableTheory]
Expand Down
36 changes: 36 additions & 0 deletions Tests/Testably.Abstractions.Tests/FileSystem/File/ReplaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,42 @@ public abstract partial class ReplaceTests<TFileSystem>
: FileSystemTestBase<TFileSystem>
where TFileSystem : IFileSystem
{
[SkippableTheory]
[AutoData]
public void Replace_CaseOnlyChange_ShouldThrowIOException(
string name, string contents)
{
string sourceName = name.ToLowerInvariant();
string destinationName = name.ToUpperInvariant();
FileSystem.File.WriteAllText(sourceName, contents);
FileSystem.File.WriteAllText(destinationName, "other-content");

Exception? exception = Record.Exception(() =>
{
FileSystem.File.Replace(sourceName, destinationName, null);
});


if (Test.RunsOnLinux)
{
exception.Should().BeNull();
FileSystem.File.Exists(sourceName).Should().BeFalse();
FileSystem.File.Exists(destinationName).Should().BeTrue();
}
else if (Test.RunsOnMac)
{
exception.Should().BeException<IOException>(
hResult: -2146232800,
messageContains: $"The source '{FileSystem.Path.GetFullPath(sourceName)}' and destination '{FileSystem.Path.GetFullPath(destinationName)}' are the same file");
}
else
{
exception.Should().BeException<IOException>(
hResult: -2147024864,
messageContains: "The process cannot access the file");
}
}

[SkippableTheory]
[AutoData]
public void
Expand Down
Loading