27 fixed by developer tests in Nifi

[DaniellaHubble]

Tests in org.apache.nifi.registry.security.ldap.tenants.LdapUserGroupProviderTest were fixed by developers in the following commit (NIFI-11603 Refactored Socket-based tests to use Dynamic Ports). Tests pass under NonDex using the following command: mvn -pl nifi-registry/nifi-registry-core/nifi-registry-framework edu.illinois:nondex-maven-plugin:2.2.1-SNAPSHOT:nondex -Dtest=org.apache.nifi.registry.security.ldap.tenants.LdapUserGroupProviderTest

[darko-marinov]

@DaniellaHubble where are the logs for these runs? Did you try with -DnondexRuns=10 (or even =100 if not too slow)?

@Ajitesh27 can you please inspect the logs here?

[DaniellaHubble]

I ran it with -DnondexRuns=100, and (as far as I can tell) no tests failed. The output log is attached. Let me know if there is anything else you'd like to see.
TerminalLogsForNifi.pdf

[Ajitesh27]

Discussed in class. You have to change the commit hash.

[DaniellaHubble]

I've updated the commit Hash.
"Regular" testing passes but Nondex fails at: 889767683cb7ce3e3024ac41e11252ae93fb00b8
"Regular" testing and Nondex passes at: 0d0ba1ca41dd1ffb633ed2fc1f74b17e460de0f9

Logs are at /home/dhubble2/logsforPR1416.txt on my vm.

[Ajitesh27]

LGTM

[darko-marinov]

"Regular" testing passes but Nondex fails at: 889767683cb7ce3e3024ac41e11252ae93fb00b8
"Regular" testing and Nondex passes at: 0d0ba1ca41dd1ffb633ed2fc1f74b17e460de0f9

These two commits are not adjacent, i.e., neither is the parent or child of the other. If some commit is claimed to be the fix, then the test should pass after the fix but fail right before the fix.

[DaniellaHubble]

The broken commit directly before the working commit in the whole Nifi repo is: 99b0cd42ef951bfd46ce2ad3cee321facfe14b1c
Proof of this has been added to the log file /home/dhubble2/logsforPR1416.txt

The previous commit I gave you was the commit right before the working commit in the folder I was working in, not the whole project. Sorry for the confusion.

[darko-marinov]

I'm still confused. https://github.com/TestingResearchIllinois/idoft/pull/1416/files currently claims that apache/nifi@0d0ba1c fixed the tests, but I don't know if you have (1) a log showing no failures in 0d0ba1ca41dd1ffb633ed2fc1f74b17e460de0f9 and (2) a log showing failures in c19ec90030ac401315d425a2fb26e6bf3ecf8e66.

Also, the URL for DeveloperFixed should be in the last column (Notes) not in the second last column (PR Link).

[DaniellaHubble]

To clearly show 0d0ba1ca41dd1ffb633ed2fc1f74b17e460de0f9 passes, I moved those logs to its own folder: /home/dhubble2/logpassesATodoba1.txt

I just realized I was also on a folder (not the whole repo) when I thought 99b0cd42ef951bfd46ce2ad3cee321facfe14b1c (shows failures in log home/dhubble2/logsforPR1416.txt) was the commit just prior to the working one. I am currently testing c19ec90030ac401315d425a2fb26e6bf3ecf8e66 and I will update you shortly on that.

Update: Logs of c19ec90030ac401315d425a2fb26e6bf3ecf8e66 passing under test but failing under Nondex are at /home/dhubble2/brokeCommit.txt