Feature/indeterminate progress with elapsed#3710
Closed
IAdityaKaushal wants to merge 2 commits intoTextualize:masterfrom
Closed
Feature/indeterminate progress with elapsed#3710IAdityaKaushal wants to merge 2 commits intoTextualize:masterfrom
IAdityaKaushal wants to merge 2 commits intoTextualize:masterfrom
Conversation
- Add MathRenderer class for converting Latex math to Unicode - Integrate math rendering into markdown processing - Supports inline ($..$) and block (94329...94329) math expressions - Add tests for math rendering functionality Addreses Textualize#3159
- Add indeterminate mode to progress bars that shows animated pulse - Display elapsed time during indeterminate state - Show ?/total indicator for indeterminate tasks - Support transition from indeterminate to determinate state - Add comprehensive tests and examples Addresses feature request Textualize#3572
Member
|
There is way too much going on in this PR. There seems to be code unrelated to progress bars. At this point, I can't accept new features. Especially if those features could be implemented outside of the core library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
This PR adds support for indeterminate progress bars that show elapsed time and expected total, addressing issue #3572. Linked here #3572
Problem
Users requested a way to display progress bars in an indeterminate state (animated pulse) while still showing elapsed time and an indicator like
?/total. Currently, usingstart=Falseortotal=Noneeither doesn't show elapsed time or doesn't allow for the desired display format.Solution
indeterminateandexpected_totalparameters to tasksIndeterminateTaskProgressColumnto display?/totalfor indeterminate tasksFeatures Added
indeterminate=Trueand optionalexpected_totalIndeterminateTaskProgressColumndisplays?/totalfor indeterminate tasksExample Usage